public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: linux-arm-kernel@lists.arm.linux.org.uk
Cc: linux-omap@vger.kernel.org, Sanjeev Premi <premi@ti.com>,
	Tony Lindgren <tony@atomide.com>
Subject: [PATCH 1/4] ARM: OMAP: Fix compiler warnings in gpmc.c
Date: Thu, 30 Oct 2008 19:11:15 -0700	[thread overview]
Message-ID: <1225419078-32213-2-git-send-email-tony@atomide.com> (raw)
In-Reply-To: <1225419078-32213-1-git-send-email-tony@atomide.com>

From: Sanjeev Premi <premi@ti.com>

Fix these compiler warnings:

gpmc.c: In function 'gpmc_init':
gpmc.c:432: warning: 'return' with a value, in function returning void
gpmc.c:439: warning: 'return' with a value, in function returning void

Signed-off-by: Sanjeev Premi <premi@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 arch/arm/mach-omap2/gpmc.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
index 763bdbe..2249049 100644
--- a/arch/arm/mach-omap2/gpmc.c
+++ b/arch/arm/mach-omap2/gpmc.c
@@ -429,18 +429,16 @@ void __init gpmc_init(void)
 	gpmc_l3_clk = clk_get(NULL, ck);
 	if (IS_ERR(gpmc_l3_clk)) {
 		printk(KERN_ERR "Could not get GPMC clock %s\n", ck);
-		return -ENODEV;
+		BUG();
 	}
 
 	gpmc_base = ioremap(l, SZ_4K);
 	if (!gpmc_base) {
 		clk_put(gpmc_l3_clk);
 		printk(KERN_ERR "Could not get GPMC register memory\n");
-		return -ENOMEM;
+		BUG();
 	}
 
-	BUG_ON(IS_ERR(gpmc_l3_clk));
-
 	l = gpmc_read_reg(GPMC_REVISION);
 	printk(KERN_INFO "GPMC revision %d.%d\n", (l >> 4) & 0x0f, l & 0x0f);
 	/* Set smart idle mode and automatic L3 clock gating */
-- 
1.5.6.rc3.21.g8c6b5


  reply	other threads:[~2008-10-31  2:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-31  2:11 [PATCH 0/4] omap fixes for -rc series Tony Lindgren
2008-10-31  2:11 ` Tony Lindgren [this message]
2008-10-31  2:11   ` [PATCH 2/4] ARM: OMAP: Fix debugfs_create_*'s error checking method for arm/plat-omap Tony Lindgren
2008-10-31  2:11     ` [PATCH 3/4] ARM: OMAP: Fix get_irqnr_and_base to clear spurious interrupt bits Tony Lindgren
2008-10-31  2:11       ` [PATCH 4/4] ARM: OMAP: Fix define for twl4030 irqs Tony Lindgren
2008-11-06 14:28 ` [PATCH 0/4] omap fixes for -rc series Russell King - ARM Linux
2008-11-06 17:29   ` git pull request for omap-fixes (Re: [PATCH 0/4] omap fixes for -rc series) Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1225419078-32213-2-git-send-email-tony@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-omap@vger.kernel.org \
    --cc=premi@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox