From: Tony Lindgren <tony@atomide.com>
To: ben-linux@fluff.org
Cc: linux-i2c@vger.kernel.org, linux-omap@vger.kernel.org,
Tony Lindgren <tony@atomide.com>
Subject: [PATCH 10/10] I2C: Ensure write posting for critical i2c-omap writes
Date: Thu, 30 Oct 2008 19:29:49 -0700 [thread overview]
Message-ID: <1225420189-630-11-git-send-email-tony@atomide.com> (raw)
In-Reply-To: <1225420189-630-10-git-send-email-tony@atomide.com>
Otherwise we may race, or will get spurious I2C interrupts:
i2c_omap.1: XDR IRQ while no data to send
...
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
drivers/i2c/busses/i2c-omap.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index b09f03f..3f0d178 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -685,6 +685,9 @@ omap_i2c_isr(int this_irq, void *dev_id)
break;
}
omap_i2c_write_reg(dev, OMAP_I2C_DATA_REG, w);
+
+ /* Ensure write posting of the write */
+ omap_i2c_read_reg(dev, OMAP_I2C_DATA_REG);
}
omap_i2c_ack_stat(dev,
stat & (OMAP_I2C_STAT_XRDY | OMAP_I2C_STAT_XDR));
--
1.5.6.rc3.21.g8c6b5
prev parent reply other threads:[~2008-10-31 2:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-31 2:29 [PATCH 0/10] git-pull-request for i2c-omap fixes and updates, v3 Tony Lindgren
2008-10-31 2:29 ` [PATCH 1/10] i2c-omap: Do not use interruptible wait call in omap_i2c_xfer_msg Tony Lindgren
2008-10-31 2:29 ` [PATCH 2/10] i2c-omap: Close suspected race between omap_i2c_idle() and omap_i2c_isr() Tony Lindgren
2008-10-31 2:29 ` [PATCH 3/10] i2c-omap: Add high-speed support to omap-i2c Tony Lindgren
2008-10-31 2:29 ` [PATCH 4/10] i2c-omap: FIFO handling support and broken hw workaround for i2c-omap Tony Lindgren
2008-10-31 2:29 ` [PATCH 5/10] i2c-omap: Add support for omap34xx Tony Lindgren
2008-10-31 2:29 ` [PATCH 6/10] i2c-omap: Mark init-only functions as __init Tony Lindgren
2008-10-31 2:29 ` [PATCH 7/10] i2c-omap: Don't compile in OMAP15xx I2C ISR for non-OMAP15xx builds Tony Lindgren
2008-10-31 2:29 ` [PATCH 8/10] i2c-omap: Clean-up i2c-omap Tony Lindgren
2008-10-31 2:29 ` [PATCH 9/10] i2c-omap: fix I2C timeouts due to recursive omap_i2c_{un,}idle() Tony Lindgren
2008-10-31 2:29 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225420189-630-11-git-send-email-tony@atomide.com \
--to=tony@atomide.com \
--cc=ben-linux@fluff.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox