From: "stanley.miao" <stanley.miao@windriver.com>
To: David Brownell <david-b@pacbell.net>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] OMAP: Switch to gpio_direction_output in OMAP_LDP.
Date: Fri, 21 Nov 2008 16:21:20 +0800 [thread overview]
Message-ID: <1227255680.14497.78.camel@localhost> (raw)
In-Reply-To: <200811202352.10830.david-b@pacbell.net>
On Thu, 2008-11-20 at 23:52 -0800, David Brownell wrote:
> On Thursday 20 November 2008, stanley.miao wrote:
> >
> > > Use gpio_set_value() to replace omap_set_gpio_dataout(), except
> > > when initializing. The reset pin *was* being toggled...
> >
> > These actions are in init function. so keep omap_set_gpio_dataout() in
> > place.
Sorry, it should be "keep gpio_direction_out() in place". I made a
mistake, but the code is right.
Stanley.
>
> No, omap_set_gpio_dataout() is gone. You can't call it any more.
>
> gpio_direction_output(gpio, initial_value)
>
> is what you'd want after gpio_request().
prev parent reply other threads:[~2008-11-21 8:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-20 14:01 [PATCH] OMAP: Switch to gpio_direction_output in OMAP_LDP Stanley.Miao
2008-11-20 19:11 ` David Brownell
2008-11-21 7:50 ` stanley.miao
2008-11-21 7:52 ` David Brownell
2008-11-21 8:21 ` stanley.miao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1227255680.14497.78.camel@localhost \
--to=stanley.miao@windriver.com \
--cc=david-b@pacbell.net \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox