Re: [PATCH] ARM: Parse ATAG_VIDEOLFB to screen_info

[Tomi Valkeinen <tomi.valkeinen@nokia.com>]

Hi,

On Mon, 2008-11-24 at 12:12 +0000, ext Russell King - ARM Linux wrote:
> On Fri, Nov 21, 2008 at 12:25:36PM +0200, Tomi Valkeinen wrote:
> > Parse ATAG_VIDEOLFB received from bootloader to screen_info struct,
> > so that video drivers can use the information.
> 
> Boot loaders tend to be absolutely diabolical about passing correct
> information to the kernel, so I really don't want to see such platform
> specific stuff being passed.  Please put it in the board specific file
> instead, just like everyone else does.

I though a general file would be better, because:

a) the tag contains only generic stuff and it is parsed directly to
screen_info, which is also generic

b) ATAG_VIDEOTEXT, which is very similar to ATAG_VIDEOLFB, is parsed in
setup.c also.

c) it is not used anywhere currently

So I don't see anything platform or board specific there. Or do you mean
that there are broken bootloaders out there and this would mess up
screen_info?

 Tomi