From: Kalle Jokiniemi <kalle.jokiniemi-sMOQStClEysAvxtiuMwx3w@public.gmane.org>
To: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
Cc: "Liam Girdwood" <lrg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org>,
"Mark Brown" <broonie-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
OMAP <linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Högander Jouni"
<jouni.hogander-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
Subject: Re: [patch 2.6.29-rc3-git 2/2] USB: disable twl4030 USB regulators when cable unplugged
Date: Wed, 11 Feb 2009 08:25:12 +0200 [thread overview]
Message-ID: <1234333512.17391.31.camel@ubuntu> (raw)
In-Reply-To: <200902101152.59526.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
On Tue, 2009-02-10 at 11:52 -0800, David Brownell wrote:
> On Tuesday 10 February 2009, Kalle Jokiniemi wrote:
> > > This patch disables LDO regulators VUSB1V5, VUSB1V8, and VUSB3V1
> > > when the USB cable is unplugged, to eliminate that source of power
> > > waste. (Enabled LDOs consume power at all times.)
> >
> > Please put this on hold for a while. This won't work if we don't have
> > TWL regulator support enabled.
>
> So Kconfig should have TWL4030_USB depend on REGULATOR_TWL4030?
Yes.
>
>
> > Also it's missing error value checking.
>
> You mean like in the ldo_init() stuff? Fair enough.
I mean, if regulator_get fails.
- Kalle
>
> - Dave
>
>
> > I'll post new patch(es) soon.
> >
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-02-11 6:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-08 18:52 [patch 2.6.29-rc3-git 2/2] USB: disable twl4030 USB regulators when cable unplugged David Brownell
2009-02-10 13:08 ` Kalle Jokiniemi
2009-02-10 15:19 ` Mark Brown
[not found] ` <200902081053.00255.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2009-02-10 14:06 ` Kalle Jokiniemi
2009-02-10 19:52 ` David Brownell
[not found] ` <200902101152.59526.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2009-02-11 6:25 ` Kalle Jokiniemi [this message]
2009-02-26 22:16 ` Liam Girdwood
[not found] ` <1235686596.31223.106.camel-Pyf+wNJ1SdNifHs85vQuMtBc4/FLrbF6@public.gmane.org>
2009-02-26 22:40 ` David Brownell
[not found] ` <200902261440.04129.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2009-02-27 6:19 ` Kalle Jokiniemi
2009-02-27 12:29 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1234333512.17391.31.camel@ubuntu \
--to=kalle.jokiniemi-smoqstcleysavxtiumwx3w@public.gmane.org \
--cc=broonie-GFdadSzt00ze9xe1eoZjHA@public.gmane.org \
--cc=david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org \
--cc=jouni.hogander-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lrg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox