Re: [PATCH 0/2] TWL: USB: Start using twl4030/5030 regulator driver

[Kalle Jokiniemi <kalle.jokiniemi-sMOQStClEysAvxtiuMwx3w@public.gmane.org>]

On Wed, 2009-02-11 at 12:47 +0200, Kalle Jokiniemi wrote:
> On Tue, 2009-02-10 at 23:23 -0800, David Brownell wrote:
> > On Tuesday 10 February 2009, Kalle Jokiniemi wrote:
> > > These couple of patches enable dynamic swithcing of the
> > > regulators used by twl4030 usb tranceiver.
> > > 
> > > This set replaces the single patch "USB: disable twl4030
> > > USB regulators when cable unplugged" sent previously.
> > > The change to previous version is that possible errors
> > > in regulator_get are now handled and the twl4030 usb
> > > driver requires TWL_REGULATOR support to be compiled.
> > 
> > It'd make more sense to me as a single patch ... :)
> 
> OK, I'll put them together.
> 
> > 
> > And also, instead of *continuing* after the regulators
> > can't be acquired, it's better to abort.  It's not
> > going to be able to do anything ... so don't finish
> > probing, and don't register this "dead" transceiver.
> 
> Makes sense. I'll fix that.

I ran into some trouble with the merged fix. For some reason clearing
the VUSB3V1_DEV_GRP register causes VUSB_DEDICATED2.VUSB3V1_SLEEP bit to
be enabled. This means that once VUSB3V1_DEV_GRP is put back to enabled
state (VUSB3V1 changed to be part of P1 group again), VUSB3V1 does not
go ACTIVE, but SLEEP state instead.

Anyone have a clue what might cause this?

The VUSB_DEDICATED2.VUSB3V1_SLEEP bit remaps ACTIVE state to SLEEP.

I tested with the original patch as well and it has the same behaviour.
But I'm quite sure that I did not see this when I was doing the original
patch.

I can workaround this by clearing the VUSB_DEDICATED2.VUSB3V1_SLEEP
every time we enable the VUSB3V1 regulator, but I'd rather know why it
changes in the first place.

Dropped LKM from the cc...

- Kalle


> 
> -Kalle
> 
> > 
> > - Dave
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html