From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Jokiniemi Subject: Re: [patch 2.6.29-rc3-git 2/2] USB: disable twl4030 USB regulators when cable unplugged Date: Fri, 27 Feb 2009 08:19:33 +0200 Message-ID: <1235715573.7408.89.camel@ubuntu> References: <200902081053.00255.david-b@pacbell.net> <1235686596.31223.106.camel@vega.slimlogic.co.uk> <200902261440.04129.david-b@pacbell.net> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200902261440.04129.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: David Brownell Cc: Liam Girdwood , Mark Brown , lkml , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, OMAP List-Id: linux-omap@vger.kernel.org On Thu, 2009-02-26 at 14:40 -0800, David Brownell wrote: > On Thursday 26 February 2009, Liam Girdwood wrote: > > On Sun, 2009-02-08 at 10:52 -0800, David Brownell wrote: > > > From: Kalle Jokiniemi > > > > > > This patch disables LDO regulators VUSB1V5, VUSB1V8, and VUSB3V1 > > > when the USB cable is unplugged, to eliminate that source of power > > > waste. (Enabled LDOs consume power at all times.) > > > > > > Signed-off-by: Kalle Jokiniemi > > > Signed-off-by: David Brownell > > > --- > > > Depends on the twl4030 regulator driver, so I'm suggesting this > > > be merged (with that driver) through the regulator patch queue > > > to simplify things. > > > > > > drivers/usb/otg/twl4030-usb.c | 30 ++++++++++++++++++++++++------ > > > 1 file changed, 24 insertions(+), 6 deletions(-) > > > > Applied. > > Better suggestion: grab Kalle's updated patch from Greg's USB > queue: > > http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/gregkh-04-usb/ > > patch name usb-twl-disable-vusb-regulators-when-cable-unplugged.patch Yep, this previous one lacked some error checks and a build dependency to TWL_REGULATOR. - Kalle > > - Dave -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html