Re: [PATCH 0/3] OMAP3:WDT:Enable IVA, SECURE and minor bugfixes

Kevin Hilman
2009-06-09T18:16:39Z

"Hald, Ulrik Bech" <ubh@ti.com> writes:

>> -----Original Message-----
>> From: Kevin Hilman [mailto:khilman@deeprootsystems.com]
>> Sent: Tuesday, June 09, 2009 9:45 AM
>> To: Hald, Ulrik Bech
>> Cc: linux-omap@vger.kernel.org
>> Subject: Re: [PATCH 0/3] OMAP3:WDT:Enable IVA, SECURE and minor bugfixes
>>
>> Ulrik Bech Hald <ubh@ti.com> writes:
>>
>> > This patch series enables support for IVA and SECURE
>> > WDTs, available on omap34xx.
>> > For omap34xx devices the WDT will be accessible
>> > (when present) through:
>> > SECURE: /dev/watchdog1
>> > MPU: /dev/watchdog2
>> > IVA: /dev/watchdog3
>> >
>> > For devices older than omap34xx only MPU WDT is present
>> > and will be accessible through /dev/watchdog
>>
>> I think you should make the MPU WDT the first one since it will always
>> be present.
>
> The reason, why I numbered them as above, is to make them match the OMAP34xx TRM WDT numbering scheme, where SECURE WDT=WDT1, MPU WDT=WDT2 and IVA WDT=WDT3. My thought was that it would introduce more confusion to change the numbers in /dev/ to something else, although I did consider your point.
> Do you still think I should change the numbers?

Yes. Personally, I don't think the TRM should influence userspace
visible nodes in this case.

I would rather see the watchdog that exists on all platforms be the
first one.

Kevin