Re: [PATCH 0/3] OMAP3:WDT:Enable IVA, SECURE and minor bugfixes

Kevin Hilman
2009-06-09T14:50:42Z

Ulrik Bech Hald <ubh@ti.com> writes:

> This patch series enables support for IVA and SECURE
> WDTs, available on omap34xx.
> For omap34xx devices the WDT will be accessible
> (when present) through:
> SECURE: /dev/watchdog1
> MPU: /dev/watchdog2
> IVA: /dev/watchdog3
>
> For devices older than omap34xx only MPU WDT is present
> and will be accessible through /dev/watchdog

I think you should make the MPU WDT the first one since it will always
be present.

> The series also fixes two bugs:
>
> 1) Correct timeout value is not loaded upon opening the
> watchdog device.
>
> 2) clks are not enabled when accessing registers in probe

Can you fix these existing bugs in a separate patch before you add the
new features.

Kevin