public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] OMAP: OHCI: hc_driver's stop method should call ohci_stop
@ 2009-07-14 11:11 Gadiyar, Anand
       [not found] ` <5A47E75E594F054BAF48C5E4FC4B92AB0305D662CF-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Gadiyar, Anand @ 2009-07-14 11:11 UTC (permalink / raw)
  To: linux-usb@vger.kernel.org
  Cc: dbrownell@users.sourceforge.net, linux-omap@vger.kernel.org

From: Anand Gadiyar <gadiyar@ti.com>

OMAP: OHCI: hc_driver's stop method should call ohci_stop

Without this, the ohci-omap driver will not cleanup the debugfs
nodes when the driver is unloaded. So the next insmod will fail,
if CONFIG_DEBUG_FS and CONFIG_USB_DEBUG are both selected.

Reported-by: vikram pandita <vikram.pandita@ti.com>
Cc: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
---
Not tested. I don't have any hardware that uses this driver.

 drivers/usb/host/ohci-omap.c |    1 +
 1 files changed, 1 insertion(+)

Index: linux-2.6/drivers/usb/host/ohci-omap.c
===================================================================
--- linux-2.6.orig/drivers/usb/host/ohci-omap.c
+++ linux-2.6/drivers/usb/host/ohci-omap.c
@@ -282,6 +282,7 @@ static int ohci_omap_init(struct usb_hcd
 static void ohci_omap_stop(struct usb_hcd *hcd)
 {
 	dev_dbg(hcd->self.controller, "stopping USB Controller\n");
+	ohci_stop(hcd);
 	omap_ohci_clock_power(0);
 }
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* patch usb-omap-ohci-hc_driver-s-stop-method-should-call-ohci_stop.patch added to gregkh-2.6 tree
       [not found] ` <5A47E75E594F054BAF48C5E4FC4B92AB0305D662CF-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
@ 2009-07-15 14:00   ` gregkh-l3A5Bk7waGM
  0 siblings, 0 replies; 2+ messages in thread
From: gregkh-l3A5Bk7waGM @ 2009-07-15 14:00 UTC (permalink / raw)
  To: gadiyar-l0cyMroinI0, dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f,
	gregkh-l3A5Bk7waGM, linux-omap-u79uwXL29TY76Z2rM5mHXA,
	linux-usb-u79uwXL29TY76Z2rM5mHXA, vikram.pandita-l0cyMroinI0


This is a note to let you know that I've just added the patch titled

    Subject: USB: OMAP: OHCI: hc_driver's stop method should call ohci_stop

to my gregkh-2.6 tree.  Its filename is

    usb-omap-ohci-hc_driver-s-stop-method-should-call-ohci_stop.patch

This tree can be found at 
    http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/


>From gadiyar-l0cyMroinI0@public.gmane.org  Wed Jul 15 06:34:11 2009
From: Anand Gadiyar <gadiyar-l0cyMroinI0@public.gmane.org>
Date: Tue, 14 Jul 2009 16:41:00 +0530
Subject: USB: OMAP: OHCI: hc_driver's stop method should call ohci_stop
To: "linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: "dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" <dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>, "linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Message-ID: <5A47E75E594F054BAF48C5E4FC4B92AB0305D662CF-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>


From: Anand Gadiyar <gadiyar-l0cyMroinI0@public.gmane.org>

OMAP: OHCI: hc_driver's stop method should call ohci_stop

Without this, the ohci-omap driver will not cleanup the debugfs
nodes when the driver is unloaded. So the next insmod will fail,
if CONFIG_DEBUG_FS and CONFIG_USB_DEBUG are both selected.

Reported-by: vikram pandita <vikram.pandita-l0cyMroinI0@public.gmane.org>
Cc: David Brownell <dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Signed-off-by: Anand Gadiyar <gadiyar-l0cyMroinI0@public.gmane.org>
Signed-off-by: Greg Kroah-Hartman <gregkh-l3A5Bk7waGM@public.gmane.org>

---
 drivers/usb/host/ohci-omap.c |    1 +
 1 file changed, 1 insertion(+)

--- a/drivers/usb/host/ohci-omap.c
+++ b/drivers/usb/host/ohci-omap.c
@@ -282,6 +282,7 @@ static int ohci_omap_init(struct usb_hcd
 static void ohci_omap_stop(struct usb_hcd *hcd)
 {
 	dev_dbg(hcd->self.controller, "stopping USB Controller\n");
+	ohci_stop(hcd);
 	omap_ohci_clock_power(0);
 }
 

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-07-15 14:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-14 11:11 [PATCH] OMAP: OHCI: hc_driver's stop method should call ohci_stop Gadiyar, Anand
     [not found] ` <5A47E75E594F054BAF48C5E4FC4B92AB0305D662CF-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2009-07-15 14:00   ` patch usb-omap-ohci-hc_driver-s-stop-method-should-call-ohci_stop.patch added to gregkh-2.6 tree gregkh-l3A5Bk7waGM

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox