From: Artem Bityutskiy <dedekind1@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: linux-omap@vger.kernel.org,
Andy Shevchenko <ext-andriy.shevchenko@nokia.com>
Subject: Re: [PATCH 4/4] dspbridge: Change LST_ELEM to list_head entirely
Date: Thu, 03 Sep 2009 12:17:23 +0300 [thread overview]
Message-ID: <1251969443.5060.10.camel@localhost> (raw)
In-Reply-To: <1251968774-25380-5-git-send-email-andy.shevchenko@gmail.com>
On Thu, 2009-09-03 at 12:06 +0300, Andy Shevchenko wrote:
> @@ -590,7 +589,7 @@ DSP_STATUS CMM_GetInfo(struct CMM_OBJECT *hCmmMgr,
> /* next node. */
> pCurNode = (struct CMM_MNODE *)LST_Next(pAltr->
> pInUseListHead,
> - (struct LST_ELEM *)pCurNode);
> + (struct list_head *) pCurNode);
I do not completely agree with this change. Please do not put space
between the cast and the variable. The cast kind of belongs to the
variable, so it is nicer to have no space there.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-09-03 9:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-03 9:06 dspbridge rfc: get rid of services/list.c (try 2) Andy Shevchenko
2009-09-03 9:06 ` [PATCH 1/4] DSPBRIDGE: Get rid of services/list.c (step 1) Andy Shevchenko
2009-09-03 9:06 ` [PATCH 2/4] DSPBRIDGE: Get rid of services/list.c (step 2) Andy Shevchenko
2009-09-03 9:06 ` [PATCH 3/4] dspbridge: use linux memory allocator directly Andy Shevchenko
2009-09-03 9:06 ` [PATCH 4/4] dspbridge: Change LST_ELEM to list_head entirely Andy Shevchenko
2009-09-03 9:17 ` Artem Bityutskiy [this message]
2009-09-03 9:31 ` Andy Shevchenko
2009-09-03 9:36 ` Andy Shevchenko
2009-09-03 10:42 ` [PATCH] " Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2009-09-04 9:18 dspbridge rfc: get rid of services/list.c (rebased) Andy Shevchenko
2009-09-04 9:18 ` [PATCH 1/4] DSPBRIDGE: Get rid of services/list.c Andy Shevchenko
2009-09-04 9:18 ` [PATCH 2/4] " Andy Shevchenko
2009-09-04 9:19 ` [PATCH 3/4] dspbridge: use linux memory allocator directly Andy Shevchenko
2009-09-04 9:19 ` [PATCH 4/4] dspbridge: Change LST_ELEM to list_head entirely Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1251969443.5060.10.camel@localhost \
--to=dedekind1@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=ext-andriy.shevchenko@nokia.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox