Re: [PATCH 1/8] ASoC: TPA6130A2 amplifier driver

[Eero Nurkkala <ext-eero.nurkkala@nokia.com>]

On Thu, 2009-10-08 at 13:58 +0200, Valentin Eduardo (Nokia-D/Helsinki)
wrote:
> +/*
> + * TPA6130 volume. From -59.5 to 4 dB with increasing step size when going
> + * down in gain. Justify scale so that it is quite correct from -20 dB and
> + * up. This setting shows -30 dB at minimum, -12.95 dB at 49 % (actual
> + * is -10.3 dB) and 4.65 dB at maximum (actual is 4 dB).
> + */

The comment is misleading from all it says. For me it seems that the
scale is quite correct from -59.5 to 4 dB or so. Also the minimum is
-59.5 dB, not -30.

> +static const unsigned int tpa6130_tlv[] = {
> +       TLV_DB_RANGE_HEAD(10),
> +       0, 1, TLV_DB_SCALE_ITEM(-5950, 600, 0),
> +       2, 3, TLV_DB_SCALE_ITEM(-5000, 250, 0),
> +       4, 5, TLV_DB_SCALE_ITEM(-4550, 160, 0),
> +       6, 7, TLV_DB_SCALE_ITEM(-4140, 190, 0),
> +       8, 9, TLV_DB_SCALE_ITEM(-3650, 120, 0),
> +       10, 11, TLV_DB_SCALE_ITEM(-3330, 160, 0),
> +       12, 13, TLV_DB_SCALE_ITEM(-3040, 180, 0),
> +       14, 20, TLV_DB_SCALE_ITEM(-2710, 110, 0),
> +       21, 37, TLV_DB_SCALE_ITEM(-1960, 74, 0),
> +       38, 63, TLV_DB_SCALE_ITEM(-720, 45, 0),
> +};
> +