From: Artem Bityutskiy <dedekind1@gmail.com>
To: Vimal Singh <vimal.newwork@gmail.com>
Cc: Linux MTD <linux-mtd@lists.infradead.org>, linux-omap@vger.kernel.org
Subject: Re: [PATCH 2/3]NAND: OMAP: Fixing omap nand driver, compiled as module
Date: Tue, 03 Nov 2009 10:28:17 +0200 [thread overview]
Message-ID: <1257236897.21596.57.camel@localhost> (raw)
In-Reply-To: <ce9ab5790910300227r41d42673webad0ee48e3444d1@mail.gmail.com>
On Fri, 2009-10-30 at 14:57 +0530, Vimal Singh wrote:
> Last time I forgot to 'git add' for 'arch/arm/mach-omap2/gpmc.c'... My bad.
> Correct patch is below.
>
> -vimal
>
>
> From: Vimal Singh <vimalsingh@ti.com>
> Date: Fri, 30 Oct 2009 14:54:29 +0530
> Subject: [PATCH] NAND: OMAP: Fixing omap nand driver, compiled as module
>
> Removing OMAP NAND driver, when loaded as a module, gives error and
> does not get success. This fixes this and makes driver loadable and
> removable run time.
>
> Signed-off-by: Vimal Singh <vimalsingh@ti.com>
> ---
> arch/arm/mach-omap2/gpmc.c | 2 ++
> drivers/mtd/nand/omap2.c | 5 ++++-
> 2 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
> index 1587682..1d10b7b 100644
> --- a/arch/arm/mach-omap2/gpmc.c
> +++ b/arch/arm/mach-omap2/gpmc.c
> @@ -88,6 +88,7 @@ void gpmc_cs_write_reg(int cs, int idx, u32 val)
> reg_addr = gpmc_base + GPMC_CS0 + (cs * GPMC_CS_SIZE) + idx;
> __raw_writel(val, reg_addr);
> }
> +EXPORT_SYMBOL(gpmc_cs_write_reg);
>
> u32 gpmc_cs_read_reg(int cs, int idx)
> {
> @@ -96,6 +97,7 @@ u32 gpmc_cs_read_reg(int cs, int idx)
> reg_addr = gpmc_base + GPMC_CS0 + (cs * GPMC_CS_SIZE) + idx;
> return __raw_readl(reg_addr);
> }
> +EXPORT_SYMBOL(gpmc_cs_read_reg);
Why do you export these?
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-11-03 8:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ce9ab5790910292321y1e7239b7pbffe9a5891d66448@mail.gmail.com>
2009-10-30 8:42 ` [PATCH 2/3]NAND: OMAP: Fixing omap nand driver, compiled as module Vimal Singh
2009-10-30 9:27 ` Vimal Singh
2009-11-03 8:28 ` Artem Bityutskiy [this message]
2009-11-03 8:35 ` Vimal Singh
2009-11-03 8:39 ` Artem Bityutskiy
2009-11-03 8:48 ` Vimal Singh
2009-11-10 14:23 ` Artem Bityutskiy
2009-11-10 18:56 ` Tony Lindgren
2009-11-11 4:46 ` Vimal Singh
2009-11-11 18:43 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257236897.21596.57.camel@localhost \
--to=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=vimal.newwork@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox