Re: [PATCH 2/5] Regulator: Creating regulator hookup file for OMAP3 platforms

[Liam Girdwood <lrg@slimlogic.co.uk>]

On Thu, 2009-11-05 at 22:09 +0530, Anuj Aggarwal wrote:
> This newly created board-omap35x-pmic.c will be used to provide
> the board specific regulator hookup code for various TI PMICs (like
> TWL4030/TPS65950, TPS65023) on different EVMs like OMAP3, AM3517.
> 
> PMIC initialization routine is called from the board-evm file
> which will initialize the configured PMIC appropriately.
> 
> Signed-off-by: Anuj Aggarwal <anuj.aggarwal@ti.com>
> ---
>  arch/arm/mach-omap2/board-omap35x-pmic.c |   71 ++++++++++++++++++++++++++++++
>  arch/arm/mach-omap2/board-omap3evm.c     |    8 +++
>  2 files changed, 79 insertions(+), 0 deletions(-)
>  create mode 100644 arch/arm/mach-omap2/board-omap35x-pmic.c
> 
> diff --git a/arch/arm/mach-omap2/board-omap35x-pmic.c b/arch/arm/mach-omap2/board-omap35x-pmic.c
> new file mode 100644
> index 0000000..aae07ab
> --- /dev/null
> +++ b/arch/arm/mach-omap2/board-omap35x-pmic.c
> @@ -0,0 +1,71 @@
> +/*
> + * board-omap35x-pmic.c
> + *
> + * Board specific information for different regulators and platforms.
> + *
> + * Copyright (C) 2009 Texas Instrument Incorporated - http://www.ti.com/
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation version 2.
> + *
> + * This program is distributed "as is" WITHOUT ANY WARRANTY of any kind,
> + * whether express or implied; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * General Public License for more details.
> + */
> +
> +#include <linux/regulator/driver.h>
> +#include <linux/regulator/machine.h>
> +#include <linux/platform_device.h>
> +#include <plat/common.h>
> +
> +/*
> + * Definitions specific to TWL4030/TPS65950
> + */
> +#if defined(CONFIG_PMIC_TWL4030)
> +static inline void pmic_twl4030_init(void)
> +{
> +	/* TWL4030 specific init code */

Would this not be per board per pmic i.e.

pmic_x_board_y_init() ?

I can see pmic init sometimes being different across boards here (for
the same pmic). Although this probably depends on how complex/flexible
your pmic init needs to be in the first place.

Liam