Re: [PATCH 5/9] DSPBRIDGE: trivial cleanup and indentation for io_sm

Nishanth Menon
2009-11-25T21:53:12Z

Ramirez Luna, Omar had written, on 11/23/2009 06:50 PM, the following:
> Remove duplicate set of braces from if statement and reduce
> indentation.
>
> Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
> ---
> drivers/dsp/bridge/wmd/io_sm.c | 96 +++++++++++++++++-----------------------
> 1 files changed, 40 insertions(+), 56 deletions(-)
>
> diff --git a/drivers/dsp/bridge/wmd/io_sm.c b/drivers/dsp/bridge/wmd/io_sm.c
> index af31831..96a5aa6 100644
> --- a/drivers/dsp/bridge/wmd/io_sm.c
> +++ b/drivers/dsp/bridge/wmd/io_sm.c
[...]
> @@ -1028,29 +1016,28 @@ irqreturn_t IO_ISR(int irq, IN void *pRefData)
>
> /* Call WMD's CHNLSM_ISR() to see if interrupt is ours, and process. */
> if (IO_CALLISR(hIOMgr->hWmdContext, &fSchedDPC, &hIOMgr->wIntrVal)) {
> - {
> - DBG_Trace(DBG_LEVEL3, "IO_ISR %x\n", hIOMgr->wIntrVal);
> - if (hIOMgr->wIntrVal & MBX_PM_CLASS) {
> - hIOMgr->dQuePowerMbxVal[hIOMgr->iQuePowerHead] =
> - hIOMgr->wIntrVal;
> - hIOMgr->iQuePowerHead++;
> - if (hIOMgr->iQuePowerHead >= MAX_PM_REQS)
> - hIOMgr->iQuePowerHead = 0;
> -
> - queue_work(bridge_workqueue, &hIOMgr->io_workq);
> - }
> - if (hIOMgr->wIntrVal == MBX_DEH_RESET) {
> - DBG_Trace(DBG_LEVEL6, "*** DSP RESET ***\n");
> - hIOMgr->wIntrVal = 0;
> - } else if (fSchedDPC) {
> - /* PROC-COPY defer i/o */
> - DPC_Schedule(hIOMgr->hDPC);
> - }
> + DBG_Trace(DBG_LEVEL3, "IO_ISR %x\n", hIOMgr->wIntrVal);
> + if (hIOMgr->wIntrVal & MBX_PM_CLASS) {
> + hIOMgr->dQuePowerMbxVal[hIOMgr->iQuePowerHead] =
> + hIOMgr->wIntrVal;
> + hIOMgr->iQuePowerHead++;
> + if (hIOMgr->iQuePowerHead >= MAX_PM_REQS)
> + hIOMgr->iQuePowerHead = 0;
> +
> + queue_work(bridge_workqueue, &hIOMgr->io_workq);
> + }
> + if (hIOMgr->wIntrVal == MBX_DEH_RESET) {
> + DBG_Trace(DBG_LEVEL6, "*** DSP RESET ***\n");
> + hIOMgr->wIntrVal = 0;
> + } else if (fSchedDPC) {
> + /* PROC-COPY defer i/o */
> + DPC_Schedule(hIOMgr->hDPC);
> }
> - } else
> + } else
> /* Ensure that, if WMD didn't claim it, the IRQ is shared. */
> DBC_Ensure(hIOMgr->fSharedIRQ);

Style comment } else { needed.

--
Regards,
Nishanth Menon