RE: [PATCH 5/9] DSPBRIDGE: trivial cleanup and indentation for io_sm

Ramirez Luna, Omar
2009-11-25T19:47:00Z

>From: Felipe Balbi [mailto:felipe.balbi@nokia.com]
>Subject: Re: [PATCH 5/9] DSPBRIDGE: trivial cleanup and indentation for io_sm
>
>On Tue, Nov 24, 2009 at 01:50:26AM +0100, ext Omar Ramirez Luna wrote:
>>Remove duplicate set of braces from if statement and reduce
>>indentation.
>>
>>Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
>>---
>> drivers/dsp/bridge/wmd/io_sm.c | 96 +++++++++++++++++-----------------------
>> 1 files changed, 40 insertions(+), 56 deletions(-)
>>
>>diff --git a/drivers/dsp/bridge/wmd/io_sm.c b/drivers/dsp/bridge/wmd/io_sm.c
>>index af31831..96a5aa6 100644
>>--- a/drivers/dsp/bridge/wmd/io_sm.c
>>+++ b/drivers/dsp/bridge/wmd/io_sm.c
>>@@ -115,7 +115,7 @@ struct IO_MGR {
>> /* private extnd proc info; mmu setup */
>> struct MGR_PROCESSOREXTINFO extProcInfo;
>> struct CMM_OBJECT *hCmmMgr; /* Shared Mem Mngr */
>>- struct work_struct io_workq; /*workqueue */
>>+ struct work_struct io_workq; /*workqueue */
>
>while at that: /* workqueue */
>
>add the missing space.

Agree.

>
>> u32 dQuePowerMbxVal[MAX_PM_REQS];
>> u32 iQuePowerHead;
>> u32 iQuePowerTail;
>>@@ -185,7 +185,7 @@ DSP_STATUS WMD_IO_Create(OUT struct IO_MGR **phIOMgr,
>> struct CFG_HOSTRES hostRes;
>> struct CFG_DEVNODE *hDevNode;
>> struct CHNL_MGR *hChnlMgr;
>>- static int ref_count;
>>+ static int ref_count;
>> u32 devType;
>> /* Check requirements: */
>> if (!phIOMgr || !pMgrAttrs || pMgrAttrs->uWordSize == 0) {
>>@@ -197,9 +197,10 @@ DSP_STATUS WMD_IO_Create(OUT struct IO_MGR **phIOMgr,
>> status = DSP_EHANDLE;
>> goto func_end;
>> }
>>- /* Message manager will be created when a file is loaded, since
>>+ /* Message manager will be created when a file is loaded, since
>> * size of message buffer in shared memory is configurable in
>>- * the base image. */
>>+ * the base image.
>>+ */
>
>same here... it should be:
>
>/* multi-line comment start here and has only one
> * space after the * character.
> * If you could remove the extra space above would
> * be nice.
> */
>

Agree.

- omar