RE: [PATCH 6/9] DSPBRIDGE: Remove DPC, create, destroy and schedule wrappers

Ramirez Luna, Omar
2009-11-25T19:44:14Z

>From: Felipe Balbi [mailto:felipe.balbi@nokia.com]
>Subject: Re: [PATCH 6/9] DSPBRIDGE: Remove DPC, create, destroy and schedule wrappers
>
>Hi,
>
>On Tue, Nov 24, 2009 at 01:50:27AM +0100, ext Omar Ramirez Luna wrote:
>>+/* The DPC object, passed to our priority event callback routine: */
>>+struct DPC_OBJECT {
>>+ u32 dwSignature; /* Used for object validation. */
>>+ void *pRefData; /* Argument for client's DPC. */
>>+ DPC_PROC pfnDPC; /* Client's DPC. */
>>+ u32 numRequested; /* Number of requested DPC's. */
>>+ u32 numScheduled; /* Number of executed DPC's. */
>>+ struct tasklet_struct dpc_tasklet;
>
>as a suggestion for upcoming patches... how about removing the variable
>types from its name and get rid of CaMeLcAsE ?
>
>I mean:
>
>- u32 dwSignature;
>+ u32 signature;

Done for patch DSPBRIDGE: Remove DPC object structure, I removed the structure because it was used only for IO and MMUfault (in future for WDT too), besides not every field were used anyway.

@@ -128,6 +126,12 @@ struct IO_MGR {
u32 ulGppVa;
u32 ulDspVa;
#endif
+ /* IO Dpc */
+ u32 dpc_req; /* Number of requested DPC's. */
+ u32 dpc_sched; /* Number of executed DPC's. */
+ struct tasklet_struct dpc_tasklet;
+ spinlock_t dpc_lock;
+
} ;

- omar