Re: [PATCH 0/9] dspbridge cleanup patches

Nishanth Menon
2009-11-25T21:56:53Z

Ramirez Luna, Omar had written, on 11/25/2009 03:52 PM, the following:
>> From: Menon, Nishanth
>> Subject: Re: [PATCH 0/9] dspbridge cleanup patches
>>
>>> 1. http://dev.omapzoom.org/?p=tidspbridge/kernel-
>> dspbridge.git;a=commit;h=b6b7bc5b620596790b2ea26225908b3cf62c36be
>>
>> How about the discussion in
>> http://marc.info/?l=linux-omap&m=123728293826758&w=2 ?
>> same arguments seem valid now..
>>
>
> Opps, sorry about that, seems like I stole/redid your patch Felipe, I'll diff it (to see nothing is missing), fix author and add my signed off.
>
> Nishant,
>
> I actually removed the history because one of your comments:
> [snip]
>>> + * GPIO Module disable when not in use - Charulatha V
>>> + <charu@ti.com>
>> Please stop adding history here.. git commit is supposed to contain
>> it. No stats are generated from looking at file history anymore and
>> there is definitely the risk of getting as big as
>> http://dev.omapzoom.org/?p=tidspbridge/kernel-
>> dspbridge.git;a=blob;f=drivers/dsp/bridge/rmgr/mgr.c;h=943cf932a35b75f
>> 709f
>> 554deb3c51c47088d8b78;hb=refs/heads/dspbridge#l26
> [snip]

lets not mix things up. GPIO does not come with the legacy burden of 10
years that DSPBridge has.
http://marc.info/?l=linux-omap&m=123729745613662&w=2 summarizes my views
on DSPBridge.

>
> Personally, If any folk mentioned on the removed history disagrees, it is welcome to send a
> mail to this mailing list detailing his contributions and I guess
someone (me, most likely)
>will check on it. For now a line thanking "vp", "rr", "sp" etc. for
their initial work will be added to the patch.
I doubt if many folks even are there on the linux-omap mailing list..
might be good for us to check OR at least note:
Anonymous contributors (vp,vr etc..).. I think this was previously
discussed in the chain.

>
>>> 3. http://dev.omapzoom.org/?p=tidspbridge/kernel-
>> dspbridge.git;a=commit;h=b4d73d15bd2b1c7dd1cc89ca9e81a98946ddf241
>> printk(KERN_ERR ?? why not use the pr_err/warning/info family?
>>
>
> My git:
> drivers/dsp/bridge/rmgr/dbdcd.c | 165 +++-----
> drivers/dsp/bridge/rmgr/disp.c | 254 ++++-------
> drivers/dsp/bridge/rmgr/drv.c | 399 +++++++----------
> drivers/dsp/bridge/rmgr/drv_interface.c | 92 ++---
> drivers/dsp/bridge/rmgr/dspdrv.c | 34 +-
> drivers/dsp/bridge/rmgr/proc.c | 754 ++++++++++++++-----------------
> drivers/dsp/bridge/rmgr/rmm.c | 46 +--
> drivers/dsp/bridge/rmgr/strm.c | 144 +++----
> 8 files changed, 791 insertions(+), 1097 deletions(-)
>
> (now): Removing GT_Trace wrappers and replacing for pr_debug
Throughout please.. no more printks.. thanks..

--
Regards,
Nishanth Menon