Re: [PATCH v2 01/20] DSPBRIDGE: driver version 0.1

Felipe Contreras
2009-12-05T14:20:17Z

On Wed, Dec 2, 2009 at 6:01 PM, Ramirez Luna, Omar <omar.ramirez@ti.com> wrote:
>>From: Felipe Contreras [mailto:felipe.contreras@gmail.com]
>>It should be the other way around; *after* the modifications have been
>>merged,the version 0.1 would be released.
>
> Nope, version 0.2 will be once modifications are merged and branch is rebased to 2.6.32rc7

There's many problems with the current dspbridge branch, for starters
it doesn't work on the N900, nor beagleboard. Personally I would like
0.1 to work on both, and as discussed in an internal meeting I sent a
proposal for 0.1 with an analysis I did on the current branch.

>> Moreover, it would be nice
>>to get some acknowledgement from Nokia developers that the branch is
>>indeed correct.
>
> It would be nice to get them but they are not needed. As always any bug reports are welcomed.

We care about the code quality and stability, and code-reviewing
ensures that no regressions will sneak in. We reached some level of
stability on the maemo branch, and have done extensive testing on the
N900, it would be only sensible to have at least that same level of
stability on 0.1.

Currently there are many patches in the dspbridge branch that have
never been reviewed by anybody outside TI, nor tested by Nokia, so I
cannot trust that code, specially since it doesn't even work for me.

To me the whole purpose of 0.1 is to have something we can all trust
is "good", so NAK from me.

--
Felipe Contreras