* [PATCH] omap: pandora: board file updates for .33 @ 2009-12-05 18:44 Grazvydas Ignotas 2009-12-05 23:10 ` Felipe Balbi 0 siblings, 1 reply; 3+ messages in thread From: Grazvydas Ignotas @ 2009-12-05 18:44 UTC (permalink / raw) To: linux-omap; +Cc: Tony Lindgren, Grazvydas Ignotas Pandora board file updates: - change keycodes of game buttons it was decided not to use ABXY layout by the developers. - drop i2c bus 3 speed to 100kHz this is needed for battery monitoring chip to work reliably. - drop pandora_lcd platform_device the older DSS driver was never functional on l-o or mainline kernels due to missing panel driver, so remove unneeded pandora_lcd platform_device. This also removes last OMAP_TAG from the board file. LCD support will be added for DSS2 driver. Signed-off-by: Grazvydas Ignotas <notasas@gmail.com> --- I can split this if needed, but I thought single patch might be easier to handle. arch/arm/mach-omap2/board-omap3pandora.c | 21 +++++---------------- 1 files changed, 5 insertions(+), 16 deletions(-) diff --git a/arch/arm/mach-omap2/board-omap3pandora.c b/arch/arm/mach-omap2/board-omap3pandora.c index 2db5ba5..89a541d 100644 --- a/arch/arm/mach-omap2/board-omap3pandora.c +++ b/arch/arm/mach-omap2/board-omap3pandora.c @@ -98,10 +98,10 @@ static struct gpio_keys_button pandora_gpio_keys[] = { GPIO_BUTTON_LOW(103, KEY_DOWN, "down"), GPIO_BUTTON_LOW(96, KEY_LEFT, "left"), GPIO_BUTTON_LOW(98, KEY_RIGHT, "right"), - GPIO_BUTTON_LOW(111, BTN_A, "a"), - GPIO_BUTTON_LOW(106, BTN_B, "b"), - GPIO_BUTTON_LOW(109, BTN_X, "x"), - GPIO_BUTTON_LOW(101, BTN_Y, "y"), + GPIO_BUTTON_LOW(109, KEY_KP1, "game 1"), + GPIO_BUTTON_LOW(111, KEY_KP2, "game 2"), + GPIO_BUTTON_LOW(106, KEY_KP3, "game 3"), + GPIO_BUTTON_LOW(101, KEY_KP4, "game 4"), GPIO_BUTTON_LOW(102, BTN_TL, "l"), GPIO_BUTTON_LOW(97, BTN_TL2, "l2"), GPIO_BUTTON_LOW(105, BTN_TR, "r"), @@ -315,7 +315,7 @@ static int __init omap3pandora_i2c_init(void) omap_register_i2c_bus(1, 2600, omap3pandora_i2c_boardinfo, ARRAY_SIZE(omap3pandora_i2c_boardinfo)); /* i2c2 pins are not connected */ - omap_register_i2c_bus(3, 400, NULL, 0); + omap_register_i2c_bus(3, 100, NULL, 0); return 0; } @@ -368,17 +368,7 @@ static struct spi_board_info omap3pandora_spi_board_info[] __initdata = { } }; -static struct platform_device omap3pandora_lcd_device = { - .name = "pandora_lcd", - .id = -1, -}; - -static struct omap_lcd_config omap3pandora_lcd_config __initdata = { - .ctrl_name = "internal", -}; - static struct omap_board_config_kernel omap3pandora_config[] __initdata = { - { OMAP_TAG_LCD, &omap3pandora_lcd_config }, }; static void __init omap3pandora_init_irq(void) @@ -392,7 +382,6 @@ static void __init omap3pandora_init_irq(void) } static struct platform_device *omap3pandora_devices[] __initdata = { - &omap3pandora_lcd_device, &pandora_leds_gpio, &pandora_keys_gpio, }; -- 1.6.3.3 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] omap: pandora: board file updates for .33 2009-12-05 18:44 [PATCH] omap: pandora: board file updates for .33 Grazvydas Ignotas @ 2009-12-05 23:10 ` Felipe Balbi 2009-12-06 13:12 ` Grazvydas Ignotas 0 siblings, 1 reply; 3+ messages in thread From: Felipe Balbi @ 2009-12-05 23:10 UTC (permalink / raw) To: Grazvydas Ignotas; +Cc: linux-omap, Tony Lindgren Hi, On Sat, 2009-12-05 at 20:44 +0200, Grazvydas Ignotas wrote: > static struct omap_board_config_kernel omap3pandora_config[] __initdata = { > - { OMAP_TAG_LCD, &omap3pandora_lcd_config }, > }; if you don't have any omap_board_config_kernel, couldn't you remove this structure altogether ? -- balbi ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] omap: pandora: board file updates for .33 2009-12-05 23:10 ` Felipe Balbi @ 2009-12-06 13:12 ` Grazvydas Ignotas 0 siblings, 0 replies; 3+ messages in thread From: Grazvydas Ignotas @ 2009-12-06 13:12 UTC (permalink / raw) To: me; +Cc: linux-omap, Tony Lindgren [-- Attachment #1: Type: text/plain, Size: 579 bytes --] On Sun, Dec 6, 2009 at 1:10 AM, Felipe Balbi <me@felipebalbi.com> wrote: > Hi, > > On Sat, 2009-12-05 at 20:44 +0200, Grazvydas Ignotas wrote: >> static struct omap_board_config_kernel omap3pandora_config[] __initdata = { >> - { OMAP_TAG_LCD, &omap3pandora_lcd_config }, >> }; > > if you don't have any omap_board_config_kernel, couldn't you remove this > structure altogether ? All boards (except a few) tend to keep it even if it's empty for some reason, although that doesn't seem to be required. Updated patch attached. > > -- > balbi > > [-- Attachment #2: 0001-omap-pandora-board-file-updates-for-.33.patch --] [-- Type: text/x-diff, Size: 2955 bytes --] From eb33f0fb440fb738b01a076ef1102664ed49b6cd Mon Sep 17 00:00:00 2001 From: Grazvydas Ignotas <notasas@gmail.com> Date: Sat, 5 Dec 2009 20:22:16 +0200 Subject: [PATCH] omap: pandora: board file updates for .33 Pandora board file updates: - change keycodes of game buttons it was decided not to use ABXY layout by the developers. - drop i2c bus 3 speed to 100kHz this is needed for battery monitoring chip to work reliably. - drop pandora_lcd platform_device the older DSS driver was never functional on l-o or mainline kernels due to missing panel driver, so remove unneeded pandora_lcd platform_device. This also removes last OMAP_TAG from the board file. Signed-off-by: Grazvydas Ignotas <notasas@gmail.com> --- arch/arm/mach-omap2/board-omap3pandora.c | 26 +++++--------------------- 1 files changed, 5 insertions(+), 21 deletions(-) diff --git a/arch/arm/mach-omap2/board-omap3pandora.c b/arch/arm/mach-omap2/board-omap3pandora.c index 2db5ba5..f5afa0d 100644 --- a/arch/arm/mach-omap2/board-omap3pandora.c +++ b/arch/arm/mach-omap2/board-omap3pandora.c @@ -98,10 +98,10 @@ static struct gpio_keys_button pandora_gpio_keys[] = { GPIO_BUTTON_LOW(103, KEY_DOWN, "down"), GPIO_BUTTON_LOW(96, KEY_LEFT, "left"), GPIO_BUTTON_LOW(98, KEY_RIGHT, "right"), - GPIO_BUTTON_LOW(111, BTN_A, "a"), - GPIO_BUTTON_LOW(106, BTN_B, "b"), - GPIO_BUTTON_LOW(109, BTN_X, "x"), - GPIO_BUTTON_LOW(101, BTN_Y, "y"), + GPIO_BUTTON_LOW(109, KEY_KP1, "game 1"), + GPIO_BUTTON_LOW(111, KEY_KP2, "game 2"), + GPIO_BUTTON_LOW(106, KEY_KP3, "game 3"), + GPIO_BUTTON_LOW(101, KEY_KP4, "game 4"), GPIO_BUTTON_LOW(102, BTN_TL, "l"), GPIO_BUTTON_LOW(97, BTN_TL2, "l2"), GPIO_BUTTON_LOW(105, BTN_TR, "r"), @@ -315,7 +315,7 @@ static int __init omap3pandora_i2c_init(void) omap_register_i2c_bus(1, 2600, omap3pandora_i2c_boardinfo, ARRAY_SIZE(omap3pandora_i2c_boardinfo)); /* i2c2 pins are not connected */ - omap_register_i2c_bus(3, 400, NULL, 0); + omap_register_i2c_bus(3, 100, NULL, 0); return 0; } @@ -368,23 +368,8 @@ static struct spi_board_info omap3pandora_spi_board_info[] __initdata = { } }; -static struct platform_device omap3pandora_lcd_device = { - .name = "pandora_lcd", - .id = -1, -}; - -static struct omap_lcd_config omap3pandora_lcd_config __initdata = { - .ctrl_name = "internal", -}; - -static struct omap_board_config_kernel omap3pandora_config[] __initdata = { - { OMAP_TAG_LCD, &omap3pandora_lcd_config }, -}; - static void __init omap3pandora_init_irq(void) { - omap_board_config = omap3pandora_config; - omap_board_config_size = ARRAY_SIZE(omap3pandora_config); omap2_init_common_hw(mt46h32m32lf6_sdrc_params, mt46h32m32lf6_sdrc_params); omap_init_irq(); @@ -392,7 +377,6 @@ static void __init omap3pandora_init_irq(void) } static struct platform_device *omap3pandora_devices[] __initdata = { - &omap3pandora_lcd_device, &pandora_leds_gpio, &pandora_keys_gpio, }; -- 1.6.3.3 ^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-12-06 13:12 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2009-12-05 18:44 [PATCH] omap: pandora: board file updates for .33 Grazvydas Ignotas 2009-12-05 23:10 ` Felipe Balbi 2009-12-06 13:12 ` Grazvydas Ignotas
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox