From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Olof Johansson <olof@lixom.net>
Cc: alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com,
Arun KS <arunks@mistralsolutions.com>,
Anuj Aggarwal <anuj.aggarwal@ti.com>,
linux-omap@vger.kernel.org, Anand Gadiyar <gadiyar@ti.com>
Subject: Re: [PATCH] Fix build of OMAP sound drivers
Date: Thu, 10 Dec 2009 17:25:50 +0000 [thread overview]
Message-ID: <1260465950.3625.213.camel@odin> (raw)
In-Reply-To: <20091210171555.GB19668@lixom.net>
On Thu, 2009-12-10 at 11:15 -0600, Olof Johansson wrote:
> There are build errors when building for some of the omap2/3 boards without
> enabling sound:
>
> sound/built-in.o:(.data+0x43bc): undefined reference to `soc_codec_dev_tlv320aic23'
> sound/built-in.o:(.data+0x43cc): undefined reference to `tlv320aic23_dai'
>
> Confused me quite a bit since the drivers that had references to the
> codec weren't enabled. Turns out the Makefile was using the wrong
> config option to enable them. Patch below.
>
>
>
> Reported-by: Anand Gadiyar <gadiyar@ti.com>
> Signed-off-by: Olof Johansson <olof@lixom.net>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
>
> diff --git a/sound/soc/omap/Makefile b/sound/soc/omap/Makefile
> index d49458a..3db8a6c 100644
> --- a/sound/soc/omap/Makefile
> +++ b/sound/soc/omap/Makefile
> @@ -23,9 +23,9 @@ obj-$(CONFIG_SND_OMAP_SOC_N810) += snd-soc-n810.o
> obj-$(CONFIG_SND_OMAP_SOC_AMS_DELTA) += snd-soc-ams-delta.o
> obj-$(CONFIG_SND_OMAP_SOC_OSK5912) += snd-soc-osk5912.o
> obj-$(CONFIG_SND_OMAP_SOC_OVERO) += snd-soc-overo.o
> -obj-$(CONFIG_MACH_OMAP2EVM) += snd-soc-omap2evm.o
> -obj-$(CONFIG_MACH_OMAP3EVM) += snd-soc-omap3evm.o
> -obj-$(CONFIG_MACH_OMAP3517EVM) += snd-soc-am3517evm.o
> +obj-$(CONFIG_SND_OMAP_SOC_OMAP2EVM) += snd-soc-omap2evm.o
> +obj-$(CONFIG_SND_OMAP_SOC_OMAP3EVM) += snd-soc-omap3evm.o
> +obj-$(CONFIG_SND_OMAP_SOC_OMAP3517EVM) += snd-soc-am3517evm.o
> obj-$(CONFIG_SND_OMAP_SOC_SDP3430) += snd-soc-sdp3430.o
> obj-$(CONFIG_SND_OMAP_SOC_OMAP3_PANDORA) += snd-soc-omap3pandora.o
> obj-$(CONFIG_SND_OMAP_SOC_OMAP3_BEAGLE) += snd-soc-omap3beagle.o
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2009-12-10 17:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-10 17:15 [PATCH] Fix build of OMAP sound drivers Olof Johansson
2009-12-10 17:25 ` Liam Girdwood [this message]
2009-12-10 19:37 ` Mark Brown
2009-12-10 23:42 ` [APPLIED] " Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1260465950.3625.213.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=anuj.aggarwal@ti.com \
--cc=arunks@mistralsolutions.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gadiyar@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox