From mboxrd@z Thu Jan 1 00:00:00 1970 From: Omar Ramirez Luna Subject: [PATCHv2 15/18] DSPBRIDGE: check the status of DMM_GetHandle Date: Wed, 16 Dec 2009 20:16:00 -0600 Message-ID: <1261016163-11091-16-git-send-email-omar.ramirez@ti.com> References: <1261016163-11091-1-git-send-email-omar.ramirez@ti.com> <1261016163-11091-2-git-send-email-omar.ramirez@ti.com> <1261016163-11091-3-git-send-email-omar.ramirez@ti.com> <1261016163-11091-4-git-send-email-omar.ramirez@ti.com> <1261016163-11091-5-git-send-email-omar.ramirez@ti.com> <1261016163-11091-6-git-send-email-omar.ramirez@ti.com> <1261016163-11091-7-git-send-email-omar.ramirez@ti.com> <1261016163-11091-8-git-send-email-omar.ramirez@ti.com> <1261016163-11091-9-git-send-email-omar.ramirez@ti.com> <1261016163-11091-10-git-send-email-omar.ramirez@ti.com> <1261016163-11091-11-git-send-email-omar.ramirez@ti.com> <1261016163-11091-12-git-send-email-omar.ramirez@ti.com> <1261016163-11091-13-git-send-email-omar.ramirez@ti.com> <1261016163-11091-14-git-send-email-omar.ramirez@ti.com> <1261016163-11091-15-git-send-email-omar.ramirez@ti.com> Return-path: Received: from comal.ext.ti.com ([198.47.26.152]:41328 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763906AbZLQCIt (ORCPT ); Wed, 16 Dec 2009 21:08:49 -0500 In-Reply-To: <1261016163-11091-15-git-send-email-omar.ramirez@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: linux-omap Cc: Hiroshi Doyu , Ameya Palande , Felipe Contreras , Fernando Guzman , Ernesto Ramos , Omar Ramirez Luna Check the status of DMM_GetHandle Signed-off-by: Omar Ramirez Luna --- drivers/dsp/bridge/rmgr/proc.c | 17 ++++++++++------- 1 files changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/dsp/bridge/rmgr/proc.c b/drivers/dsp/bridge/rmgr/proc.c index 3c23d85..1ab6181 100644 --- a/drivers/dsp/bridge/rmgr/proc.c +++ b/drivers/dsp/bridge/rmgr/proc.c @@ -1833,16 +1833,19 @@ DSP_STATUS PROC_UnMap(DSP_HPROCESSOR hProcessor, void *pMapAddr) } status = DMM_GetHandle(hProcessor, &hDmmMgr); - /* Critical section */ - (void)SYNC_EnterCS(hProcLock); if (DSP_FAILED(status)) { GT_1trace(PROC_DebugMask, GT_7CLASS, "PROC_UnMap: " - "Failed to get DMM Mgr handle: 0x%x\n", status); - } else { - /* Update DMM structures. Get the size to unmap. - This function returns error if the VA is not mapped */ - status = DMM_UnMapMemory(hDmmMgr, (u32) vaAlign, &sizeAlign); + "Failed to get DMM Mgr handle: 0x%x\n", status); + goto func_end; } + + /* Critical section */ + (void)SYNC_EnterCS(hProcLock); + /* + * Update DMM structures. Get the size to unmap. + * This function returns error if the VA is not mapped + */ + status = DMM_UnMapMemory(hDmmMgr, (u32) vaAlign, &sizeAlign); /* Remove mapping from the page tables. */ if (DSP_SUCCEEDED(status)) { status = (*pProcObject->pIntfFxns->pfnBrdMemUnMap) -- 1.6.2.4