From: Nishanth Menon <nm@ti.com>
To: kevin h <khilman@deeprootsystems.com>
Cc: linux omap <linux-omap@vger.kernel.org>,
Romit Dasgupta <romit@ti.com>, Ambresh k <ambresh@ti.com>,
Nishanth Menon <nm@ti.com>
Subject: [PATCH 2/2 v2] omap3:pm: remove omap3_[mpu|dsp|l3]_rate_tables
Date: Sat, 19 Dec 2009 19:02:59 +0530 [thread overview]
Message-ID: <1261229579-8553-1-git-send-email-nm@ti.com> (raw)
since _rate_tables are initializing mpu_opps, dsp_opps and l3_opps
it makes no sense in having these initialize just once. optimize
these out
Signed-off-by: Nishanth Menon <nm@ti.com>
---
v2: cleaned up omap3-opp.h -> leaving this file still here in case
we will need to add omap3 specific exported stuff here. Apologies
on the spam.. realized this a bit late..
v1: original cleanup of pm34xx.c
arch/arm/mach-omap2/omap3-opp.h | 4 ----
arch/arm/mach-omap2/pm34xx.c | 15 +++------------
2 files changed, 3 insertions(+), 16 deletions(-)
diff --git a/arch/arm/mach-omap2/omap3-opp.h b/arch/arm/mach-omap2/omap3-opp.h
index 994d8d4..b47bb44 100644
--- a/arch/arm/mach-omap2/omap3-opp.h
+++ b/arch/arm/mach-omap2/omap3-opp.h
@@ -3,8 +3,4 @@
#include <plat/omap-pm.h>
-extern struct omap_opp *omap3_mpu_rate_table;
-extern struct omap_opp *omap3_dsp_rate_table;
-extern struct omap_opp *omap3_l3_rate_table;
-
#endif
diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
index d7646ba..9744a35 100644
--- a/arch/arm/mach-omap2/pm34xx.c
+++ b/arch/arm/mach-omap2/pm34xx.c
@@ -189,11 +189,6 @@ static struct omap_opp_def __initdata omap36xx_dsp_rate_table[] = {
OMAP_OPP_DEF(0, 0, 0)
};
-/* OMAP3 Rate Table */
-struct omap_opp *omap3_mpu_rate_table;
-struct omap_opp *omap3_dsp_rate_table;
-struct omap_opp *omap3_l3_rate_table;
-
static inline void omap3_per_save_context(void)
{
omap_gpio_save_context();
@@ -1365,9 +1360,9 @@ void __init omap3_pm_init_opp_table(void)
omap36xx_dsp_rate_table
};
struct omap_opp **omap3_rate_tables[] = {
- &omap3_mpu_rate_table,
- &omap3_l3_rate_table,
- &omap3_dsp_rate_table
+ &mpu_opps,
+ &dsp_opps,
+ &l3_opps
};
omap3_opp_def_list = cpu_is_omap3630() ? omap36xx_opp_def_list :
@@ -1377,10 +1372,6 @@ void __init omap3_pm_init_opp_table(void)
/* We dont want half configured system at the moment */
BUG_ON(IS_ERR(omap3_rate_tables[i]));
}
-
- mpu_opps = omap3_mpu_rate_table;
- dsp_opps = omap3_dsp_rate_table;
- l3_opps = omap3_l3_rate_table;
}
static int __init omap3_pm_early_init(void)
--
1.6.3.3
next reply other threads:[~2009-12-19 13:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-19 13:32 Nishanth Menon [this message]
2009-12-22 17:05 ` [PATCH 2/2 v2] omap3:pm: remove omap3_[mpu|dsp|l3]_rate_tables Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1261229579-8553-1-git-send-email-nm@ti.com \
--to=nm@ti.com \
--cc=ambresh@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=romit@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox