From: Omar Ramirez Luna <omar.ramirez@ti.com>
To: linux-omap <linux-omap@vger.kernel.org>
Cc: Hiroshi Doyu <Hiroshi.DOYU@nokia.com>,
Ameya Palande <ameya.palande@nokia.com>,
Felipe Contreras <felipe.contreras@nokia.com>,
Fernando Guzman <x0095840@ti.com>, Ernesto Ramos <ernesto@ti.com>,
Omar Ramirez Luna <omar.ramirez@ti.com>
Subject: [PATCH 4/8] DSPBRIDGE: Remove unused hDrvObject in bridge_[open|release]
Date: Thu, 7 Jan 2010 19:00:40 -0600 [thread overview]
Message-ID: <1262912440-30050-1-git-send-email-omar.ramirez@ti.com> (raw)
This patch removes an unused variable in bridge_open
and bridge_release functions, which reduces indentation.
Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
---
drivers/dsp/bridge/rmgr/drv_interface.c | 25 +++++--------------------
1 files changed, 5 insertions(+), 20 deletions(-)
diff --git a/drivers/dsp/bridge/rmgr/drv_interface.c b/drivers/dsp/bridge/rmgr/drv_interface.c
index 3a4d058..e551840 100644
--- a/drivers/dsp/bridge/rmgr/drv_interface.c
+++ b/drivers/dsp/bridge/rmgr/drv_interface.c
@@ -540,18 +540,10 @@ static void __exit bridge_exit(void)
static int bridge_open(struct inode *ip, struct file *filp)
{
int status = 0;
- DSP_STATUS dsp_status;
- HANDLE hDrvObject;
struct PROCESS_CONTEXT *pr_ctxt = NULL;
GT_0trace(driverTrace, GT_ENTER, "-> bridge_open\n");
- dsp_status = CFG_GetObject((u32 *)&hDrvObject, REG_DRV_OBJECT);
- if (DSP_FAILED(dsp_status)) {
- status = -EIO;
- goto err;
- }
-
/*
* Allocate a new process context and insert it into global
* process context list.
@@ -564,7 +556,6 @@ static int bridge_open(struct inode *ip, struct file *filp)
filp->private_data = pr_ctxt;
-err:
GT_0trace(driverTrace, GT_ENTER, "<- bridge_open\n");
return status;
}
@@ -576,8 +567,6 @@ err:
static int bridge_release(struct inode *ip, struct file *filp)
{
int status = 0;
- DSP_STATUS dsp_status;
- HANDLE hDrvObject;
struct PROCESS_CONTEXT *pr_ctxt;
GT_0trace(driverTrace, GT_ENTER, "-> bridge_release\n");
@@ -588,15 +577,11 @@ static int bridge_release(struct inode *ip, struct file *filp)
}
pr_ctxt = filp->private_data;
- dsp_status = CFG_GetObject((u32 *)&hDrvObject, REG_DRV_OBJECT);
- if (DSP_SUCCEEDED(dsp_status)) {
- flush_signals(current);
- DRV_RemoveAllResources(pr_ctxt);
- PROC_Detach(pr_ctxt);
- MEM_Free(pr_ctxt);
- } else {
- status = -EIO;
- }
+ flush_signals(current);
+ DRV_RemoveAllResources(pr_ctxt);
+ PROC_Detach(pr_ctxt);
+ MEM_Free(pr_ctxt);
+
filp->private_data = NULL;
err:
--
1.6.2.4
next reply other threads:[~2010-01-08 0:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-08 1:00 Omar Ramirez Luna [this message]
2010-01-08 2:19 ` [PATCH 4/8] DSPBRIDGE: Remove unused hDrvObject in bridge_[open|release] Nishanth Menon
2010-01-08 21:29 ` Ramirez Luna, Omar
2010-01-08 21:37 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1262912440-30050-1-git-send-email-omar.ramirez@ti.com \
--to=omar.ramirez@ti.com \
--cc=Hiroshi.DOYU@nokia.com \
--cc=ameya.palande@nokia.com \
--cc=ernesto@ti.com \
--cc=felipe.contreras@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=x0095840@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox