From: Omar Ramirez Luna <omar.ramirez@ti.com>
To: linux-omap <linux-omap@vger.kernel.org>
Cc: Ernesto Ramos <ernesto@ti.com>, Nishanth Menon <nm@ti.com>,
Hiroshi Doyu <Hiroshi.DOYU@nokia.com>,
Ameya Palande <ameya.palande@nokia.com>
Subject: [PATCH 2/3] DSPBRIDGE: Undo allocation of resources in case of cp_to_usr fails
Date: Wed, 13 Jan 2010 19:11:15 -0600 [thread overview]
Message-ID: <1263431476-19206-3-git-send-email-omar.ramirez@ti.com> (raw)
In-Reply-To: <1263431476-19206-2-git-send-email-omar.ramirez@ti.com>
From: Ernesto Ramos <ernesto@ti.com>
Release resources allocated during MAP, Node Allocation,
STRM Buf Allocation in the case of cp_to_usr fails.
Signed-off-by: Ernesto Ramos <ernesto@ti.com>
CC: Nishanth Menon <nm@ti.com>
CC: Hiroshi Doyu <Hiroshi.DOYU@nokia.com>
CC: Ameya Palande <ameya.palande@nokia.com>
---
drivers/dsp/bridge/pmgr/wcd.c | 35 ++++++++++++++++++++++++++++-------
1 files changed, 28 insertions(+), 7 deletions(-)
diff --git a/drivers/dsp/bridge/pmgr/wcd.c b/drivers/dsp/bridge/pmgr/wcd.c
index 006ca63..5062053 100644
--- a/drivers/dsp/bridge/pmgr/wcd.c
+++ b/drivers/dsp/bridge/pmgr/wcd.c
@@ -1104,8 +1104,11 @@ u32 PROCWRAP_Map(union Trapped_Args *args, void *pr_ctxt)
args->ARGS_PROC_MAPMEM.pReqAddr, &pMapAddr,
args->ARGS_PROC_MAPMEM.ulMapAttr, pr_ctxt);
if (DSP_SUCCEEDED(status)) {
- if (put_user(pMapAddr, args->ARGS_PROC_MAPMEM.ppMapAddr))
+ if (put_user(pMapAddr, args->ARGS_PROC_MAPMEM.ppMapAddr)) {
status = DSP_EINVALIDARG;
+ PROC_UnMap(args->ARGS_PROC_MAPMEM.hProcessor,
+ pMapAddr, pr_ctxt);
+ }
}
return status;
@@ -1150,9 +1153,13 @@ u32 PROCWRAP_ReserveMemory(union Trapped_Args *args, void *pr_ctxt)
GT_0trace(WCD_debugMask, GT_ENTER, "PROCWRAP_ReserveMemory: entered\n");
status = PROC_ReserveMemory(args->ARGS_PROC_RSVMEM.hProcessor,
args->ARGS_PROC_RSVMEM.ulSize, &pRsvAddr);
- if (put_user(pRsvAddr, args->ARGS_PROC_RSVMEM.ppRsvAddr))
- status = DSP_EINVALIDARG;
-
+ if (DSP_SUCCEEDED(status)) {
+ if (put_user(pRsvAddr, args->ARGS_PROC_RSVMEM.ppRsvAddr)) {
+ status = DSP_EINVALIDARG;
+ PROC_UnReserveMemory(args->ARGS_PROC_RSVMEM.hProcessor,
+ pRsvAddr);
+ }
+ }
return status;
}
@@ -1255,7 +1262,13 @@ u32 NODEWRAP_Allocate(union Trapped_Args *args, void *pr_ctxt)
&nodeId, (struct DSP_CBDATA *)pArgs,
pAttrIn, &hNode, pr_ctxt);
}
- cp_to_usr(args->ARGS_NODE_ALLOCATE.phNode, &hNode, status, 1);
+ if (DSP_SUCCEEDED(status)) {
+ cp_to_usr(args->ARGS_NODE_ALLOCATE.phNode, &hNode, status, 1);
+ if (DSP_FAILED(status)) {
+ status = DSP_EPOINTER;
+ NODE_Delete(hNode, pr_ctxt);
+ }
+ }
func_cont:
if (pArgs)
MEM_Free(pArgs);
@@ -1589,8 +1602,16 @@ u32 STRMWRAP_AllocateBuffer(union Trapped_Args *args, void *pr_ctxt)
status = STRM_AllocateBuffer(args->ARGS_STRM_ALLOCATEBUFFER.hStream,
args->ARGS_STRM_ALLOCATEBUFFER.uSize,
apBuffer, uNumBufs, pr_ctxt);
- cp_to_usr(args->ARGS_STRM_ALLOCATEBUFFER.apBuffer, apBuffer, status,
- uNumBufs);
+ if (DSP_SUCCEEDED(status)) {
+ cp_to_usr(args->ARGS_STRM_ALLOCATEBUFFER.apBuffer, apBuffer,
+ status, uNumBufs);
+ if (DSP_FAILED(status)) {
+ status = DSP_EPOINTER;
+ STRM_FreeBuffer(
+ args->ARGS_STRM_ALLOCATEBUFFER.hStream,
+ apBuffer, uNumBufs, pr_ctxt);
+ }
+ }
if (apBuffer)
MEM_Free(apBuffer);
--
1.6.2.4
next prev parent reply other threads:[~2010-01-14 1:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-14 1:11 [PATCH 0/3] Interface tightening patches Omar Ramirez Luna
2010-01-14 1:11 ` [PATCH 1/3] DSPBRIDGE: Interface tightening to check for invalid input parameters Omar Ramirez Luna
2010-01-14 1:11 ` Omar Ramirez Luna [this message]
2010-01-14 1:11 ` [PATCH 3/3] DSPBRIDGE: NULL Pointer Dereference fix Omar Ramirez Luna
2010-01-18 18:31 ` Ramirez Luna, Omar
2010-01-18 18:30 ` [PATCH 2/3] DSPBRIDGE: Undo allocation of resources in case of cp_to_usr fails Ramirez Luna, Omar
2010-01-18 18:30 ` [PATCH 1/3] DSPBRIDGE: Interface tightening to check for invalid input parameters Ramirez Luna, Omar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263431476-19206-3-git-send-email-omar.ramirez@ti.com \
--to=omar.ramirez@ti.com \
--cc=Hiroshi.DOYU@nokia.com \
--cc=ameya.palande@nokia.com \
--cc=ernesto@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox