[PATCHv2 0/4] Regulator: OMAP: Removing common code for TWL4030 from OMAP3- board-evms

[PATCHv2 0/4] Regulator: OMAP: Removing common code for TWL4030 from OMAP3- board-evms

[Anuj Aggarwal]

Sending version 2 of this patch set after taking all those comments. First
series can be found at:
  http://marc.info/?l=linux-omap&m=126297346131188&w=2

This patch set is created to clean up various OMAP3-board-evm files
and remove common TWL4030 specific regulator suplies and init data
structs. These structures are instead placed in a new generic file -
twl4030-pmic.c - and are referenced from the OMAP3 board-evm
files depending on the platform requirements. Regulator having specific
supplies or init data structs are not changed in their respective
board-evms.

The main advantages of having one common file for these structures
are redundant code removal, easy maintainability and single copy of 
common structure(s) in case uImage for multiple platforms is built.

Anuj Aggarwal (4):
  Regulator: OMAP: Creating TWL4030 file having supplies & init data
  Regulator: OMAP:Modifying Kconfig/Makefile to choose from available
    PMICs
  Regulator: OMAP: Kconfig modified to select TWL4030 for
    OMAP3-platforms
  Regulator: OMAP: Use common regulator supplies and init data structs

 arch/arm/mach-omap2/Kconfig                  |   20 +++
 arch/arm/mach-omap2/Makefile                 |    1 +
 arch/arm/mach-omap2/board-3430sdp.c          |  135 ++------------------
 arch/arm/mach-omap2/board-cm-t35.c           |   47 +------
 arch/arm/mach-omap2/board-igep0020.c         |   24 +---
 arch/arm/mach-omap2/board-ldp.c              |   24 +---
 arch/arm/mach-omap2/board-omap3beagle.c      |   47 +------
 arch/arm/mach-omap2/board-omap3evm.c         |   47 +------
 arch/arm/mach-omap2/board-omap3touchbook.c   |   47 +------
 arch/arm/mach-omap2/board-overo.c            |   23 +---
 arch/arm/mach-omap2/board-zoom-peripherals.c |   71 +----------
 arch/arm/mach-omap2/twl4030-pmic.c           |  175 ++++++++++++++++++++++++++
 arch/arm/mach-omap2/twl4030-pmic.h           |   34 +++++
 13 files changed, 277 insertions(+), 418 deletions(-)
 mode change 100755 => 100644 arch/arm/mach-omap2/board-zoom-peripherals.c
 create mode 100644 arch/arm/mach-omap2/twl4030-pmic.c
 create mode 100644 arch/arm/mach-omap2/twl4030-pmic.h

RE: [PATCHv2 0/4] Regulator: OMAP: Removing common code for TWL4030 from OMAP3- board-evms

[Aggarwal, Anuj]

Any comments on this version?

Regards,
Anuj Aggarwal

> -----Original Message-----
> From: Aggarwal, Anuj
> Sent: Tuesday, January 12, 2010 2:44 PM
> To: linux-omap@vger.kernel.org
> Cc: broonie@opensource.wolfsonmicro.com; lrg@slimlogic.co.uk; Aggarwal,
> Anuj
> Subject: [PATCHv2 0/4] Regulator: OMAP: Removing common code for TWL4030
> from OMAP3- board-evms
> 
> Sending version 2 of this patch set after taking all those comments. First
> series can be found at:
>   http://marc.info/?l=linux-omap&m=126297346131188&w=2
> 
> This patch set is created to clean up various OMAP3-board-evm files
> and remove common TWL4030 specific regulator suplies and init data
> structs. These structures are instead placed in a new generic file -
> twl4030-pmic.c - and are referenced from the OMAP3 board-evm
> files depending on the platform requirements. Regulator having specific
> supplies or init data structs are not changed in their respective
> board-evms.
> 
> The main advantages of having one common file for these structures
> are redundant code removal, easy maintainability and single copy of
> common structure(s) in case uImage for multiple platforms is built.
> 
> Anuj Aggarwal (4):
>   Regulator: OMAP: Creating TWL4030 file having supplies & init data
>   Regulator: OMAP:Modifying Kconfig/Makefile to choose from available
>     PMICs
>   Regulator: OMAP: Kconfig modified to select TWL4030 for
>     OMAP3-platforms
>   Regulator: OMAP: Use common regulator supplies and init data structs
> 
>  arch/arm/mach-omap2/Kconfig                  |   20 +++
>  arch/arm/mach-omap2/Makefile                 |    1 +
>  arch/arm/mach-omap2/board-3430sdp.c          |  135 ++------------------
>  arch/arm/mach-omap2/board-cm-t35.c           |   47 +------
>  arch/arm/mach-omap2/board-igep0020.c         |   24 +---
>  arch/arm/mach-omap2/board-ldp.c              |   24 +---
>  arch/arm/mach-omap2/board-omap3beagle.c      |   47 +------
>  arch/arm/mach-omap2/board-omap3evm.c         |   47 +------
>  arch/arm/mach-omap2/board-omap3touchbook.c   |   47 +------
>  arch/arm/mach-omap2/board-overo.c            |   23 +---
>  arch/arm/mach-omap2/board-zoom-peripherals.c |   71 +----------
>  arch/arm/mach-omap2/twl4030-pmic.c           |  175
> ++++++++++++++++++++++++++
>  arch/arm/mach-omap2/twl4030-pmic.h           |   34 +++++
>  13 files changed, 277 insertions(+), 418 deletions(-)
>  mode change 100755 => 100644 arch/arm/mach-omap2/board-zoom-peripherals.c
>  create mode 100644 arch/arm/mach-omap2/twl4030-pmic.c
>  create mode 100644 arch/arm/mach-omap2/twl4030-pmic.h

RE: [PATCHv2 0/4] Regulator: OMAP: Removing common code for TWL4030 from OMAP3- board-evms

[Liam Girdwood]

On Wed, 2010-01-13 at 22:25 +0530, Aggarwal, Anuj wrote:
> Any comments on this version?

Just had a quick scan, looks fine.

Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>

Re: [PATCHv2 0/4] Regulator: OMAP: Removing common code for TWL4030 from OMAP3- board-evms

[Mark Brown]

On Tue, Jan 12, 2010 at 02:43:45PM +0530, Anuj Aggarwal wrote:

> Anuj Aggarwal (4):
>   Regulator: OMAP: Creating TWL4030 file having supplies & init data

I'd expect to see the header file here have ifdef guards and also
include the headers it depends on (linux/regulator/machine.h at least)
but both of those could be fixed up later.  Otherwise it all looks OK
from a regulator point of view

Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

RE: [PATCHv2 0/4] Regulator: OMAP: Removing common code for TWL4030 from OMAP3- board-evms

[Aggarwal, Anuj]

> -----Original Message-----
> From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com]
> Sent: Friday, January 15, 2010 4:43 PM
> To: Aggarwal, Anuj
> Cc: linux-omap@vger.kernel.org; lrg@slimlogic.co.uk
> Subject: Re: [PATCHv2 0/4] Regulator: OMAP: Removing common code for
> TWL4030 from OMAP3- board-evms
> 
> On Tue, Jan 12, 2010 at 02:43:45PM +0530, Anuj Aggarwal wrote:
> 
> > Anuj Aggarwal (4):
> >   Regulator: OMAP: Creating TWL4030 file having supplies & init data
> 
> I'd expect to see the header file here have ifdef guards and also
> include the headers it depends on (linux/regulator/machine.h at least)
> but both of those could be fixed up later.  Otherwise it all looks OK
> from a regulator point of view
> 
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Tony,

Have you pulled these patches? I need to send another patch set
for other PMICs which would be based on the first set. Are you expecting
some change in the original set? Please let me know if that is the case.