From: Omar Ramirez Luna <omar.ramirez@ti.com>
To: linux-omap <linux-omap@vger.kernel.org>
Cc: Ameya Palande <ameya.palande@nokia.com>,
Hiroshi Doyu <Hiroshi.DOYU@nokia.com>,
Felipe Contreras <felipe.contreras@nokia.com>,
Nishanth Menon <nm@ti.com>,
Omar Ramirez Luna <omar.ramirez@ti.com>
Subject: [PATCH 09/10] DSPBRIDGE: checkpatch - printk() should include KERN_ facility level
Date: Fri, 15 Jan 2010 15:28:40 -0600 [thread overview]
Message-ID: <1263590921-24357-10-git-send-email-omar.ramirez@ti.com> (raw)
In-Reply-To: <1263590921-24357-9-git-send-email-omar.ramirez@ti.com>
WARNING: printk() should include KERN_ facility level
Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
---
arch/arm/plat-omap/include/dspbridge/dbc.h | 2 +-
arch/arm/plat-omap/include/dspbridge/gt.h | 2 +-
drivers/dsp/bridge/gen/_gt_para.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/plat-omap/include/dspbridge/dbc.h b/arch/arm/plat-omap/include/dspbridge/dbc.h
index e9cb548..ac5d178 100644
--- a/arch/arm/plat-omap/include/dspbridge/dbc.h
+++ b/arch/arm/plat-omap/include/dspbridge/dbc.h
@@ -36,7 +36,7 @@
#define DBC_Assert(exp) \
if (!(exp)) \
- printk("%s, line %d: Assertion (" #exp ") failed.\n", \
+ pr_err("%s, line %d: Assertion (" #exp ") failed.\n", \
__FILE__, __LINE__)
#define DBC_Require DBC_Assert /* Function Precondition. */
#define DBC_Ensure DBC_Assert /* Function Postcondition. */
diff --git a/arch/arm/plat-omap/include/dspbridge/gt.h b/arch/arm/plat-omap/include/dspbridge/gt.h
index b43b1e7..6082d15 100644
--- a/arch/arm/plat-omap/include/dspbridge/gt.h
+++ b/arch/arm/plat-omap/include/dspbridge/gt.h
@@ -232,7 +232,7 @@ extern struct GT_Config _GT_params;
#define GT_assert(mask, expr) \
(!(expr) ? \
- printk("assertion violation: %s, line %d\n", \
+ pr_err("assertion violation: %s, line %d\n", \
__FILE__, __LINE__), NULL : NULL)
#define GT_config(config) (_GT_params = *(config))
diff --git a/drivers/dsp/bridge/gen/_gt_para.c b/drivers/dsp/bridge/gen/_gt_para.c
index 9f8246b..f676d3f 100644
--- a/drivers/dsp/bridge/gen/_gt_para.c
+++ b/drivers/dsp/bridge/gen/_gt_para.c
@@ -77,7 +77,7 @@ static void error(char *fmt, ...)
va_end(va);
- printk("ERROR: ");
+ pr_err("ERROR: ");
printk(fmt, arg1, arg2, arg3, arg4, arg5, arg6);
#if defined(DEBUG) || defined(DDSP_DEBUG_PRODUCT)
--
1.6.2.4
next prev parent reply other threads:[~2010-01-15 21:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-15 21:28 [PATCH 00/10] trivial cleanups Omar Ramirez Luna
2010-01-15 21:28 ` [PATCH 01/10] DSPBRIDGE: trivial license fix in tramp and tramp_table_c6000 Omar Ramirez Luna
2010-01-15 21:28 ` [PATCH 02/10] DSPBRIDGE: contributors file Omar Ramirez Luna
[not found] ` <1263590921-24357-4-git-send-email-omar.ramirez@ti.com>
[not found] ` <1263590921-24357-5-git-send-email-omar.ramirez@ti.com>
2010-01-15 21:28 ` [PATCH 05/10] DSPBRIDGE: checkpatch - space required after comma Omar Ramirez Luna
2010-01-15 21:28 ` [PATCH 06/10] DSPBRIDGE: checkpatch - space required before open parenthesis Omar Ramirez Luna
2010-01-15 21:28 ` [PATCH 07/10] DSPBRIDGE: checkpatch spacing and indentation Omar Ramirez Luna
2010-01-15 21:28 ` [PATCH 08/10] DSPBRIDGE: Checkpatch - line over 80 characters Omar Ramirez Luna
2010-01-15 21:28 ` Omar Ramirez Luna [this message]
2010-01-15 21:28 ` [PATCH 10/10] DSPBRIDGE: trivial cleanup for io_sm Omar Ramirez Luna
2010-01-18 19:13 ` [PATCH 00/10] trivial cleanups Ramirez Luna, Omar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263590921-24357-10-git-send-email-omar.ramirez@ti.com \
--to=omar.ramirez@ti.com \
--cc=Hiroshi.DOYU@nokia.com \
--cc=ameya.palande@nokia.com \
--cc=felipe.contreras@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox