Re: [PATCH] DSPBRIDGE: replace init_timer with init_timer_on_stack

[Ameya Palande <ameya.palande@nokia.com>]

On Wed, 2010-01-20 at 01:45 +0100, ext Nishanth Menon wrote:
> With LOCK_DEP enabled and DEBUG_OBJECTS_TIMERS, DSPBridge
> SYNC_WaitOnMultipleEvents will fail with message
> "ODEBUG: object is on stack, but not annotated"
> since the timeout timer is on the stack, we should rightly use
> init_timer_on_stack.
> 
> Cc: Ameya Palande <ameya.palande@nokia.com>
> Cc: Deepak Chitriki <deepak.chitriki@ti.com>
> Cc: Felipe Contreras <felipe.contreras@nokia.com>
> Cc: Hiroshi Doyu <hiroshi.doyu@nokia.com>
> Cc: Omar Ramirez Luna <omar.ramirez@ti.com>
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
>  drivers/dsp/bridge/services/sync.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/dsp/bridge/services/sync.c b/drivers/dsp/bridge/services/sync.c
> index c2d79c7..d246656 100644
> --- a/drivers/dsp/bridge/services/sync.c
> +++ b/drivers/dsp/bridge/services/sync.c
> @@ -330,7 +330,7 @@ DSP_STATUS SYNC_WaitOnMultipleEvents(struct SYNC_OBJECT **hSyncEvents,
>  	if (Wp->state != wo_signalled && dwTimeout > 0) {
>  		struct timer_list timeout;
>  		if (dwTimeout != SYNC_INFINITE) {
> -			init_timer(&timeout);
> +			init_timer_on_stack(&timeout);
>  			timeout.function = timeout_callback;
>  			timeout.data = (unsigned long)Wp;
>  			timeout.expires = jiffies + dwTimeout * HZ / 1000;

Acked-by: Ameya Palande <ameya.palande@nokia.com>