* [PATCH] DSPBRIDGE: replace init_timer with init_timer_on_stack
@ 2010-01-20 0:45 Nishanth Menon
2010-01-20 9:55 ` Ameya Palande
0 siblings, 1 reply; 3+ messages in thread
From: Nishanth Menon @ 2010-01-20 0:45 UTC (permalink / raw)
To: linux-omap
Cc: Nishanth Menon, Ameya Palande, Deepak Chitriki, Felipe Contreras,
Hiroshi Doyu, Omar Ramirez Luna
With LOCK_DEP enabled and DEBUG_OBJECTS_TIMERS, DSPBridge
SYNC_WaitOnMultipleEvents will fail with message
"ODEBUG: object is on stack, but not annotated"
since the timeout timer is on the stack, we should rightly use
init_timer_on_stack.
Cc: Ameya Palande <ameya.palande@nokia.com>
Cc: Deepak Chitriki <deepak.chitriki@ti.com>
Cc: Felipe Contreras <felipe.contreras@nokia.com>
Cc: Hiroshi Doyu <hiroshi.doyu@nokia.com>
Cc: Omar Ramirez Luna <omar.ramirez@ti.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
---
drivers/dsp/bridge/services/sync.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/dsp/bridge/services/sync.c b/drivers/dsp/bridge/services/sync.c
index c2d79c7..d246656 100644
--- a/drivers/dsp/bridge/services/sync.c
+++ b/drivers/dsp/bridge/services/sync.c
@@ -330,7 +330,7 @@ DSP_STATUS SYNC_WaitOnMultipleEvents(struct SYNC_OBJECT **hSyncEvents,
if (Wp->state != wo_signalled && dwTimeout > 0) {
struct timer_list timeout;
if (dwTimeout != SYNC_INFINITE) {
- init_timer(&timeout);
+ init_timer_on_stack(&timeout);
timeout.function = timeout_callback;
timeout.data = (unsigned long)Wp;
timeout.expires = jiffies + dwTimeout * HZ / 1000;
--
1.6.3.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] DSPBRIDGE: replace init_timer with init_timer_on_stack
2010-01-20 0:45 [PATCH] DSPBRIDGE: replace init_timer with init_timer_on_stack Nishanth Menon
@ 2010-01-20 9:55 ` Ameya Palande
2010-01-20 22:53 ` Ramirez Luna, Omar
0 siblings, 1 reply; 3+ messages in thread
From: Ameya Palande @ 2010-01-20 9:55 UTC (permalink / raw)
To: ext Nishanth Menon
Cc: linux-omap, Deepak Chitriki, Contreras Felipe (Nokia-D/Helsinki),
Doyu Hiroshi (Nokia-D/Helsinki), Omar Ramirez Luna
On Wed, 2010-01-20 at 01:45 +0100, ext Nishanth Menon wrote:
> With LOCK_DEP enabled and DEBUG_OBJECTS_TIMERS, DSPBridge
> SYNC_WaitOnMultipleEvents will fail with message
> "ODEBUG: object is on stack, but not annotated"
> since the timeout timer is on the stack, we should rightly use
> init_timer_on_stack.
>
> Cc: Ameya Palande <ameya.palande@nokia.com>
> Cc: Deepak Chitriki <deepak.chitriki@ti.com>
> Cc: Felipe Contreras <felipe.contreras@nokia.com>
> Cc: Hiroshi Doyu <hiroshi.doyu@nokia.com>
> Cc: Omar Ramirez Luna <omar.ramirez@ti.com>
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> drivers/dsp/bridge/services/sync.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/dsp/bridge/services/sync.c b/drivers/dsp/bridge/services/sync.c
> index c2d79c7..d246656 100644
> --- a/drivers/dsp/bridge/services/sync.c
> +++ b/drivers/dsp/bridge/services/sync.c
> @@ -330,7 +330,7 @@ DSP_STATUS SYNC_WaitOnMultipleEvents(struct SYNC_OBJECT **hSyncEvents,
> if (Wp->state != wo_signalled && dwTimeout > 0) {
> struct timer_list timeout;
> if (dwTimeout != SYNC_INFINITE) {
> - init_timer(&timeout);
> + init_timer_on_stack(&timeout);
> timeout.function = timeout_callback;
> timeout.data = (unsigned long)Wp;
> timeout.expires = jiffies + dwTimeout * HZ / 1000;
Acked-by: Ameya Palande <ameya.palande@nokia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH] DSPBRIDGE: replace init_timer with init_timer_on_stack
2010-01-20 9:55 ` Ameya Palande
@ 2010-01-20 22:53 ` Ramirez Luna, Omar
0 siblings, 0 replies; 3+ messages in thread
From: Ramirez Luna, Omar @ 2010-01-20 22:53 UTC (permalink / raw)
To: Ameya Palande, Menon, Nishanth
Cc: linux-omap, Chitriki Rudramuni, Deepak,
Contreras Felipe (Nokia-D/Helsinki),
Doyu Hiroshi (Nokia-D/Helsinki)
>From: Ameya Palande on Wednesday, January 20, 2010 3:55 AM
>
>On Wed, 2010-01-20 at 01:45 +0100, ext Nishanth Menon wrote:
>> With LOCK_DEP enabled and DEBUG_OBJECTS_TIMERS, DSPBridge
>> SYNC_WaitOnMultipleEvents will fail with message
>> "ODEBUG: object is on stack, but not annotated"
>> since the timeout timer is on the stack, we should rightly use
>> init_timer_on_stack.
>>
>> Cc: Ameya Palande <ameya.palande@nokia.com>
>> Cc: Deepak Chitriki <deepak.chitriki@ti.com>
>> Cc: Felipe Contreras <felipe.contreras@nokia.com>
>> Cc: Hiroshi Doyu <hiroshi.doyu@nokia.com>
>> Cc: Omar Ramirez Luna <omar.ramirez@ti.com>
>>
>> Signed-off-by: Nishanth Menon <nm@ti.com>
>> ---
>> drivers/dsp/bridge/services/sync.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/dsp/bridge/services/sync.c b/drivers/dsp/bridge/services/sync.c
>> index c2d79c7..d246656 100644
>> --- a/drivers/dsp/bridge/services/sync.c
>> +++ b/drivers/dsp/bridge/services/sync.c
>> @@ -330,7 +330,7 @@ DSP_STATUS SYNC_WaitOnMultipleEvents(struct SYNC_OBJECT **hSyncEvents,
>> if (Wp->state != wo_signalled && dwTimeout > 0) {
>> struct timer_list timeout;
>> if (dwTimeout != SYNC_INFINITE) {
>> - init_timer(&timeout);
>> + init_timer_on_stack(&timeout);
>> timeout.function = timeout_callback;
>> timeout.data = (unsigned long)Wp;
>> timeout.expires = jiffies + dwTimeout * HZ / 1000;
>
>Acked-by: Ameya Palande <ameya.palande@nokia.com>
Pushed to dspbridge
- omar
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-01-20 22:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-20 0:45 [PATCH] DSPBRIDGE: replace init_timer with init_timer_on_stack Nishanth Menon
2010-01-20 9:55 ` Ameya Palande
2010-01-20 22:53 ` Ramirez Luna, Omar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox