From: Ameya Palande <ameya.palande@nokia.com>
To: ext Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"omar.ramirez@ti.com" <omar.ramirez@ti.com>,
"nm@ti.com" <nm@ti.com>,
"deepak.chitriki@ti.com" <deepak.chitriki@ti.com>,
"Kukkonen Mika (Nokia-D/Helsinki)" <mika.kukkonen@nokia.com>
Subject: Re: [PATCH] DSPBRIDGE: Various compile warning fixes
Date: Thu, 21 Jan 2010 18:33:08 +0200 [thread overview]
Message-ID: <1264091588.3544.12.camel@sanganak> (raw)
In-Reply-To: <5ec8ebd51001210801h3eb8c337l2cd0d4e501ed724f@mail.gmail.com>
On Thu, 2010-01-21 at 17:01 +0100, ext Andy Shevchenko wrote:
> On Thu, Jan 21, 2010 at 3:40 PM, Ameya Palande <ameya.palande@nokia.com> wrote:
> > --- a/drivers/dsp/bridge/wmd/io_sm.c
> > +++ b/drivers/dsp/bridge/wmd/io_sm.c
> > @@ -1210,7 +1210,7 @@ static void InputChnl(struct IO_MGR *pIOMgr, struct CHNL_OBJECT *pChnl,
> > pChnlMgr->uWordSize;
> > chnlId = IO_GetValue(pIOMgr->hWmdContext, struct SHM, sm, inputId);
> > dwArg = IO_GetLong(pIOMgr->hWmdContext, struct SHM, sm, arg);
> > - if (!(chnlId >= 0) || !(chnlId < CHNL_MAXCHANNELS)) {
> > + if (chnlId >= CHNL_MAXCHANNELS) {
> Could chnlld be less than zero? Anyway better to test:
> (chnlId >= CHNL_MAXCHANNELS || chnlld < 0)
>
chnlId is defined as u32 ;)
Cheers,
Ameya.
next prev parent reply other threads:[~2010-01-21 16:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 13:40 [PATCH] DSPBRIDGE: Various compile warning fixes Ameya Palande
2010-01-21 16:01 ` Andy Shevchenko
2010-01-21 16:33 ` Ameya Palande [this message]
2010-01-22 6:00 ` mika.kukkonen
2010-01-25 16:59 ` Omar Ramirez Luna
2010-01-25 17:03 ` ameya.palande
2010-01-26 6:03 ` mika.kukkonen
2010-01-26 23:52 ` Omar Ramirez Luna
-- strict thread matches above, loose matches on Subject: below --
2009-06-08 15:47 Ameya Palande
2009-04-17 9:30 [PATCH] [DSPBRIDGE] " Ameya Palande
2009-04-17 14:13 ` Gupta, Ramesh
2009-04-17 14:20 ` Kanigeri, Hari
2009-04-20 5:23 ` mika.kukkonen
2009-04-20 12:59 ` Kanigeri, Hari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264091588.3544.12.camel@sanganak \
--to=ameya.palande@nokia.com \
--cc=andy.shevchenko@gmail.com \
--cc=deepak.chitriki@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=mika.kukkonen@nokia.com \
--cc=nm@ti.com \
--cc=omar.ramirez@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox