From: Omar Ramirez Luna <omar.ramirez@ti.com>
To: linux-omap <linux-omap@vger.kernel.org>
Cc: Ameya Palande <ameya.palande@nokia.com>,
Hiroshi Doyu <Hiroshi.DOYU@nokia.com>,
Felipe Contreras <felipe.contreras@nokia.com>,
Nishanth Menon <nm@ti.com>,
Omar Ramirez Luna <omar.ramirez@ti.com>
Subject: [PATCH 1/5] DSPBRIDGE: Avoid multiple calls to SERVICES_[Init|Exit]
Date: Fri, 22 Jan 2010 21:33:20 -0600 [thread overview]
Message-ID: <1264217604-8021-2-git-send-email-omar.ramirez@ti.com> (raw)
In-Reply-To: <1264217604-8021-1-git-send-email-omar.ramirez@ti.com>
Avoid calling multiple times to SERVICES_[Init|Exit] functions,
these should be called once at probe and exit respectively.
Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
---
drivers/dsp/bridge/pmgr/wcd.c | 10 ++--------
1 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/dsp/bridge/pmgr/wcd.c b/drivers/dsp/bridge/pmgr/wcd.c
index 962cac6..2afe222 100644
--- a/drivers/dsp/bridge/pmgr/wcd.c
+++ b/drivers/dsp/bridge/pmgr/wcd.c
@@ -302,7 +302,6 @@ void WCD_Exit(void)
MGR_Exit();
RMM_exit();
DRV_Exit();
- SERVICES_Exit();
}
DBC_Ensure(WCD_cRefs >= 0);
}
@@ -315,12 +314,10 @@ void WCD_Exit(void)
bool WCD_Init(void)
{
bool fInit = true;
- bool fDRV, fDEV, fCOD, fSERVICES, fCHNL, fMSG, fIO;
+ bool fDRV, fDEV, fCOD, fCHNL, fMSG, fIO;
bool fMGR, fPROC, fNODE, fDISP, fNTFY, fSTRM, fRMM;
if (WCD_cRefs == 0) {
- /* initialize all SERVICES modules */
- fSERVICES = SERVICES_Init();
/* initialize debugging module */
DBC_Assert(!WCD_debugMask.flags);
GT_create(&WCD_debugMask, "CD"); /* CD for class driver */
@@ -338,13 +335,10 @@ bool WCD_Init(void)
fIO = IO_Init();
fDEV = DEV_Init();
fCOD = COD_Init();
- fInit = fSERVICES && fDRV && fDEV && fCHNL && fCOD &&
+ fInit = fDRV && fDEV && fCHNL && fCOD &&
fMSG && fIO;
fInit = fInit && fMGR && fPROC && fRMM;
if (!fInit) {
- if (fSERVICES)
- SERVICES_Exit();
-
if (fDRV)
DRV_Exit();
--
1.6.2.4
next prev parent reply other threads:[~2010-01-23 3:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-23 3:33 [PATCH 0/5] DSPBRIDGE: centralized services initialization Omar Ramirez Luna
2010-01-23 3:33 ` Omar Ramirez Luna [this message]
2010-01-23 3:33 ` [PATCH 2/5] DSPBRIDGE: remove crefs for SERVICES[Init|Exit] Omar Ramirez Luna
2010-01-23 3:33 ` [PATCH 3/5] DSPBRIDGE: Remove multiple initializations of MEM module Omar Ramirez Luna
2010-01-23 3:33 ` [PATCH 4/5] DSPBRIDGE: Remove multiple initializations of REG module Omar Ramirez Luna
2010-01-23 3:33 ` [PATCH 5/5] DSPBRIDGE: Remove multiple initializations of NTFY module Omar Ramirez Luna
2010-01-26 1:57 ` [RESEND][PATCH 4/5] DSPBRIDGE: Remove multiple initializations of REG module Omar Ramirez Luna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264217604-8021-2-git-send-email-omar.ramirez@ti.com \
--to=omar.ramirez@ti.com \
--cc=Hiroshi.DOYU@nokia.com \
--cc=ameya.palande@nokia.com \
--cc=felipe.contreras@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox