From: Omar Ramirez Luna <omar.ramirez@ti.com>
To: linux-omap <linux-omap@vger.kernel.org>
Cc: Ameya Palande <ameya.palande@nokia.com>,
Hiroshi Doyu <Hiroshi.DOYU@nokia.com>,
Felipe Contreras <felipe.contreras@nokia.com>,
Nishanth Menon <nm@ti.com>, Shivananda Hebbar <x0hebbar@ti.com>
Subject: [PATCH] DSPBRIDGE: Remove conditional check from the InputMsg function
Date: Tue, 26 Jan 2010 19:44:32 -0600 [thread overview]
Message-ID: <1264556672-27492-1-git-send-email-omar.ramirez@ti.com> (raw)
From: Shivananda Hebbar <x0hebbar@ti.com>
This patch removes the conditional check which can result in
message skip.
Discovered-by: Bhavin Shah <bshah@ti.com>
Signed-off-by: Shivananda Hebbar <x0hebbar@ti.com>
---
drivers/dsp/bridge/wmd/io_sm.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/drivers/dsp/bridge/wmd/io_sm.c b/drivers/dsp/bridge/wmd/io_sm.c
index 39b37a6..b2092a2 100644
--- a/drivers/dsp/bridge/wmd/io_sm.c
+++ b/drivers/dsp/bridge/wmd/io_sm.c
@@ -1328,7 +1328,7 @@ static void InputMsg(struct IO_MGR *pIOMgr, struct MSG_MGR *hMsgMgr)
fInputEmpty = IO_GetValue(pIOMgr->hWmdContext, struct MSG, pCtrl,
bufEmpty);
uMsgs = IO_GetValue(pIOMgr->hWmdContext, struct MSG, pCtrl, size);
- if (fInputEmpty || uMsgs >= hMsgMgr->uMaxMsgs)
+ if (fInputEmpty)
goto func_end;
pMsgInput = pIOMgr->pMsgInput;
@@ -1356,9 +1356,6 @@ static void InputMsg(struct IO_MGR *pIOMgr, struct MSG_MGR *hMsgMgr)
* input locations have been set up. If all nodes were
* cleaned up, hMsgMgr->uMaxMsgs should be 0.
*/
- if (hMsgQueue && uMsgs > hMsgMgr->uMaxMsgs)
- goto func_end;
-
while (hMsgQueue != NULL) {
if (msg.dwId == hMsgQueue->dwId) {
/* Found it */
--
1.6.2.4
next reply other threads:[~2010-01-27 1:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-27 1:44 Omar Ramirez Luna [this message]
2010-01-27 9:44 ` [PATCH] DSPBRIDGE: Remove conditional check from the InputMsg function Ameya Palande
2010-01-27 17:04 ` Hebbar, Shivananda
2010-02-01 9:57 ` Ameya Palande
-- strict thread matches above, loose matches on Subject: below --
2009-12-29 16:34 [PATCH ] DSPBRIDGE:Remove " Hebbar, Shivananda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264556672-27492-1-git-send-email-omar.ramirez@ti.com \
--to=omar.ramirez@ti.com \
--cc=Hiroshi.DOYU@nokia.com \
--cc=ameya.palande@nokia.com \
--cc=felipe.contreras@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=x0hebbar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox