From: Omar Ramirez Luna <omar.ramirez@ti.com>
To: linux-omap <linux-omap@vger.kernel.org>
Cc: Ameya Palande <ameya.palande@nokia.com>,
Hiroshi Doyu <Hiroshi.DOYU@nokia.com>,
Felipe Contreras <felipe.contreras@nokia.com>,
Nishanth Menon <nm@ti.com>,
Omar Ramirez Luna <omar.ramirez@ti.com>
Subject: [PATCH 05/12] DSPBRIDGE: Change custom GT_trace for dev_dbg in services
Date: Thu, 18 Feb 2010 15:37:56 -0600 [thread overview]
Message-ID: <1266529083-2358-6-git-send-email-omar.ramirez@ti.com> (raw)
In-Reply-To: <1266529083-2358-5-git-send-email-omar.ramirez@ti.com>
Remove GT_Trace custom debugging mechanism and use dev_dbg.
Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
---
drivers/dsp/bridge/services/cfg.c | 3 +--
drivers/dsp/bridge/services/clk.c | 5 ++---
drivers/dsp/bridge/services/regsup.c | 21 +++++++++------------
3 files changed, 12 insertions(+), 17 deletions(-)
diff --git a/drivers/dsp/bridge/services/cfg.c b/drivers/dsp/bridge/services/cfg.c
index d26f8b9..295ff11 100644
--- a/drivers/dsp/bridge/services/cfg.c
+++ b/drivers/dsp/bridge/services/cfg.c
@@ -205,8 +205,7 @@ DSP_STATUS CFG_GetHostResources(struct CFG_DEVNODE *hDevNode,
}
#ifdef CONFIG_BRIDGE_DEBUG
if (DSP_FAILED(status))
- GT_0trace(CFG_debugMask, GT_6CLASS,
- "CFG_GetHostResources Failed \n");
+ dev_dbg(bridge, "%s Failed, status 0x%x\n", __func__, status);
#endif
return status;
}
diff --git a/drivers/dsp/bridge/services/clk.c b/drivers/dsp/bridge/services/clk.c
index f8c417a..04d49bd 100644
--- a/drivers/dsp/bridge/services/clk.c
+++ b/drivers/dsp/bridge/services/clk.c
@@ -275,9 +275,8 @@ DSP_STATUS CLK_GetRate(IN enum SERVICES_ClkId clk_id, u32 *speedKhz)
if (pClk) {
clkSpeedHz = clk_get_rate(pClk);
*speedKhz = clkSpeedHz / 1000;
- GT_2trace(CLK_debugMask, GT_6CLASS,
- "CLK_GetRate: clkSpeedHz = %d , "
- "speedinKhz=%d\n", clkSpeedHz, *speedKhz);
+ dev_dbg(bridge, "%s: clkSpeedHz = %d, speedinKhz = %d\n",
+ __func__, clkSpeedHz, *speedKhz);
} else {
pr_err("%s: failed to get %s, dev Id = %d\n", __func__,
SERVICES_Clks[clk_id].clk_name,
diff --git a/drivers/dsp/bridge/services/regsup.c b/drivers/dsp/bridge/services/regsup.c
index 0c77fb2..04f6b3a 100644
--- a/drivers/dsp/bridge/services/regsup.c
+++ b/drivers/dsp/bridge/services/regsup.c
@@ -105,12 +105,7 @@ DSP_STATUS regsupGetValue(char *valName, void *pBuf, u32 *dataSize)
(struct list_head *) rv);
}
- if (DSP_SUCCEEDED(retVal)) {
- GT_2trace(REG_debugMask, GT_2CLASS, "G %s DATA %x ", valName,
- *(u32 *)pBuf);
- } else {
- GT_1trace(REG_debugMask, GT_3CLASS, "G %s FAILED\n", valName);
- }
+ dev_dbg(bridge, "REG: get %s, status = 0x%x\n", valName, retVal);
return retVal;
}
@@ -125,9 +120,6 @@ DSP_STATUS regsupSetValue(char *valName, void *pBuf, u32 dataSize)
DSP_STATUS retVal = DSP_EFAIL;
struct RegValue *rv = (struct RegValue *) LST_First(pRegKey);
- GT_2trace(REG_debugMask, GT_2CLASS, "S %s DATA %x ", valName,
- *(u32 *)pBuf);
-
/* Need to search through the entries looking for the right one. */
while (rv) {
/* See if the name matches. */
@@ -171,6 +163,8 @@ DSP_STATUS regsupSetValue(char *valName, void *pBuf, u32 dataSize)
}
}
+ dev_dbg(bridge, "REG: set %s, status = 0x%x", valName, retVal);
+
return retVal;
}
@@ -203,9 +197,6 @@ DSP_STATUS regsupEnumValue(IN u32 dwIndex, IN CONST char *pstrKey,
*pdwValueSize = strlen(&(rv->name[dwKeyLen]));
strncpy(pstrValue, &(rv->name[dwKeyLen]),
*pdwValueSize + 1);
- GT_3trace(REG_debugMask, GT_2CLASS,
- "E Key %s, Value %s, Data %x ",
- pstrKey, pstrValue, *(u32 *)pstrData);
/* Set our status to good and exit. */
retVal = DSP_SOK;
break;
@@ -217,6 +208,9 @@ DSP_STATUS regsupEnumValue(IN u32 dwIndex, IN CONST char *pstrKey,
if (count && DSP_FAILED(retVal))
retVal = REG_E_NOMOREITEMS;
+ dev_dbg(bridge, "REG: enum Key %s, Value %s, status = 0x%x",
+ pstrKey, pstrValue, retVal);
+
return retVal;
}
@@ -248,6 +242,9 @@ DSP_STATUS regsupDeleteValue(IN CONST char *pstrValue)
rv = (struct RegValue *)LST_Next(pRegKey,
(struct list_head *)rv);
}
+
+ dev_dbg(bridge, "REG: del %s, status = 0x%x", pstrValue, retVal);
+
return retVal;
}
--
1.6.2.4
next prev parent reply other threads:[~2010-02-18 21:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 21:37 [PATCH 00/12] Custom debug removal Omar Ramirez Luna
2010-02-18 21:37 ` [PATCH 01/12] DSPBRIDGE: global bridge device Omar Ramirez Luna
2010-02-18 21:37 ` [PATCH 02/12] DSPBRIDGE: Change custom GT_trace for dev_dbg Omar Ramirez Luna
2010-02-18 21:37 ` [PATCH 03/12] DSPBRIDGE: Change custom GT_trace for dev_dbg in wmd Omar Ramirez Luna
2010-02-18 21:37 ` [PATCH 04/12] DSPBRIDGE: Change custom GT_trace for dev_dbg in pmgr Omar Ramirez Luna
2010-02-18 21:37 ` Omar Ramirez Luna [this message]
2010-02-18 21:37 ` [PATCH 06/12] DSPBRIDGE: Remove GT_trace variables for rmgr Omar Ramirez Luna
2010-02-18 21:37 ` [PATCH 07/12] DSPBRIDGE: Remove GT_trace variables for wmd Omar Ramirez Luna
2010-02-18 21:37 ` [PATCH 08/12] DSPBRIDGE: Remove GT_trace variables for pmgr Omar Ramirez Luna
2010-02-18 21:38 ` [PATCH 09/12] DSPBRIDGE: Remove GT_trace variables for services Omar Ramirez Luna
2010-02-18 21:38 ` [PATCH 10/12] DSPBRIDGE: Remove custom debugging implementation Omar Ramirez Luna
2010-02-18 21:38 ` [PATCH 11/12] DSPBRIDGE: Remove debug header files Omar Ramirez Luna
2010-02-18 21:38 ` [PATCH 12/12] DSPBRIDGE: Remove unused instances of CONFIG_BRIDGE_DEBUG Omar Ramirez Luna
2010-02-23 18:09 ` [PATCH 00/12] Custom debug removal Omar Ramirez Luna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1266529083-2358-6-git-send-email-omar.ramirez@ti.com \
--to=omar.ramirez@ti.com \
--cc=Hiroshi.DOYU@nokia.com \
--cc=ameya.palande@nokia.com \
--cc=felipe.contreras@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox