Re: [PATCH] omap2_mcspi.c: Clock divider range check wrong for OMAP3

Felipe Balbi
2010-03-08T15:53:44Z

On Mon, Mar 08, 2010 at 06:56:51AM -0500, Scott Ellis wrote:
> diff --git a/drivers/spi/omap2_mcspi.c b/drivers/spi/omap2_mcspi.c
> index fe1b56d..a73127b 100644
> --- a/drivers/spi/omap2_mcspi.c
> +++ b/drivers/spi/omap2_mcspi.c
> @@ -38,8 +38,17 @@
> #include <plat/dma.h>
> #include <plat/clock.h>
>
> +#if defined(CONFIG_ARCH_OMAP3) || defined(CONFIG_ARCH_OMAP4)
> +#define OMAP2_MCSPI_MAX_CLK_DIV 12
> +#else
> +/* could be 12 for OMAP24xxx also, no docs to check */
> +#define OMAP2_MCSPI_MAX_CLK_DIV 15
> +#endif
>
> #define OMAP2_MCSPI_MAX_FREQ 48000000
> +#define OMAP2_MCSPI_MIN_FREQ (OMAP2_MCSPI_MAX_FREQ \
> + / (1 << OMAP2_MCSPI_MAX_CLK_DIV))

please don't break multi-omap builds. Pass this constant using platform_data.

--
balbi