* Re: [dspbridge] news: omap mailbox implementation
2010-03-23 18:08 [dspbridge] news: omap mailbox implementation Omar Ramirez Luna
@ 2010-03-23 17:54 ` Ameya Palande
2010-03-23 18:29 ` Omar Ramirez Luna
0 siblings, 1 reply; 6+ messages in thread
From: Ameya Palande @ 2010-03-23 17:54 UTC (permalink / raw)
To: ext Omar Ramirez Luna
Cc: linux-omap@vger.kernel.org, Doyu Hiroshi (Nokia-D/Helsinki),
Tony Lindgren, Felipe Contreras,
Valkeinen Tomi (Nokia-D/Helsinki), Shivananda Hebbar,
Shevchenko Andriy (EXT-Teleca/Helsinki), Ernesto Ramos,
Fernando Guzman Lugo, Ramesh Gupta G,
Kukkonen Mika (Nokia-D/Helsinki), Hari Kanigeri, Nishanth Menon,
C A Subramaniam, Rebecca Schultz Zavin,
Carmody Phil.2 (EXT-Ixonos/Helsinki)
Hi Omar,
On Tue, 2010-03-23 at 19:08 +0100, ext Omar Ramirez Luna wrote:
> Hi All,
>
> When updating the custom dspbridge mailbox functions with the ones
> avaliable through omap mailbox (by pulling latest dspbridge),
> PLEASE remember to enable omap mailbox through menuconfig:
>
> make menuconfig
>
> System Type --->
> TI OMAP Implementations --->
> <*> Mailbox framework support
>
> otherwise, compilation will break like:
>
> Building modules, stage 2.
> MODPOST 7 modules
> ERROR: "omap_mbox_msg_send" [drivers/dsp/bridge/bridgedriver.ko] undefined!
> ERROR: "omap_mbox_put" [drivers/dsp/bridge/bridgedriver.ko] undefined!
> ERROR: "omap_mbox_get" [drivers/dsp/bridge/bridgedriver.ko] undefined!
> make[2]: *** [__modpost] Error 1
> make[1]: *** [modules] Error 2
> make: *** [modules] Error 2
Can't we make DSP Bridge driver depend on mailbox then?
Cheers,
Ameya.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dspbridge] news: omap mailbox implementation
@ 2010-03-23 18:08 Omar Ramirez Luna
2010-03-23 17:54 ` Ameya Palande
0 siblings, 1 reply; 6+ messages in thread
From: Omar Ramirez Luna @ 2010-03-23 18:08 UTC (permalink / raw)
To: linux-omap
Cc: Hiroshi DOYU, Tony Lindgren, Ameya Palande, Felipe Contreras,
Tomi Valkeinen, Shivananda Hebbar, Andy Shevchenko, Ernesto Ramos,
Fernando Guzman Lugo, Ramesh Gupta G, Mika Kukkonen,
Hari Kanigeri, Nishanth Menon, C A Subramaniam,
Rebecca Schultz Zavin, Phil Carmody, Omar Ramirez Luna
Hi All,
When updating the custom dspbridge mailbox functions with the ones
avaliable through omap mailbox (by pulling latest dspbridge),
PLEASE remember to enable omap mailbox through menuconfig:
make menuconfig
System Type --->
TI OMAP Implementations --->
<*> Mailbox framework support
otherwise, compilation will break like:
Building modules, stage 2.
MODPOST 7 modules
ERROR: "omap_mbox_msg_send" [drivers/dsp/bridge/bridgedriver.ko] undefined!
ERROR: "omap_mbox_put" [drivers/dsp/bridge/bridgedriver.ko] undefined!
ERROR: "omap_mbox_get" [drivers/dsp/bridge/bridgedriver.ko] undefined!
make[2]: *** [__modpost] Error 1
make[1]: *** [modules] Error 2
make: *** [modules] Error 2
Regards,
Omar
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dspbridge] news: omap mailbox implementation
2010-03-23 17:54 ` Ameya Palande
@ 2010-03-23 18:29 ` Omar Ramirez Luna
2010-03-23 18:31 ` Ameya Palande
2010-03-23 18:33 ` Omar Ramirez Luna
0 siblings, 2 replies; 6+ messages in thread
From: Omar Ramirez Luna @ 2010-03-23 18:29 UTC (permalink / raw)
To: Ameya Palande
Cc: linux-omap@vger.kernel.org, Doyu Hiroshi (Nokia-D/Helsinki),
Tony Lindgren, Felipe Contreras,
Valkeinen Tomi (Nokia-D/Helsinki), Hebbar, Shivananda,
Shevchenko Andriy (EXT-Teleca/Helsinki), Ramos Falcon, Ernesto,
Guzman Lugo, Fernando, Gupta, Ramesh,
Kukkonen Mika (Nokia-D/Helsinki), Kanigeri, Hari, Menon, Nishanth,
C.A, Subramaniam, Rebecca Schultz Zavin,
Carmody Phil.2 (EXT-Ixonos/Helsinki)
On 3/23/2010 12:54 PM, Ameya Palande wrote:
> Hi Omar,
>
> On Tue, 2010-03-23 at 19:08 +0100, ext Omar Ramirez Luna wrote:
>> Hi All,
>>
>> When updating the custom dspbridge mailbox functions with the ones
>> avaliable through omap mailbox (by pulling latest dspbridge),
>> PLEASE remember to enable omap mailbox through menuconfig:
>>
>> make menuconfig
>>
>> System Type --->
>> TI OMAP Implementations --->
>> <*> Mailbox framework support
>>
>> otherwise, compilation will break like:
>>
>> Building modules, stage 2.
>> MODPOST 7 modules
>> ERROR: "omap_mbox_msg_send" [drivers/dsp/bridge/bridgedriver.ko] undefined!
>> ERROR: "omap_mbox_put" [drivers/dsp/bridge/bridgedriver.ko] undefined!
>> ERROR: "omap_mbox_get" [drivers/dsp/bridge/bridgedriver.ko] undefined!
>> make[2]: *** [__modpost] Error 1
>> make[1]: *** [modules] Error 2
>> make: *** [modules] Error 2
>
> Can't we make DSP Bridge driver depend on mailbox then?
>
Yes we can, but I thought that new-to-bridge people who want to compile
a kernel and are impatient enough to read a wiki (updating as we speak),
would freak out if DSP Bridge is not shown in menuconfig because it is
dependent on mailbox ;). Also thought that a note in Bridge defconfig
option might be enough "This driver depends on OMAP Mailbox
(OMAP_MBOX_FWK).", rather than a hard dependency.
The other option was to update the defconfig.
I'm fine with any of those or if anyone has a better suggestion.
Regards,
Omar
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dspbridge] news: omap mailbox implementation
2010-03-23 18:29 ` Omar Ramirez Luna
@ 2010-03-23 18:31 ` Ameya Palande
2010-03-23 18:42 ` Omar Ramirez Luna
2010-03-23 18:33 ` Omar Ramirez Luna
1 sibling, 1 reply; 6+ messages in thread
From: Ameya Palande @ 2010-03-23 18:31 UTC (permalink / raw)
To: ext Omar Ramirez Luna
Cc: linux-omap@vger.kernel.org, Doyu Hiroshi (Nokia-D/Helsinki),
Tony Lindgren, Felipe Contreras,
Valkeinen Tomi (Nokia-D/Helsinki), Hebbar, Shivananda,
Shevchenko Andriy (EXT-Teleca/Helsinki), Ramos Falcon, Ernesto,
Guzman Lugo, Fernando, Gupta, Ramesh,
Kukkonen Mika (Nokia-D/Helsinki), Kanigeri, Hari, Menon, Nishanth,
C.A, Subramaniam, Rebecca Schultz Zavin,
Carmody Phil.2 (EXT-Ixonos/Helsinki)
On Tue, 2010-03-23 at 19:29 +0100, ext Omar Ramirez Luna wrote:
> On 3/23/2010 12:54 PM, Ameya Palande wrote:
> > Hi Omar,
> >
> > On Tue, 2010-03-23 at 19:08 +0100, ext Omar Ramirez Luna wrote:
> >> Hi All,
> >>
> >> When updating the custom dspbridge mailbox functions with the ones
> >> avaliable through omap mailbox (by pulling latest dspbridge),
> >> PLEASE remember to enable omap mailbox through menuconfig:
> >>
> >> make menuconfig
> >>
> >> System Type --->
> >> TI OMAP Implementations --->
> >> <*> Mailbox framework support
> >>
> >> otherwise, compilation will break like:
> >>
> >> Building modules, stage 2.
> >> MODPOST 7 modules
> >> ERROR: "omap_mbox_msg_send" [drivers/dsp/bridge/bridgedriver.ko] undefined!
> >> ERROR: "omap_mbox_put" [drivers/dsp/bridge/bridgedriver.ko] undefined!
> >> ERROR: "omap_mbox_get" [drivers/dsp/bridge/bridgedriver.ko] undefined!
> >> make[2]: *** [__modpost] Error 1
> >> make[1]: *** [modules] Error 2
> >> make: *** [modules] Error 2
> >
> > Can't we make DSP Bridge driver depend on mailbox then?
> >
>
> Yes we can, but I thought that new-to-bridge people who want to compile
> a kernel and are impatient enough to read a wiki (updating as we speak),
> would freak out if DSP Bridge is not shown in menuconfig because it is
> dependent on mailbox ;). Also thought that a note in Bridge defconfig
> option might be enough "This driver depends on OMAP Mailbox
> (OMAP_MBOX_FWK).", rather than a hard dependency.
I would go for hard dependency since otherwise we can't compile
dspbridge module :(
IMO selecting dspbridge module should automatically select mailbox
module as well and same should apply for modprobe also :)
Cheers,
Ameya.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dspbridge] news: omap mailbox implementation
2010-03-23 18:29 ` Omar Ramirez Luna
2010-03-23 18:31 ` Ameya Palande
@ 2010-03-23 18:33 ` Omar Ramirez Luna
1 sibling, 0 replies; 6+ messages in thread
From: Omar Ramirez Luna @ 2010-03-23 18:33 UTC (permalink / raw)
To: Ameya Palande
Cc: linux-omap@vger.kernel.org, Doyu Hiroshi (Nokia-D/Helsinki),
Tony Lindgren, Felipe Contreras,
Valkeinen Tomi (Nokia-D/Helsinki), Hebbar, Shivananda,
Shevchenko Andriy (EXT-Teleca/Helsinki), Ramos Falcon, Ernesto,
Guzman Lugo, Fernando, Gupta, Ramesh,
Kukkonen Mika (Nokia-D/Helsinki), Kanigeri, Hari, Menon, Nishanth,
C.A, Subramaniam, Rebecca Schultz Zavin,
Carmody Phil.2 (EXT-Ixonos/Helsinki)
On 3/23/2010 1:29 PM, Omar Ramirez Luna wrote:
> On 3/23/2010 12:54 PM, Ameya Palande wrote:
>> Hi Omar,
>>
>> On Tue, 2010-03-23 at 19:08 +0100, ext Omar Ramirez Luna wrote:
>>> Hi All,
>>>
>>> When updating the custom dspbridge mailbox functions with the ones
>>> avaliable through omap mailbox (by pulling latest dspbridge),
>>> PLEASE remember to enable omap mailbox through menuconfig:
>>>
>>> make menuconfig
>>>
>>> System Type --->
>>> TI OMAP Implementations --->
>>> <*> Mailbox framework support
>>>
>>> otherwise, compilation will break like:
>>>
>>> Building modules, stage 2.
>>> MODPOST 7 modules
>>> ERROR: "omap_mbox_msg_send" [drivers/dsp/bridge/bridgedriver.ko] undefined!
>>> ERROR: "omap_mbox_put" [drivers/dsp/bridge/bridgedriver.ko] undefined!
>>> ERROR: "omap_mbox_get" [drivers/dsp/bridge/bridgedriver.ko] undefined!
>>> make[2]: *** [__modpost] Error 1
>>> make[1]: *** [modules] Error 2
>>> make: *** [modules] Error 2
>>
>> Can't we make DSP Bridge driver depend on mailbox then?
>>
>
> Yes we can, but I thought that new-to-bridge people who want to compile
> a kernel and are impatient enough to read a wiki (updating as we speak),
> would freak out if DSP Bridge is not shown in menuconfig because it is
> dependent on mailbox ;). Also thought that a note in Bridge defconfig
> option might be enough "This driver depends on OMAP Mailbox
> (OMAP_MBOX_FWK).", rather than a hard dependency.
>
> The other option was to update the defconfig.
>
> I'm fine with any of those or if anyone has a better suggestion.
>
By the way a third one would be to auto select mailbox when selecting
bridgedriver, but if module is selected this means that a second module
hast to be installed prior to bridgedriver.
- omar
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dspbridge] news: omap mailbox implementation
2010-03-23 18:31 ` Ameya Palande
@ 2010-03-23 18:42 ` Omar Ramirez Luna
0 siblings, 0 replies; 6+ messages in thread
From: Omar Ramirez Luna @ 2010-03-23 18:42 UTC (permalink / raw)
To: Ameya Palande
Cc: linux-omap@vger.kernel.org, Doyu Hiroshi (Nokia-D/Helsinki),
Tony Lindgren, Felipe Contreras,
Valkeinen Tomi (Nokia-D/Helsinki), Hebbar, Shivananda,
Shevchenko Andriy (EXT-Teleca/Helsinki), Ramos Falcon, Ernesto,
Guzman Lugo, Fernando, Gupta, Ramesh,
Kukkonen Mika (Nokia-D/Helsinki), Kanigeri, Hari, Menon, Nishanth,
C.A, Subramaniam, Rebecca Schultz Zavin,
Carmody Phil.2 (EXT-Ixonos/Helsinki)
On 3/23/2010 1:31 PM, Ameya Palande wrote:
> On Tue, 2010-03-23 at 19:29 +0100, ext Omar Ramirez Luna wrote:
>> On 3/23/2010 12:54 PM, Ameya Palande wrote:
>>> Hi Omar,
>>>
>>> On Tue, 2010-03-23 at 19:08 +0100, ext Omar Ramirez Luna wrote:
>>>> Hi All,
>>>>
>>>> When updating the custom dspbridge mailbox functions with the ones
>>>> avaliable through omap mailbox (by pulling latest dspbridge),
>>>> PLEASE remember to enable omap mailbox through menuconfig:
>>>>
>>>> make menuconfig
>>>>
>>>> System Type --->
>>>> TI OMAP Implementations --->
>>>> <*> Mailbox framework support
>>>>
>>>> otherwise, compilation will break like:
>>>>
>>>> Building modules, stage 2.
>>>> MODPOST 7 modules
>>>> ERROR: "omap_mbox_msg_send" [drivers/dsp/bridge/bridgedriver.ko] undefined!
>>>> ERROR: "omap_mbox_put" [drivers/dsp/bridge/bridgedriver.ko] undefined!
>>>> ERROR: "omap_mbox_get" [drivers/dsp/bridge/bridgedriver.ko] undefined!
>>>> make[2]: *** [__modpost] Error 1
>>>> make[1]: *** [modules] Error 2
>>>> make: *** [modules] Error 2
>>>
>>> Can't we make DSP Bridge driver depend on mailbox then?
>>>
>>
>> Yes we can, but I thought that new-to-bridge people who want to compile
>> a kernel and are impatient enough to read a wiki (updating as we speak),
>> would freak out if DSP Bridge is not shown in menuconfig because it is
>> dependent on mailbox ;). Also thought that a note in Bridge defconfig
>> option might be enough "This driver depends on OMAP Mailbox
>> (OMAP_MBOX_FWK).", rather than a hard dependency.
>
> I would go for hard dependency since otherwise we can't compile
> dspbridge module :(
>
> IMO selecting dspbridge module should automatically select mailbox
> module as well and same should apply for modprobe also :)
Agree to auto select then, will send a patch to modify Kconfig.
- omar
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-03-23 18:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-23 18:08 [dspbridge] news: omap mailbox implementation Omar Ramirez Luna
2010-03-23 17:54 ` Ameya Palande
2010-03-23 18:29 ` Omar Ramirez Luna
2010-03-23 18:31 ` Ameya Palande
2010-03-23 18:42 ` Omar Ramirez Luna
2010-03-23 18:33 ` Omar Ramirez Luna
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox