From: Jarkko Nikula <jhnikula@gmail.com>
To: linux-omap@vger.kernel.org
Cc: Tony Lindgren <tony@atomide.com>,
Jarkko Nikula <jhnikula@gmail.com>,
Adrian Hunter <adrian.hunter@nokia.com>,
Eduardo Valentin <eduardo.valentin@nokia.com>
Subject: [PATCH 1/3] omap: rx51: Change the TWL4030 VMMC2 voltage constraints and supply name
Date: Mon, 3 May 2010 18:56:14 +0300 [thread overview]
Message-ID: <1272902176-21033-1-git-send-email-jhnikula@gmail.com> (raw)
I believe the VMMC2 constraints must be the same than with VAUX3. Older
boards are using TWL4030 VMMC2 supply for internal MMC whereas newer are
using VAUX3 that has more limited constraints defined in this same file.
More over, the VMMC2 supply is used also for analog audio domain and the
miminum analog voltage of the TLV320AIC34 codec is 2.7 V.
To combine these two facts, the patch changes supply name to V28_A as the
newer boards register VMMC2_30 for VAUX3 and uses the same constraints than
VAUX3 since those constraints are ok for the TLV320AIC34.
Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
Cc: Adrian Hunter <adrian.hunter@nokia.com>
Cc: Eduardo Valentin <eduardo.valentin@nokia.com>
---
I was looking these from Maemo kernel sources, earlier patch [1] from
Eduardo and from commit f52eeee83d360d536cab1c0296eae0ec5f05e4dd.
I didn't find are the older boards using VMMC2 for audio but I assumed so.
1. http://marc.info/?l=linux-omap&m=125500330932605&w=2
---
arch/arm/mach-omap2/board-rx51-peripherals.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
index 4377a4c..b803f47 100644
--- a/arch/arm/mach-omap2/board-rx51-peripherals.c
+++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
@@ -370,9 +370,9 @@ static struct regulator_init_data rx51_vmmc1 = {
static struct regulator_init_data rx51_vmmc2 = {
.constraints = {
- .name = "VMMC2_30",
- .min_uV = 1850000,
- .max_uV = 3150000,
+ .name = "V28_A",
+ .min_uV = 2800000,
+ .max_uV = 3000000,
.apply_uV = true,
.valid_modes_mask = REGULATOR_MODE_NORMAL
| REGULATOR_MODE_STANDBY,
--
1.7.0
next reply other threads:[~2010-05-03 15:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-03 15:56 Jarkko Nikula [this message]
2010-05-03 15:56 ` [PATCH 2/3] omap: rx51: Add i2c2 board_info with tlv320aic3x Jarkko Nikula
2010-05-05 18:48 ` [APPLIED] " Tony Lindgren
2010-05-03 15:56 ` [PATCH 3/3] omap: rx51: Add supplies for the tlv320aic3x codec driver Jarkko Nikula
2010-05-05 14:20 ` Jarkko Nikula
2010-05-05 14:25 ` Mark Brown
2010-05-05 15:15 ` Tony Lindgren
2010-05-05 15:20 ` Mark Brown
2010-05-05 18:41 ` Jarkko Nikula
2010-05-05 21:11 ` Tony Lindgren
2010-05-05 18:49 ` [APPLIED] [PATCH 3/3] omap: rx51: Add supplies for the tlv320aic3x codec Tony Lindgren
2010-05-05 18:48 ` [APPLIED] [PATCH 1/3] omap: rx51: Change the TWL4030 VMMC2 voltage Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1272902176-21033-1-git-send-email-jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=adrian.hunter@nokia.com \
--cc=eduardo.valentin@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).