[PATCH] OMAP3: PM: fix AM35x musb issue with AUTOIDLE bit in CONTROL_SYSCONFIG

[PATCH] OMAP3: PM: fix AM35x musb issue with AUTOIDLE bit in CONTROL_SYSCONFIG

[Ajay Kumar Gupta]

MUSB interface on AM35x stops working when we set AUTOIDLE bit (D0) in
CONTROL_SYSCONFIG(0x48002010) register.

Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
---
 arch/arm/mach-omap2/pm34xx.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
index ea0000b..cc9d566 100644
--- a/arch/arm/mach-omap2/pm34xx.c
+++ b/arch/arm/mach-omap2/pm34xx.c
@@ -849,7 +849,12 @@ static void __init prcm_setup_regs(void)
 			CM_AUTOIDLE);
 	}
 
-	omap_ctrl_writel(OMAP3430_AUTOIDLE, OMAP2_CONTROL_SYSCONFIG);
+	/*
+	 * MUSB interface on AM35x stops working when we enable AUTOIDLE,
+	 * so avoid this for AM3517 and AM3505 device.
+	 */
+	if (!cpu_is_omap3517() && !cpu_is_omap3505())
+		omap_ctrl_writel(OMAP3430_AUTOIDLE, OMAP2_CONTROL_SYSCONFIG);
 
 	/*
 	 * Set all plls to autoidle. This is needed until autoidle is
-- 
1.6.2.4

Re: [PATCH] OMAP3: PM: fix AM35x musb issue with AUTOIDLE bit in CONTROL_SYSCONFIG

[Kevin Hilman]

Ajay Kumar Gupta <ajay.gupta@ti.com> writes:

> MUSB interface on AM35x stops working when we set AUTOIDLE bit (D0) in
> CONTROL_SYSCONFIG(0x48002010) register.

why?

stops working in what way?

I think you need to investigate more into why this is happening.

This suggest to me that something in the MUSB device/driver init
is not quite right for these boards.  

Kevin


> Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
>
> ---
>  arch/arm/mach-omap2/pm34xx.c |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
> index ea0000b..cc9d566 100644
> --- a/arch/arm/mach-omap2/pm34xx.c
> +++ b/arch/arm/mach-omap2/pm34xx.c
> @@ -849,7 +849,12 @@ static void __init prcm_setup_regs(void)
>  			CM_AUTOIDLE);
>  	}
>  
> -	omap_ctrl_writel(OMAP3430_AUTOIDLE, OMAP2_CONTROL_SYSCONFIG);
> +	/*
> +	 * MUSB interface on AM35x stops working when we enable AUTOIDLE,
> +	 * so avoid this for AM3517 and AM3505 device.
> +	 */
> +	if (!cpu_is_omap3517() && !cpu_is_omap3505())
> +		omap_ctrl_writel(OMAP3430_AUTOIDLE, OMAP2_CONTROL_SYSCONFIG);
>  
>  	/*
>  	 * Set all plls to autoidle. This is needed until autoidle is
> -- 
> 1.6.2.4

RE: [PATCH] OMAP3: PM: fix AM35x musb issue with AUTOIDLE bit in CONTROL_SYSCONFIG

[Gupta, Ajay Kumar]

Hi,
Kumar Gupta <ajay.gupta@ti.com> writes:
> 
> > MUSB interface on AM35x stops working when we set AUTOIDLE bit (D0) in
> > CONTROL_SYSCONFIG(0x48002010) register.
> 
> why?
> 
> stops working in what way?
> 
> I think you need to investigate more into why this is happening.
>

There is 'turnaround/timeout' error shown in first SETUP packet on
USB bus when a device is connected to OTG port.

In second retry of SETUP packet, 8 byte of GET_DESCRIPTOR went out
Successfully but there is no 'IN token' to receive the descriptor
Data although ReqPkt is set for endpoint zero.

All this observation shows that OTG controller starts misbehaving
When AUTOIDLE bit is set in CONTROL_SYSCONFIG register.

> This suggest to me that something in the MUSB device/driver init
> is not quite right for these boards.
Do you have anything specific to try in init path ?

Regards,
Ajay
> 
> Kevin
> 
> 
> > Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
> >
> > ---
> >  arch/arm/mach-omap2/pm34xx.c |    7 ++++++-
> >  1 files changed, 6 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
> > index ea0000b..cc9d566 100644
> > --- a/arch/arm/mach-omap2/pm34xx.c
> > +++ b/arch/arm/mach-omap2/pm34xx.c
> > @@ -849,7 +849,12 @@ static void __init prcm_setup_regs(void)
> >  			CM_AUTOIDLE);
> >  	}
> >
> > -	omap_ctrl_writel(OMAP3430_AUTOIDLE, OMAP2_CONTROL_SYSCONFIG);
> > +	/*
> > +	 * MUSB interface on AM35x stops working when we enable AUTOIDLE,
> > +	 * so avoid this for AM3517 and AM3505 device.
> > +	 */
> > +	if (!cpu_is_omap3517() && !cpu_is_omap3505())
> > +		omap_ctrl_writel(OMAP3430_AUTOIDLE, OMAP2_CONTROL_SYSCONFIG);
> >
> >  	/*
> >  	 * Set all plls to autoidle. This is needed until autoidle is
> > --
> > 1.6.2.4

RE: [PATCH] OMAP3: PM: fix AM35x musb issue with AUTOIDLE bit in CONTROL_SYSCONFIG

[Gupta, Ajay Kumar]

Hi,
> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> owner@vger.kernel.org] On Behalf Of Gupta, Ajay Kumar
> Sent: Thursday, May 13, 2010 5:15 PM
> To: Kevin Hilman
> Cc: linux-omap@vger.kernel.org
> Subject: RE: [PATCH] OMAP3: PM: fix AM35x musb issue with AUTOIDLE bit in
> CONTROL_SYSCONFIG
> 
> Hi,
> Kumar Gupta <ajay.gupta@ti.com> writes:
> >
> > > MUSB interface on AM35x stops working when we set AUTOIDLE bit (D0) in
> > > CONTROL_SYSCONFIG(0x48002010) register.
> >
> > why?
> >
> > stops working in what way?
> >
> > I think you need to investigate more into why this is happening.
> >
> 
> There is 'turnaround/timeout' error shown in first SETUP packet on
> USB bus when a device is connected to OTG port.
> 
> In second retry of SETUP packet, 8 byte of GET_DESCRIPTOR went out
> Successfully but there is no 'IN token' to receive the descriptor
> Data although ReqPkt is set for endpoint zero.
> 
> All this observation shows that OTG controller starts misbehaving
> When AUTOIDLE bit is set in CONTROL_SYSCONFIG register.
> 
> > This suggest to me that something in the MUSB device/driver init
> > is not quite right for these boards.
> Do you have anything specific to try in init path ?

I observed OTG port to be working with plane linus's tree + AM3517 musb
Support patch and without AUTOIDLE bit set so please hold on this patch
For now. I will do further testing and let you know.

-Ajay 
> 
> Regards,
> Ajay
> >
> > Kevin
> >
> >
> > > Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
> > >
> > > ---
> > >  arch/arm/mach-omap2/pm34xx.c |    7 ++++++-
> > >  1 files changed, 6 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-
> omap2/pm34xx.c
> > > index ea0000b..cc9d566 100644
> > > --- a/arch/arm/mach-omap2/pm34xx.c
> > > +++ b/arch/arm/mach-omap2/pm34xx.c
> > > @@ -849,7 +849,12 @@ static void __init prcm_setup_regs(void)
> > >  			CM_AUTOIDLE);
> > >  	}
> > >
> > > -	omap_ctrl_writel(OMAP3430_AUTOIDLE, OMAP2_CONTROL_SYSCONFIG);
> > > +	/*
> > > +	 * MUSB interface on AM35x stops working when we enable AUTOIDLE,
> > > +	 * so avoid this for AM3517 and AM3505 device.
> > > +	 */
> > > +	if (!cpu_is_omap3517() && !cpu_is_omap3505())
> > > +		omap_ctrl_writel(OMAP3430_AUTOIDLE, OMAP2_CONTROL_SYSCONFIG);
> > >
> > >  	/*
> > >  	 * Set all plls to autoidle. This is needed until autoidle is
> > > --
> > > 1.6.2.4
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html