Re: Upcoming merge window and omap NAND patches

[Artem Bityutskiy <Artem.Bityutskiy@nokia.com>]

On Wed, 2010-05-05 at 00:08 +0200, ext Tony Lindgren wrote:
> Hi all,
> 
> There are several omap NAND patches pending, but some basic things
> should be fixed first.
> 
> 1. The NAND driver needs to stop tinkering with the GPMC registers
> 
> The omap General Purpose Memory Controller (GPMC) registers are omap
> specific, and not driver specific. Tinkering with these registers
> can cause issues with the other devices on the GPMC.
> 
> To find out what needs to disappear fomr the NAND driver, just do:
> 
> $ grep baseaddr drivers/mtd/nand/omap2.c
> 
> Any GPMC register tinkering needs to happen in arch/arm/mach-omap2/gpmc.c.
> If there are not currently GPMC functions to do something in gpmc.c, then
> let's add the necessary support there.
> 
> 2. Passing hardcoded GPMC_CS0_BASE needs to go from the board files
> 
> Passing hardcoded GPMC virtual addressess is sure way to mess up
> things. This should all become unnecessary once the NAND drivers
> stops messing with the GPMC registers directly.
> 
> So, as a result, I'm not planning on pushing any omap NAND related
> patches until these basic issues are fixed. I'll mark these patches
> as "Changes requested" in patchwork.kernel.org even if these patches
> don't have anything else wrong with them.
> 
> Let's fix the basic things for good, and put the other patches on
> hold for a while. Sorry if this causes problems!

Hi,

fair enough. I guess Vimal should address this, as he seems to be the TI
mr. NAND, right? :-)

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html