From: Ohad Ben-Cohen <ohad@wizery.com>
To: linux-omap@vger.kernel.org
Cc: Kanigeri Hari <h-kanigeri2@ti.com>,
Hiroshi Doyu <Hiroshi.DOYU@nokia.com>,
Ohad Ben-Cohen <ohad@wizery.com>
Subject: [PATCH v3 3/4] omap: mailbox: remove (un)likely macros from cold paths
Date: Wed, 5 May 2010 18:33:08 +0300 [thread overview]
Message-ID: <1273073589-2485-4-git-send-email-ohad@wizery.com> (raw)
In-Reply-To: <1273073589-2485-1-git-send-email-ohad@wizery.com>
Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
---
If you want, you can also reach me at < ohadb at ti dot com >.
arch/arm/plat-omap/mailbox.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm/plat-omap/mailbox.c b/arch/arm/plat-omap/mailbox.c
index 5140efc..7c60550 100644
--- a/arch/arm/plat-omap/mailbox.c
+++ b/arch/arm/plat-omap/mailbox.c
@@ -248,12 +248,12 @@ static int omap_mbox_startup(struct omap_mbox *mbox)
int ret = 0;
struct omap_mbox_queue *mq;
- if (likely(mbox->ops->startup)) {
+ if (mbox->ops->startup) {
spin_lock(&mboxes_lock);
if (!mbox_configured)
ret = mbox->ops->startup(mbox);
- if (unlikely(ret)) {
+ if (ret) {
spin_unlock(&mboxes_lock);
return ret;
}
@@ -263,7 +263,7 @@ static int omap_mbox_startup(struct omap_mbox *mbox)
ret = request_irq(mbox->irq, mbox_interrupt, IRQF_SHARED,
mbox->name, mbox);
- if (unlikely(ret)) {
+ if (ret) {
printk(KERN_ERR
"failed to register mailbox interrupt:%d\n", ret);
goto fail_request_irq;
@@ -290,7 +290,7 @@ static int omap_mbox_startup(struct omap_mbox *mbox)
fail_alloc_txq:
free_irq(mbox->irq, mbox);
fail_request_irq:
- if (unlikely(mbox->ops->shutdown))
+ if (mbox->ops->shutdown)
mbox->ops->shutdown(mbox);
return ret;
@@ -303,7 +303,7 @@ static void omap_mbox_fini(struct omap_mbox *mbox)
free_irq(mbox->irq, mbox);
- if (unlikely(mbox->ops->shutdown)) {
+ if (mbox->ops->shutdown) {
spin_lock(&mboxes_lock);
if (mbox_configured > 0)
mbox_configured--;
--
1.6.3.3
next prev parent reply other threads:[~2010-05-05 15:33 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 15:33 [PATCH v3 0/4] omap: mailbox: cleanup & simplify Ohad Ben-Cohen
2010-05-05 15:33 ` [PATCH v3 1/4] omap: mailbox: convert rwlocks to spinlock Ohad Ben-Cohen
2010-05-05 15:33 ` [PATCH v3 2/4] omap: mailbox cleanup: split MODULE_AUTHOR line Ohad Ben-Cohen
2010-05-05 15:33 ` Ohad Ben-Cohen [this message]
2010-05-05 15:33 ` [PATCH v3 4/4] omap: mailbox: convert block api to kfifo Ohad Ben-Cohen
2010-06-07 18:52 ` Deepak Chitriki
2010-06-07 21:40 ` Ohad Ben-Cohen
2010-06-07 23:14 ` Guzman Lugo, Fernando
2010-06-08 2:54 ` Ohad Ben-Cohen
2010-06-09 5:07 ` Hiroshi DOYU
2010-06-09 5:16 ` Guzman Lugo, Fernando
2010-06-13 23:52 ` Ohad Ben-Cohen
2010-06-14 8:58 ` Hiroshi DOYU
2010-06-14 15:56 ` C.A, Subramaniam
2010-06-15 4:48 ` Ohad Ben-Cohen
2010-06-15 7:04 ` Hiroshi DOYU
2010-06-14 17:44 ` Sapiens, Rene
2010-06-14 17:47 ` Felipe Contreras
2010-06-15 4:43 ` Ohad Ben-Cohen
2010-06-15 8:04 ` Hiroshi DOYU
2010-06-16 5:09 ` Ohad Ben-Cohen
2010-06-16 5:50 ` Hiroshi DOYU
2010-06-23 0:29 ` Ohad Ben-Cohen
2010-07-02 12:08 ` Hiroshi DOYU
2010-06-08 3:46 ` Hiroshi DOYU
2010-06-08 9:43 ` Felipe Contreras
2010-06-08 9:55 ` Hiroshi DOYU
2010-06-08 18:49 ` Guzman Lugo, Fernando
2010-06-07 23:27 ` Deepak Chitriki
2010-06-08 3:11 ` Ohad Ben-Cohen
2010-06-08 3:55 ` Hiroshi DOYU
2010-06-08 9:51 ` Felipe Contreras
2010-06-08 3:40 ` Hiroshi DOYU
2010-06-08 17:02 ` Guzman Lugo, Fernando
2010-05-06 5:20 ` [PATCH v3 0/4] omap: mailbox: cleanup & simplify Hiroshi DOYU
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273073589-2485-4-git-send-email-ohad@wizery.com \
--to=ohad@wizery.com \
--cc=Hiroshi.DOYU@nokia.com \
--cc=h-kanigeri2@ti.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).