From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liam Girdwood Subject: Re: [PATCH 2/4] OMAP: mcbsp - add smart idle configuration API Date: Wed, 19 May 2010 11:43:28 +0100 Message-ID: <1274265808.3240.101.camel@odin> References: <1274213594-26554-1-git-send-email-lrg@slimlogic.co.uk> <1274213594-26554-3-git-send-email-lrg@slimlogic.co.uk> <87tyq4lspw.fsf@deeprootsystems.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <87tyq4lspw.fsf@deeprootsystems.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Kevin Hilman Cc: Tony Lindgren , alsa-devel@alsa-project.org, linux-omap@vger.kernel.org, Peter Ujfalusi , Mark Brown List-Id: linux-omap@vger.kernel.org On Tue, 2010-05-18 at 16:01 -0700, Kevin Hilman wrote: > Liam Girdwood writes: > > > Add a small API to configure McBSP smart idle modes > > to conserve power. > > Would be useful here to explain why client drivers need to change > idle modes. > I think Peter has covered this in one of his replies. > Also, this patch is telling me that it's time the McBSP is converted > over to the omap_hwmod/omap_device infrastructure where this type > of functionality would already be provided. > > Not necesssarily a reason to prevent this patch for now, but this > will all need to be changed when converted to hwmod. Ok, I think I'll actually just convert it to hwmod rather than adding a soon to be deprecated API. Thanks Liam -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk