From: Liam Girdwood <lrg@slimlogic.co.uk>
To: eduardo.valentin@nokia.com
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
"Ujfalusi Peter (Nokia-D/Tampere)" <peter.ujfalusi@nokia.com>,
Jarkko Nikula <jhnikula@gmail.com>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH 1/4] OMAP: mcbsp - add omap_mcbsp_set_dma_op_mode()
Date: Wed, 19 May 2010 12:30:36 +0100 [thread overview]
Message-ID: <1274268636.3240.146.camel@odin> (raw)
In-Reply-To: <20100519105056.GK4265@besouro.research.nokia.com>
On Wed, 2010-05-19 at 13:50 +0300, Eduardo Valentin wrote:
> On Tue, May 18, 2010 at 10:13:11PM +0200, Liam Girdwood wrote:
> > This adds a method to set the MCBSP DMA OP mode.
>
> OK. good. But again, why do you need set dma op mode other than inside mcbsp code?
>
I think Peter has answered this.
> Right, so, from what I have read briefly, the idea is to remove the user space ability to set the mode and
> let mcbsp clients to do it. What is not clear to me is how mcbsp clients (inside kernel) will determine if they want
> short delay or pm friendly. That usually is bound to upper use case though.
>
An example would be an ASoC client. The ASoC driver would be configured
either for low latency, low power, etc. by userspace (using formal ALSA
calls) and would be able to configure the mcbsp to match this request.
> It would be really nice if you improve your patch descriptions.
Sorry, I thought again this was obvious.
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2010-05-19 11:30 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-18 20:13 [PATCH 0/4] McBSP smart idle and DMA op mode updates for ASoC Liam Girdwood
2010-05-18 20:13 ` [PATCH 1/4] OMAP: mcbsp - add omap_mcbsp_set_dma_op_mode() Liam Girdwood
2010-05-19 6:13 ` Jarkko Nikula
2010-05-19 10:50 ` Eduardo Valentin
2010-05-19 11:30 ` Liam Girdwood [this message]
2010-05-18 20:13 ` [PATCH 2/4] OMAP: mcbsp - add smart idle configuration API Liam Girdwood
2010-05-18 20:42 ` Nishanth Menon
2010-05-18 23:01 ` [alsa-devel] " Kevin Hilman
2010-05-19 10:43 ` Liam Girdwood
2010-05-19 12:15 ` Peter Ujfalusi
2010-05-19 15:33 ` Kevin Hilman
2010-05-19 5:22 ` Jarkko Nikula
2010-05-19 10:46 ` Eduardo Valentin
2010-05-19 11:21 ` [alsa-devel] " Liam Girdwood
2010-05-19 11:31 ` Eduardo Valentin
2010-05-18 20:13 ` [PATCH 3/4] ASoC: mcbsp - add machine threshold callback Liam Girdwood
2010-05-18 20:38 ` Mark Brown
2010-05-18 20:56 ` Candelaria Villarreal, Jorge
2010-05-19 5:45 ` Jarkko Nikula
2010-05-19 9:37 ` [alsa-devel] " Liam Girdwood
2010-05-18 20:13 ` [PATCH 4/4] OMAP: mcbsp - remove sysfs set for DMA op mode Liam Girdwood
2010-05-19 5:13 ` [PATCH 0/4] McBSP smart idle and DMA op mode updates for ASoC Jarkko Nikula
2010-05-19 8:31 ` Peter Ujfalusi
2010-05-19 8:37 ` Peter Ujfalusi
2010-05-19 10:52 ` Eduardo Valentin
2010-05-19 11:36 ` Peter Ujfalusi
2010-05-19 11:46 ` Eduardo Valentin
2010-05-19 12:09 ` Peter Ujfalusi
2010-05-19 10:42 ` Eduardo Valentin
2010-05-19 11:07 ` Liam Girdwood
2010-05-19 11:28 ` Eduardo Valentin
2010-05-19 12:27 ` Peter Ujfalusi
2010-05-19 14:50 ` Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274268636.3240.146.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=eduardo.valentin@nokia.com \
--cc=jhnikula@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@nokia.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox