From: Kevin Hilman <khilman@deeprootsystems.com>
To: linux-omap@vger.kernel.org
Subject: [PATCH] OMAP: hwmod: if IDLEST fields are not set, use module defaults
Date: Thu, 20 May 2010 16:59:30 -0700 [thread overview]
Message-ID: <1274399970-21732-2-git-send-email-khilman@deeprootsystems.com> (raw)
In-Reply-To: <1274399970-21732-1-git-send-email-khilman@deeprootsystems.com>
In the _setup() hook, check for valid IDLEST fields. If not set, use
the module defaults since they are the same as the module defaults
for most hwmods.
Problem found because _wait_target_ready() will fail if IDLEST
fields are not valid.
Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
---
RFC: is this an OK solution, or is the preferred solution to ensure
that all the hwmod data is filled with valid fields.
arch/arm/mach-omap2/omap_hwmod.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
index a127c9b..77fef90 100644
--- a/arch/arm/mach-omap2/omap_hwmod.c
+++ b/arch/arm/mach-omap2/omap_hwmod.c
@@ -1036,6 +1036,12 @@ static int _setup(struct omap_hwmod *oh)
oh->_state = _HWMOD_STATE_INITIALIZED;
+ /* if IDLEST values are not set, use module defaults */
+ if (!oh->prcm.omap2.idlest_reg_id)
+ oh->prcm.omap2.idlest_reg_id = oh->prcm.omap2.prcm_reg_id;
+ if (!oh->prcm.omap2.idlest_idle_bit)
+ oh->prcm.omap2.idlest_idle_bit = oh->prcm.omap2.module_bit;
+
r = _enable(oh);
if (r) {
pr_warning("omap_hwmod: %s: cannot be enabled (%d)\n",
--
1.7.0.2
prev parent reply other threads:[~2010-05-20 23:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-20 23:59 [PATCH] OMAP: hwmod: allow idle after HWMOD_INIT_NO_IDLE Kevin Hilman
2010-05-20 23:59 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274399970-21732-2-git-send-email-khilman@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).