From: Nishanth Menon <nm@ti.com>
Cc: Nishanth Menon <nm@ti.com>, Tony Lindgren <tony@atomide.com>,
Angelo Arrifano <miknix@gmail.com>,
"Zebediah C. McClure" <zmc@lurian.net>,
Alistair Buxton <a.j.buxton@gmail.com>,
Paul Walmsley <paul@pwsan.com>, Sanjeev Premi <premi@ti.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Senthilvadivu Gurusamy <svadivu@ti.com>,
Kevin Hilman <khilman@deeprootsystems.com>,
Tomi Valkeinen <tomi.valkeinen@nokia.com>,
Aaro Koskinen <aaro.koskinen@nokia.com>,
Vikram Pandita <vikram.pandita@ti.com>,
Vishwanath S <vishwa.s@ti.com>,
linux-omap@vger.kernel.org
Subject: [PATCH 2/6] omap2/3: id: fix sparse warning
Date: Sat, 22 May 2010 22:36:35 -0500 [thread overview]
Message-ID: <1274585799-16226-3-git-send-email-nm@ti.com> (raw)
In-Reply-To: <1274585799-16226-2-git-send-email-nm@ti.com>
omap24xx_check_revision, omap3_check_features,
omap3_check_revision, omap4_check_revision, omap3_cpuinfo
are not used elsewhere, it should be static
Also fixes the following sparse warnings:
arch/arm/mach-omap2/id.c:105:13: warning: symbol 'omap24xx_check_revision' was not declared. Should it be static?
arch/arm/mach-omap2/id.c:167:13: warning: symbol 'omap3_check_features' was not declared. Should it be static?
arch/arm/mach-omap2/id.c:189:13: warning: symbol 'omap3_check_revision' was not declared. Should it be static?
arch/arm/mach-omap2/id.c:270:13: warning: symbol 'omap4_check_revision' was not declared. Should it be static?
arch/arm/mach-omap2/id.c:300:13: warning: symbol 'omap3_cpuinfo' was not declared. Should it be static?
Cc: Tony Lindgren <tony@atomide.com>
Cc: Angelo Arrifano <miknix@gmail.com>
Cc: "Zebediah C. McClure" <zmc@lurian.net>
Cc: Alistair Buxton <a.j.buxton@gmail.com>
Cc: Paul Walmsley <paul@pwsan.com>
Cc: Sanjeev Premi <premi@ti.com>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Senthilvadivu Gurusamy <svadivu@ti.com>
Cc: Kevin Hilman <khilman@deeprootsystems.com>
Cc: Tomi Valkeinen <tomi.valkeinen@nokia.com>
Cc: Aaro Koskinen <aaro.koskinen@nokia.com>
Cc: Vikram Pandita <vikram.pandita@ti.com>
Cc: Vishwanath S <vishwa.s@ti.com>
Cc: linux-omap@vger.kernel.org
Signed-off-by: Nishanth Menon <nm@ti.com>
---
arch/arm/mach-omap2/id.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
index 37b8a1a..c7bf0e1 100644
--- a/arch/arm/mach-omap2/id.c
+++ b/arch/arm/mach-omap2/id.c
@@ -102,7 +102,7 @@ static struct omap_id omap_ids[] __initdata = {
static void __iomem *tap_base;
static u16 tap_prod_id;
-void __init omap24xx_check_revision(void)
+static void __init omap24xx_check_revision(void)
{
int i, j;
u32 idcode, prod_id;
@@ -164,7 +164,7 @@ void __init omap24xx_check_revision(void)
omap3_features |= OMAP3_HAS_ ##feat; \
}
-void __init omap3_check_features(void)
+static void __init omap3_check_features(void)
{
u32 status;
@@ -186,7 +186,7 @@ void __init omap3_check_features(void)
*/
}
-void __init omap3_check_revision(void)
+static void __init omap3_check_revision(void)
{
u32 cpuid, idcode;
u16 hawkeye;
@@ -267,7 +267,7 @@ void __init omap3_check_revision(void)
}
}
-void __init omap4_check_revision(void)
+static void __init omap4_check_revision(void)
{
u32 idcode;
u16 hawkeye;
@@ -297,7 +297,7 @@ void __init omap4_check_revision(void)
if (omap3_has_ ##feat()) \
printk(#feat" ");
-void __init omap3_cpuinfo(void)
+static void __init omap3_cpuinfo(void)
{
u8 rev = GET_OMAP_REVISION();
char cpu_name[16], cpu_rev[16];
--
1.6.3.3
next prev parent reply other threads:[~2010-05-23 3:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-23 3:36 [PATCH 0/6] introduce generic OMAP SOC features Nishanth Menon
2010-05-23 3:36 ` [PATCH 1/6] omap1: rename check_revision Nishanth Menon
2010-05-23 3:36 ` Nishanth Menon [this message]
2010-05-23 3:36 ` [PATCH 3/6] omap: generic: introduce a single check_revision Nishanth Menon
2010-05-23 3:36 ` [PATCH 4/6] omap: improve OMAP3_HAS_FEATURE Nishanth Menon
2010-05-23 3:36 ` [PATCH 5/6] omap: introduce OMAP_SHOW_FEATURE Nishanth Menon
2010-05-23 3:36 ` [PATCH 6/6] omap: move generic omap3 features to generic Nishanth Menon
2010-05-27 11:24 ` Venkatraman S
2010-05-27 16:21 ` Nishanth Menon
2010-05-31 16:06 ` Venkatraman S
2010-05-31 17:09 ` Nishanth Menon
2010-05-31 18:46 ` Venkatraman S
2010-05-31 19:18 ` Nishanth Menon
2010-06-01 5:34 ` Venkatraman S
2010-06-01 6:23 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274585799-16226-3-git-send-email-nm@ti.com \
--to=nm@ti.com \
--cc=a.j.buxton@gmail.com \
--cc=aaro.koskinen@nokia.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=miknix@gmail.com \
--cc=paul@pwsan.com \
--cc=premi@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=svadivu@ti.com \
--cc=tomi.valkeinen@nokia.com \
--cc=tony@atomide.com \
--cc=vikram.pandita@ti.com \
--cc=vishwa.s@ti.com \
--cc=zmc@lurian.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).