From: Vishwanath BS <vishwanath.bs@ti.com>
To: linux-omap@vger.kernel.org
Cc: Vishwanath BS <vishwanath.bs@ti.com>
Subject: [PATCH] OMAP3 PM: Prevent Core off when DPLL3 autoidle is disabled
Date: Fri, 28 May 2010 20:04:29 +0530 [thread overview]
Message-ID: <1275057269-15863-1-git-send-email-vishwanath.bs@ti.com> (raw)
In-Reply-To: <>
As per errata i580, Core should not attempt to goto OSWR/OFF state if
DPLL3 is in manual lock mode (CM_AUTOIDLE_PLL[AUTO_CORE_DPLL] = 0).
This WA is applicable only if WA for errata i581 is applied since DPLL3
is put in manual lock mode as part of the i581 errata.
This patch has been developed on top of i581 errata WA available@
https://patchwork.kernel.org/patch/102673/
Tested on OMAP3630 ZOOM3.
Signed-off-by: Vishwanath BS <vishwanath.bs@ti.com>
---
diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
index b0a5d09..5b48b6c
--- a/arch/arm/mach-omap2/pm34xx.c
+++ b/arch/arm/mach-omap2/pm34xx.c
@@ -461,6 +461,9 @@ void omap_sram_idle(void)
}
cm_rmw_mod_reg_bits(OMAP3430_AUTO_CORE_DPLL_MASK,
0x1, PLL_MOD, CM_AUTOIDLE);
+ } else if (core_next_state > PWRDM_POWER_RET) {
+ pwrdm_set_next_pwrst(core_pwrdm, PWRDM_POWER_RET);
+ core_next_state = PWRDM_POWER_RET;
}
}
}
reply other threads:[~2010-05-28 14:33 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275057269-15863-1-git-send-email-vishwanath.bs@ti.com \
--to=vishwanath.bs@ti.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).