From: Cory Maccarrone <darkstar6262@gmail.com>
To: linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org
Cc: akpm@linux-foundation.org, Cory Maccarrone <darkstar6262@gmail.com>
Subject: [PATCH] [MMC] omap: Remove BUG_ON for disabled interrupts
Date: Sat, 29 May 2010 19:27:23 -0700 [thread overview]
Message-ID: <1275186443-8242-1-git-send-email-darkstar6262@gmail.com> (raw)
This change removes a BUG_ON for when interrupts are disabled
during an MMC request. During boot, interrupts can be disabled
when a request is made, causing this bug to be triggered. In reality,
there's no reason this should halt the kernel, as the driver has proved
reliable in spite of disabled interrupts, and additionally, there's
nothing in this code that would require interrupts to be enabled.
Signed-off-by: Cory Maccarrone <darkstar6262@gmail.com>
---
drivers/mmc/host/omap.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c
index 2b28168..d98ddcf 100644
--- a/drivers/mmc/host/omap.c
+++ b/drivers/mmc/host/omap.c
@@ -1157,7 +1157,6 @@ static void mmc_omap_start_request(struct mmc_omap_host *host,
mmc_omap_start_command(host, req->cmd);
if (host->dma_in_use)
omap_start_dma(host->dma_ch);
- BUG_ON(irqs_disabled());
}
static void mmc_omap_request(struct mmc_host *mmc, struct mmc_request *req)
--
1.7.0.4
next reply other threads:[~2010-05-30 2:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-30 2:27 Cory Maccarrone [this message]
2010-05-31 13:37 ` [PATCH] [MMC] omap: Remove BUG_ON for disabled interrupts Tony Lindgren
2010-06-02 21:05 ` Andrew Morton
2010-06-02 22:26 ` Cory Maccarrone
2010-06-02 23:30 ` Andrew Morton
2010-06-03 0:05 ` Cory Maccarrone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275186443-8242-1-git-send-email-darkstar6262@gmail.com \
--to=darkstar6262@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).