* [PATCH] OMAP: GPIO: fix auto-disable of debounce clock
@ 2010-06-02 15:22 Kevin Hilman
2010-06-07 12:04 ` [APPLIED] " Tony Lindgren
2010-06-07 12:08 ` Felipe Balbi
0 siblings, 2 replies; 3+ messages in thread
From: Kevin Hilman @ 2010-06-02 15:22 UTC (permalink / raw)
To: linux-omap; +Cc: Felipe Balbi
The addition of the new debounce code (commit
168ef3d9a56bd8bffe0ef4189c450888b4aefefe) broke the auto-disable of
debounce clocks on idle by forgetting to update the debounce clock
enable mask.
Add back the updating of bank->dbck_enable_mask so debounce clocks are
auto-disabled.
Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
---
Please include for 2.6.35-rc series.
arch/arm/plat-omap/gpio.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c
index 393e921..9b7e354 100644
--- a/arch/arm/plat-omap/gpio.c
+++ b/arch/arm/plat-omap/gpio.c
@@ -673,6 +673,7 @@ static void _set_gpio_debounce(struct gpio_bank *bank, unsigned gpio,
if (cpu_is_omap34xx() || cpu_is_omap44xx())
clk_disable(bank->dbck);
}
+ bank->dbck_enable_mask = val;
__raw_writel(val, reg);
}
--
1.7.0.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [APPLIED] [PATCH] OMAP: GPIO: fix auto-disable of debounce clock
2010-06-02 15:22 [PATCH] OMAP: GPIO: fix auto-disable of debounce clock Kevin Hilman
@ 2010-06-07 12:04 ` Tony Lindgren
2010-06-07 12:08 ` Felipe Balbi
1 sibling, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2010-06-07 12:04 UTC (permalink / raw)
To: linux-omap
This patch has been applied to the linux-omap
by youw fwiendly patch wobot.
Branch in linux-omap: omap-fixes
Initial commit ID (Likely to change): 0b703473c328c991acf2366f4ebefc8d38884799
PatchWorks
http://patchwork.kernel.org/patch/103831/
Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=0b703473c328c991acf2366f4ebefc8d38884799
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] OMAP: GPIO: fix auto-disable of debounce clock
2010-06-02 15:22 [PATCH] OMAP: GPIO: fix auto-disable of debounce clock Kevin Hilman
2010-06-07 12:04 ` [APPLIED] " Tony Lindgren
@ 2010-06-07 12:08 ` Felipe Balbi
1 sibling, 0 replies; 3+ messages in thread
From: Felipe Balbi @ 2010-06-07 12:08 UTC (permalink / raw)
To: ext Kevin Hilman
Cc: linux-omap@vger.kernel.org, Balbi Felipe (Nokia-D/Helsinki)
On Wed, Jun 02, 2010 at 05:22:29PM +0200, ext Kevin Hilman wrote:
>The addition of the new debounce code (commit
>168ef3d9a56bd8bffe0ef4189c450888b4aefefe) broke the auto-disable of
>debounce clocks on idle by forgetting to update the debounce clock
>enable mask.
>
>Add back the updating of bank->dbck_enable_mask so debounce clocks are
>auto-disabled.
>
>Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
>---
>Please include for 2.6.35-rc series.
oops, my bad :-(
--
balbi
DefectiveByDesign.org
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-06-07 12:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-02 15:22 [PATCH] OMAP: GPIO: fix auto-disable of debounce clock Kevin Hilman
2010-06-07 12:04 ` [APPLIED] " Tony Lindgren
2010-06-07 12:08 ` Felipe Balbi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).