* [PATCH] spi: omap2_mcspi: make use of dev_vdbg()
@ 2010-06-03 11:09 felipe.balbi
2010-08-09 10:36 ` Felipe Balbi
0 siblings, 1 reply; 9+ messages in thread
From: felipe.balbi @ 2010-06-03 11:09 UTC (permalink / raw)
To: linux-kernel
Cc: Linux OMAP Mailing List, Tony Lindgren, Roman Tereshonkov,
Andrew Morton, David Brownell, Grant Likely, Felipe Balbi
From: Felipe Balbi <felipe.balbi@nokia.com>
dev_vdbg() is only compiled when VERBOSE is defined, so
there's no need to wrap dev_dbg() on #ifdef VERBOSE .. #endif
as we can use dev_vdbg() directly.
Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
---
drivers/spi/omap2_mcspi.c | 36 +++++++++---------------------------
1 files changed, 9 insertions(+), 27 deletions(-)
diff --git a/drivers/spi/omap2_mcspi.c b/drivers/spi/omap2_mcspi.c
index b3a94ca..d703927 100644
--- a/drivers/spi/omap2_mcspi.c
+++ b/drivers/spi/omap2_mcspi.c
@@ -489,10 +489,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)
dev_err(&spi->dev, "TXS timed out\n");
goto out;
}
-#ifdef VERBOSE
- dev_dbg(&spi->dev, "write-%d %02x\n",
+ dev_vdbg(&spi->dev, "write-%d %02x\n",
word_len, *tx);
-#endif
__raw_writel(*tx++, tx_reg);
}
if (rx != NULL) {
@@ -506,10 +504,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)
(l & OMAP2_MCSPI_CHCONF_TURBO)) {
omap2_mcspi_set_enable(spi, 0);
*rx++ = __raw_readl(rx_reg);
-#ifdef VERBOSE
- dev_dbg(&spi->dev, "read-%d %02x\n",
+ dev_vdbg(&spi->dev, "read-%d %02x\n",
word_len, *(rx - 1));
-#endif
if (mcspi_wait_for_reg_bit(chstat_reg,
OMAP2_MCSPI_CHSTAT_RXS) < 0) {
dev_err(&spi->dev,
@@ -522,10 +518,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)
}
*rx++ = __raw_readl(rx_reg);
-#ifdef VERBOSE
- dev_dbg(&spi->dev, "read-%d %02x\n",
+ dev_vdbg(&spi->dev, "read-%d %02x\n",
word_len, *(rx - 1));
-#endif
}
} while (c);
} else if (word_len <= 16) {
@@ -542,10 +536,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)
dev_err(&spi->dev, "TXS timed out\n");
goto out;
}
-#ifdef VERBOSE
- dev_dbg(&spi->dev, "write-%d %04x\n",
+ dev_vdbg(&spi->dev, "write-%d %04x\n",
word_len, *tx);
-#endif
__raw_writel(*tx++, tx_reg);
}
if (rx != NULL) {
@@ -559,10 +551,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)
(l & OMAP2_MCSPI_CHCONF_TURBO)) {
omap2_mcspi_set_enable(spi, 0);
*rx++ = __raw_readl(rx_reg);
-#ifdef VERBOSE
- dev_dbg(&spi->dev, "read-%d %04x\n",
+ dev_vdbg(&spi->dev, "read-%d %04x\n",
word_len, *(rx - 1));
-#endif
if (mcspi_wait_for_reg_bit(chstat_reg,
OMAP2_MCSPI_CHSTAT_RXS) < 0) {
dev_err(&spi->dev,
@@ -575,10 +565,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)
}
*rx++ = __raw_readl(rx_reg);
-#ifdef VERBOSE
- dev_dbg(&spi->dev, "read-%d %04x\n",
+ dev_vdbg(&spi->dev, "read-%d %04x\n",
word_len, *(rx - 1));
-#endif
}
} while (c);
} else if (word_len <= 32) {
@@ -595,10 +583,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)
dev_err(&spi->dev, "TXS timed out\n");
goto out;
}
-#ifdef VERBOSE
- dev_dbg(&spi->dev, "write-%d %08x\n",
+ dev_vdbg(&spi->dev, "write-%d %08x\n",
word_len, *tx);
-#endif
__raw_writel(*tx++, tx_reg);
}
if (rx != NULL) {
@@ -612,10 +598,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)
(l & OMAP2_MCSPI_CHCONF_TURBO)) {
omap2_mcspi_set_enable(spi, 0);
*rx++ = __raw_readl(rx_reg);
-#ifdef VERBOSE
- dev_dbg(&spi->dev, "read-%d %08x\n",
+ dev_vdbg(&spi->dev, "read-%d %08x\n",
word_len, *(rx - 1));
-#endif
if (mcspi_wait_for_reg_bit(chstat_reg,
OMAP2_MCSPI_CHSTAT_RXS) < 0) {
dev_err(&spi->dev,
@@ -628,10 +612,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)
}
*rx++ = __raw_readl(rx_reg);
-#ifdef VERBOSE
- dev_dbg(&spi->dev, "read-%d %08x\n",
+ dev_vdbg(&spi->dev, "read-%d %08x\n",
word_len, *(rx - 1));
-#endif
}
} while (c);
}
--
1.7.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] spi: omap2_mcspi: make use of dev_vdbg()
2010-06-03 11:09 [PATCH] spi: omap2_mcspi: make use of dev_vdbg() felipe.balbi
@ 2010-08-09 10:36 ` Felipe Balbi
2010-08-09 13:22 ` Grant Likely
2010-08-10 6:33 ` Grant Likely
0 siblings, 2 replies; 9+ messages in thread
From: Felipe Balbi @ 2010-08-09 10:36 UTC (permalink / raw)
To: Balbi Felipe (Nokia-D/Helsinki)
Cc: linux-kernel@vger.kernel.org, Linux OMAP Mailing List,
Tony Lindgren, Tereshonkov Roman (Nokia-D/Helsinki),
Andrew Morton, David Brownell, Grant Likely
On Thu, Jun 03, 2010 at 01:09:01PM +0200, Balbi Felipe (Nokia-D/Helsinki) wrote:
>From: Felipe Balbi <felipe.balbi@nokia.com>
>
>dev_vdbg() is only compiled when VERBOSE is defined, so
>there's no need to wrap dev_dbg() on #ifdef VERBOSE .. #endif
>as we can use dev_vdbg() directly.
>
>Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
>---
ping, any comments to this one ? It's been pending for quite a long
time.
> drivers/spi/omap2_mcspi.c | 36 +++++++++---------------------------
> 1 files changed, 9 insertions(+), 27 deletions(-)
>
>diff --git a/drivers/spi/omap2_mcspi.c b/drivers/spi/omap2_mcspi.c
>index b3a94ca..d703927 100644
>--- a/drivers/spi/omap2_mcspi.c
>+++ b/drivers/spi/omap2_mcspi.c
>@@ -489,10 +489,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)
> dev_err(&spi->dev, "TXS timed out\n");
> goto out;
> }
>-#ifdef VERBOSE
>- dev_dbg(&spi->dev, "write-%d %02x\n",
>+ dev_vdbg(&spi->dev, "write-%d %02x\n",
> word_len, *tx);
>-#endif
> __raw_writel(*tx++, tx_reg);
> }
> if (rx != NULL) {
>@@ -506,10 +504,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)
> (l & OMAP2_MCSPI_CHCONF_TURBO)) {
> omap2_mcspi_set_enable(spi, 0);
> *rx++ = __raw_readl(rx_reg);
>-#ifdef VERBOSE
>- dev_dbg(&spi->dev, "read-%d %02x\n",
>+ dev_vdbg(&spi->dev, "read-%d %02x\n",
> word_len, *(rx - 1));
>-#endif
> if (mcspi_wait_for_reg_bit(chstat_reg,
> OMAP2_MCSPI_CHSTAT_RXS) < 0) {
> dev_err(&spi->dev,
>@@ -522,10 +518,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)
> }
>
> *rx++ = __raw_readl(rx_reg);
>-#ifdef VERBOSE
>- dev_dbg(&spi->dev, "read-%d %02x\n",
>+ dev_vdbg(&spi->dev, "read-%d %02x\n",
> word_len, *(rx - 1));
>-#endif
> }
> } while (c);
> } else if (word_len <= 16) {
>@@ -542,10 +536,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)
> dev_err(&spi->dev, "TXS timed out\n");
> goto out;
> }
>-#ifdef VERBOSE
>- dev_dbg(&spi->dev, "write-%d %04x\n",
>+ dev_vdbg(&spi->dev, "write-%d %04x\n",
> word_len, *tx);
>-#endif
> __raw_writel(*tx++, tx_reg);
> }
> if (rx != NULL) {
>@@ -559,10 +551,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)
> (l & OMAP2_MCSPI_CHCONF_TURBO)) {
> omap2_mcspi_set_enable(spi, 0);
> *rx++ = __raw_readl(rx_reg);
>-#ifdef VERBOSE
>- dev_dbg(&spi->dev, "read-%d %04x\n",
>+ dev_vdbg(&spi->dev, "read-%d %04x\n",
> word_len, *(rx - 1));
>-#endif
> if (mcspi_wait_for_reg_bit(chstat_reg,
> OMAP2_MCSPI_CHSTAT_RXS) < 0) {
> dev_err(&spi->dev,
>@@ -575,10 +565,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)
> }
>
> *rx++ = __raw_readl(rx_reg);
>-#ifdef VERBOSE
>- dev_dbg(&spi->dev, "read-%d %04x\n",
>+ dev_vdbg(&spi->dev, "read-%d %04x\n",
> word_len, *(rx - 1));
>-#endif
> }
> } while (c);
> } else if (word_len <= 32) {
>@@ -595,10 +583,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)
> dev_err(&spi->dev, "TXS timed out\n");
> goto out;
> }
>-#ifdef VERBOSE
>- dev_dbg(&spi->dev, "write-%d %08x\n",
>+ dev_vdbg(&spi->dev, "write-%d %08x\n",
> word_len, *tx);
>-#endif
> __raw_writel(*tx++, tx_reg);
> }
> if (rx != NULL) {
>@@ -612,10 +598,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)
> (l & OMAP2_MCSPI_CHCONF_TURBO)) {
> omap2_mcspi_set_enable(spi, 0);
> *rx++ = __raw_readl(rx_reg);
>-#ifdef VERBOSE
>- dev_dbg(&spi->dev, "read-%d %08x\n",
>+ dev_vdbg(&spi->dev, "read-%d %08x\n",
> word_len, *(rx - 1));
>-#endif
> if (mcspi_wait_for_reg_bit(chstat_reg,
> OMAP2_MCSPI_CHSTAT_RXS) < 0) {
> dev_err(&spi->dev,
>@@ -628,10 +612,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)
> }
>
> *rx++ = __raw_readl(rx_reg);
>-#ifdef VERBOSE
>- dev_dbg(&spi->dev, "read-%d %08x\n",
>+ dev_vdbg(&spi->dev, "read-%d %08x\n",
> word_len, *(rx - 1));
>-#endif
> }
> } while (c);
> }
>--
>1.7.1
--
balbi
DefectiveByDesign.org
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] spi: omap2_mcspi: make use of dev_vdbg()
2010-08-09 10:36 ` Felipe Balbi
@ 2010-08-09 13:22 ` Grant Likely
2010-08-10 5:21 ` Felipe Balbi
2010-08-10 6:33 ` Grant Likely
1 sibling, 1 reply; 9+ messages in thread
From: Grant Likely @ 2010-08-09 13:22 UTC (permalink / raw)
To: felipe.balbi
Cc: linux-kernel@vger.kernel.org, Linux OMAP Mailing List,
Tony Lindgren, Tereshonkov Roman (Nokia-D/Helsinki),
Andrew Morton, David Brownell
On Mon, Aug 9, 2010 at 4:36 AM, Felipe Balbi <felipe.balbi@nokia.com> wrote:
> On Thu, Jun 03, 2010 at 01:09:01PM +0200, Balbi Felipe (Nokia-D/Helsinki)
> wrote:
>>
>> From: Felipe Balbi <felipe.balbi@nokia.com>
>>
>> dev_vdbg() is only compiled when VERBOSE is defined, so
>> there's no need to wrap dev_dbg() on #ifdef VERBOSE .. #endif
>> as we can use dev_vdbg() directly.
>>
>> Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
>> ---
>
> ping, any comments to this one ? It's been pending for quite a long time.
It didn't get sent to the spi-devel-general list, so it didn't get
picked up by patchwork and wasn't there for me to pick up when I was
collecting stuff for .36.
g.
>
>> drivers/spi/omap2_mcspi.c | 36 +++++++++---------------------------
>> 1 files changed, 9 insertions(+), 27 deletions(-)
>>
>> diff --git a/drivers/spi/omap2_mcspi.c b/drivers/spi/omap2_mcspi.c
>> index b3a94ca..d703927 100644
>> --- a/drivers/spi/omap2_mcspi.c
>> +++ b/drivers/spi/omap2_mcspi.c
>> @@ -489,10 +489,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct
>> spi_transfer *xfer)
>> dev_err(&spi->dev, "TXS timed
>> out\n");
>> goto out;
>> }
>> -#ifdef VERBOSE
>> - dev_dbg(&spi->dev, "write-%d %02x\n",
>> + dev_vdbg(&spi->dev, "write-%d %02x\n",
>> word_len, *tx);
>> -#endif
>> __raw_writel(*tx++, tx_reg);
>> }
>> if (rx != NULL) {
>> @@ -506,10 +504,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct
>> spi_transfer *xfer)
>> (l & OMAP2_MCSPI_CHCONF_TURBO)) {
>> omap2_mcspi_set_enable(spi, 0);
>> *rx++ = __raw_readl(rx_reg);
>> -#ifdef VERBOSE
>> - dev_dbg(&spi->dev, "read-%d
>> %02x\n",
>> + dev_vdbg(&spi->dev, "read-%d
>> %02x\n",
>> word_len, *(rx - 1));
>> -#endif
>> if
>> (mcspi_wait_for_reg_bit(chstat_reg,
>> OMAP2_MCSPI_CHSTAT_RXS) <
>> 0) {
>> dev_err(&spi->dev,
>> @@ -522,10 +518,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct
>> spi_transfer *xfer)
>> }
>>
>> *rx++ = __raw_readl(rx_reg);
>> -#ifdef VERBOSE
>> - dev_dbg(&spi->dev, "read-%d %02x\n",
>> + dev_vdbg(&spi->dev, "read-%d %02x\n",
>> word_len, *(rx - 1));
>> -#endif
>> }
>> } while (c);
>> } else if (word_len <= 16) {
>> @@ -542,10 +536,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct
>> spi_transfer *xfer)
>> dev_err(&spi->dev, "TXS timed
>> out\n");
>> goto out;
>> }
>> -#ifdef VERBOSE
>> - dev_dbg(&spi->dev, "write-%d %04x\n",
>> + dev_vdbg(&spi->dev, "write-%d %04x\n",
>> word_len, *tx);
>> -#endif
>> __raw_writel(*tx++, tx_reg);
>> }
>> if (rx != NULL) {
>> @@ -559,10 +551,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct
>> spi_transfer *xfer)
>> (l & OMAP2_MCSPI_CHCONF_TURBO)) {
>> omap2_mcspi_set_enable(spi, 0);
>> *rx++ = __raw_readl(rx_reg);
>> -#ifdef VERBOSE
>> - dev_dbg(&spi->dev, "read-%d
>> %04x\n",
>> + dev_vdbg(&spi->dev, "read-%d
>> %04x\n",
>> word_len, *(rx - 1));
>> -#endif
>> if
>> (mcspi_wait_for_reg_bit(chstat_reg,
>> OMAP2_MCSPI_CHSTAT_RXS) <
>> 0) {
>> dev_err(&spi->dev,
>> @@ -575,10 +565,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct
>> spi_transfer *xfer)
>> }
>>
>> *rx++ = __raw_readl(rx_reg);
>> -#ifdef VERBOSE
>> - dev_dbg(&spi->dev, "read-%d %04x\n",
>> + dev_vdbg(&spi->dev, "read-%d %04x\n",
>> word_len, *(rx - 1));
>> -#endif
>> }
>> } while (c);
>> } else if (word_len <= 32) {
>> @@ -595,10 +583,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct
>> spi_transfer *xfer)
>> dev_err(&spi->dev, "TXS timed
>> out\n");
>> goto out;
>> }
>> -#ifdef VERBOSE
>> - dev_dbg(&spi->dev, "write-%d %08x\n",
>> + dev_vdbg(&spi->dev, "write-%d %08x\n",
>> word_len, *tx);
>> -#endif
>> __raw_writel(*tx++, tx_reg);
>> }
>> if (rx != NULL) {
>> @@ -612,10 +598,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct
>> spi_transfer *xfer)
>> (l & OMAP2_MCSPI_CHCONF_TURBO)) {
>> omap2_mcspi_set_enable(spi, 0);
>> *rx++ = __raw_readl(rx_reg);
>> -#ifdef VERBOSE
>> - dev_dbg(&spi->dev, "read-%d
>> %08x\n",
>> + dev_vdbg(&spi->dev, "read-%d
>> %08x\n",
>> word_len, *(rx - 1));
>> -#endif
>> if
>> (mcspi_wait_for_reg_bit(chstat_reg,
>> OMAP2_MCSPI_CHSTAT_RXS) <
>> 0) {
>> dev_err(&spi->dev,
>> @@ -628,10 +612,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct
>> spi_transfer *xfer)
>> }
>>
>> *rx++ = __raw_readl(rx_reg);
>> -#ifdef VERBOSE
>> - dev_dbg(&spi->dev, "read-%d %08x\n",
>> + dev_vdbg(&spi->dev, "read-%d %08x\n",
>> word_len, *(rx - 1));
>> -#endif
>> }
>> } while (c);
>> }
>> --
>> 1.7.1
>
> --
> balbi
>
> DefectiveByDesign.org
>
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] spi: omap2_mcspi: make use of dev_vdbg()
2010-08-09 13:22 ` Grant Likely
@ 2010-08-10 5:21 ` Felipe Balbi
2010-08-10 5:27 ` Grant Likely
0 siblings, 1 reply; 9+ messages in thread
From: Felipe Balbi @ 2010-08-10 5:21 UTC (permalink / raw)
To: ext Grant Likely
Cc: Balbi Felipe (Nokia-MS/Helsinki), linux-kernel@vger.kernel.org,
Linux OMAP Mailing List, Tony Lindgren,
Tereshonkov Roman (Nokia-MS/Helsinki), Andrew Morton,
David Brownell
Hi,
On Mon, Aug 09, 2010 at 03:22:31PM +0200, ext Grant Likely wrote:
>It didn't get sent to the spi-devel-general list, so it didn't get
>picked up by patchwork and wasn't there for me to pick up when I was
>collecting stuff for .36.
that's subscribers only ? I couldn't bother subscribing to a list just
to send a small cleanup patch. Even though it didn't go to the list,
both maintainers are in Cc list and nobody even commented.
Anyways, could you, somehow, get an account on majordomo ?
--
balbi
DefectiveByDesign.org
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] spi: omap2_mcspi: make use of dev_vdbg()
2010-08-10 5:21 ` Felipe Balbi
@ 2010-08-10 5:27 ` Grant Likely
2010-08-10 5:45 ` Felipe Balbi
0 siblings, 1 reply; 9+ messages in thread
From: Grant Likely @ 2010-08-10 5:27 UTC (permalink / raw)
To: felipe.balbi
Cc: linux-kernel@vger.kernel.org, Linux OMAP Mailing List,
Tony Lindgren, Tereshonkov Roman (Nokia-MS/Helsinki),
Andrew Morton, David Brownell
On Mon, Aug 9, 2010 at 11:21 PM, Felipe Balbi <felipe.balbi@nokia.com> wrote:
> Hi,
>
> On Mon, Aug 09, 2010 at 03:22:31PM +0200, ext Grant Likely wrote:
>>
>> It didn't get sent to the spi-devel-general list, so it didn't get
>> picked up by patchwork and wasn't there for me to pick up when I was
>> collecting stuff for .36.
>
> that's subscribers only ? I couldn't bother subscribing to a list just to
> send a small cleanup patch. Even though it didn't go to the list, both
> maintainers are in Cc list and nobody even commented.
My inbox gets very full. If it isn't in patchwork then I tend to lose it.
> Anyways, could you, somehow, get an account on majordomo ?
I know, the sourceforge list is a bit of a pain. I don't even know
who the admin of that list is. It was set up before I started the SPI
maintainership. I've been thinking about creating a new spi list on
vger.kernel.org.
g.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] spi: omap2_mcspi: make use of dev_vdbg()
2010-08-10 5:27 ` Grant Likely
@ 2010-08-10 5:45 ` Felipe Balbi
2010-08-10 6:54 ` David Brownell
0 siblings, 1 reply; 9+ messages in thread
From: Felipe Balbi @ 2010-08-10 5:45 UTC (permalink / raw)
To: ext Grant Likely
Cc: Balbi Felipe (Nokia-MS/Helsinki), linux-kernel@vger.kernel.org,
Linux OMAP Mailing List, Tony Lindgren,
Tereshonkov Roman (Nokia-MS/Helsinki), Andrew Morton,
David Brownell
Hi,
On Tue, Aug 10, 2010 at 07:27:43AM +0200, ext Grant Likely wrote:
>I know, the sourceforge list is a bit of a pain. I don't even know
>who the admin of that list is. It was set up before I started the SPI
>maintainership. I've been thinking about creating a new spi list on
>vger.kernel.org.
please do, that would make things a whole lot easier for plenty of
developers. Specially the ones who are just coming up with simple
patches once in a while :-)
--
balbi
DefectiveByDesign.org
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] spi: omap2_mcspi: make use of dev_vdbg()
2010-08-09 10:36 ` Felipe Balbi
2010-08-09 13:22 ` Grant Likely
@ 2010-08-10 6:33 ` Grant Likely
[not found] ` <20100810063341.GA28597-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org>
1 sibling, 1 reply; 9+ messages in thread
From: Grant Likely @ 2010-08-10 6:33 UTC (permalink / raw)
To: Felipe Balbi
Cc: linux-kernel@vger.kernel.org, Linux OMAP Mailing List,
Tony Lindgren, Tereshonkov Roman (Nokia-D/Helsinki),
Andrew Morton, David Brownell, spi-devel-general
On Mon, Aug 09, 2010 at 01:36:18PM +0300, Felipe Balbi wrote:
> On Thu, Jun 03, 2010 at 01:09:01PM +0200, Balbi Felipe (Nokia-D/Helsinki) wrote:
> >From: Felipe Balbi <felipe.balbi@nokia.com>
> >
> >dev_vdbg() is only compiled when VERBOSE is defined, so
> >there's no need to wrap dev_dbg() on #ifdef VERBOSE .. #endif
> >as we can use dev_vdbg() directly.
> >
> >Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
> >---
>
> ping, any comments to this one ? It's been pending for quite a long
> time.
Now picked up into my test-spi branch. I'll add it to linux-next after the merge window closes.
g.
>
> >drivers/spi/omap2_mcspi.c | 36 +++++++++---------------------------
> >1 files changed, 9 insertions(+), 27 deletions(-)
> >
> >diff --git a/drivers/spi/omap2_mcspi.c b/drivers/spi/omap2_mcspi.c
> >index b3a94ca..d703927 100644
> >--- a/drivers/spi/omap2_mcspi.c
> >+++ b/drivers/spi/omap2_mcspi.c
> >@@ -489,10 +489,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)
> > dev_err(&spi->dev, "TXS timed out\n");
> > goto out;
> > }
> >-#ifdef VERBOSE
> >- dev_dbg(&spi->dev, "write-%d %02x\n",
> >+ dev_vdbg(&spi->dev, "write-%d %02x\n",
> > word_len, *tx);
> >-#endif
> > __raw_writel(*tx++, tx_reg);
> > }
> > if (rx != NULL) {
> >@@ -506,10 +504,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)
> > (l & OMAP2_MCSPI_CHCONF_TURBO)) {
> > omap2_mcspi_set_enable(spi, 0);
> > *rx++ = __raw_readl(rx_reg);
> >-#ifdef VERBOSE
> >- dev_dbg(&spi->dev, "read-%d %02x\n",
> >+ dev_vdbg(&spi->dev, "read-%d %02x\n",
> > word_len, *(rx - 1));
> >-#endif
> > if (mcspi_wait_for_reg_bit(chstat_reg,
> > OMAP2_MCSPI_CHSTAT_RXS) < 0) {
> > dev_err(&spi->dev,
> >@@ -522,10 +518,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)
> > }
> >
> > *rx++ = __raw_readl(rx_reg);
> >-#ifdef VERBOSE
> >- dev_dbg(&spi->dev, "read-%d %02x\n",
> >+ dev_vdbg(&spi->dev, "read-%d %02x\n",
> > word_len, *(rx - 1));
> >-#endif
> > }
> > } while (c);
> > } else if (word_len <= 16) {
> >@@ -542,10 +536,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)
> > dev_err(&spi->dev, "TXS timed out\n");
> > goto out;
> > }
> >-#ifdef VERBOSE
> >- dev_dbg(&spi->dev, "write-%d %04x\n",
> >+ dev_vdbg(&spi->dev, "write-%d %04x\n",
> > word_len, *tx);
> >-#endif
> > __raw_writel(*tx++, tx_reg);
> > }
> > if (rx != NULL) {
> >@@ -559,10 +551,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)
> > (l & OMAP2_MCSPI_CHCONF_TURBO)) {
> > omap2_mcspi_set_enable(spi, 0);
> > *rx++ = __raw_readl(rx_reg);
> >-#ifdef VERBOSE
> >- dev_dbg(&spi->dev, "read-%d %04x\n",
> >+ dev_vdbg(&spi->dev, "read-%d %04x\n",
> > word_len, *(rx - 1));
> >-#endif
> > if (mcspi_wait_for_reg_bit(chstat_reg,
> > OMAP2_MCSPI_CHSTAT_RXS) < 0) {
> > dev_err(&spi->dev,
> >@@ -575,10 +565,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)
> > }
> >
> > *rx++ = __raw_readl(rx_reg);
> >-#ifdef VERBOSE
> >- dev_dbg(&spi->dev, "read-%d %04x\n",
> >+ dev_vdbg(&spi->dev, "read-%d %04x\n",
> > word_len, *(rx - 1));
> >-#endif
> > }
> > } while (c);
> > } else if (word_len <= 32) {
> >@@ -595,10 +583,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)
> > dev_err(&spi->dev, "TXS timed out\n");
> > goto out;
> > }
> >-#ifdef VERBOSE
> >- dev_dbg(&spi->dev, "write-%d %08x\n",
> >+ dev_vdbg(&spi->dev, "write-%d %08x\n",
> > word_len, *tx);
> >-#endif
> > __raw_writel(*tx++, tx_reg);
> > }
> > if (rx != NULL) {
> >@@ -612,10 +598,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)
> > (l & OMAP2_MCSPI_CHCONF_TURBO)) {
> > omap2_mcspi_set_enable(spi, 0);
> > *rx++ = __raw_readl(rx_reg);
> >-#ifdef VERBOSE
> >- dev_dbg(&spi->dev, "read-%d %08x\n",
> >+ dev_vdbg(&spi->dev, "read-%d %08x\n",
> > word_len, *(rx - 1));
> >-#endif
> > if (mcspi_wait_for_reg_bit(chstat_reg,
> > OMAP2_MCSPI_CHSTAT_RXS) < 0) {
> > dev_err(&spi->dev,
> >@@ -628,10 +612,8 @@ omap2_mcspi_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)
> > }
> >
> > *rx++ = __raw_readl(rx_reg);
> >-#ifdef VERBOSE
> >- dev_dbg(&spi->dev, "read-%d %08x\n",
> >+ dev_vdbg(&spi->dev, "read-%d %08x\n",
> > word_len, *(rx - 1));
> >-#endif
> > }
> > } while (c);
> > }
> >--
> >1.7.1
>
> --
> balbi
>
> DefectiveByDesign.org
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] spi: omap2_mcspi: make use of dev_vdbg()
[not found] ` <20100810063341.GA28597-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org>
@ 2010-08-10 6:39 ` Felipe Balbi
0 siblings, 0 replies; 9+ messages in thread
From: Felipe Balbi @ 2010-08-10 6:39 UTC (permalink / raw)
To: ext Grant Likely
Cc: Tony Lindgren,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Tereshonkov Roman (Nokia-MS/Helsinki), David Brownell,
spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Balbi Felipe (Nokia-MS/Helsinki), Linux OMAP Mailing List,
Andrew Morton
Hi,
On Tue, Aug 10, 2010 at 08:33:41AM +0200, ext Grant Likely wrote:
>Now picked up into my test-spi branch. I'll add it to linux-next after
>the merge window closes.
ok, thanks Grant
--
balbi
DefectiveByDesign.org
------------------------------------------------------------------------------
This SF.net email is sponsored by
Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] spi: omap2_mcspi: make use of dev_vdbg()
2010-08-10 5:45 ` Felipe Balbi
@ 2010-08-10 6:54 ` David Brownell
0 siblings, 0 replies; 9+ messages in thread
From: David Brownell @ 2010-08-10 6:54 UTC (permalink / raw)
To: ext Grant Likely
Cc: Balbi Felipe (Nokia-MS/Helsinki), linux-kernel@vger.kernel.org,
Linux OMAP Mailing List, Tony Lindgren,
Tereshonkov Roman (Nokia-MS/Helsinki), Andrew Morton
> >I know, the sourceforge list is a bit of a pain.
As all sourceforge lists are.
> I don't even know
> >who the admin of that list is.
One of the Russian MontaVista crew created
that list, and presumably maintains it.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2010-08-10 6:54 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-03 11:09 [PATCH] spi: omap2_mcspi: make use of dev_vdbg() felipe.balbi
2010-08-09 10:36 ` Felipe Balbi
2010-08-09 13:22 ` Grant Likely
2010-08-10 5:21 ` Felipe Balbi
2010-08-10 5:27 ` Grant Likely
2010-08-10 5:45 ` Felipe Balbi
2010-08-10 6:54 ` David Brownell
2010-08-10 6:33 ` Grant Likely
[not found] ` <20100810063341.GA28597-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org>
2010-08-10 6:39 ` Felipe Balbi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).