linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ajay Kumar Gupta <ajay.gupta-l0cyMroinI0@public.gmane.org>
To: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	felipe.balbi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org,
	gregkh-l3A5Bk7waGM@public.gmane.org,
	Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>,
	Ajay Kumar Gupta <ajay.gupta-l0cyMroinI0@public.gmane.org>
Subject: [PATCH 5/8] usb: musb: fix Blackfin ulpi stubs
Date: Thu, 17 Jun 2010 16:10:38 +0530	[thread overview]
Message-ID: <1276771242-5201-6-git-send-email-ajay.gupta@ti.com> (raw)
In-Reply-To: <1276771242-5201-5-git-send-email-ajay.gupta-l0cyMroinI0@public.gmane.org>

From: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>

The new ulpi code defines fallback stubs for the Blackfin arch, but does
so incorrectly leading to a build failure:
drivers/usb/musb/musb_core.c:227: error: 'musb_ulpi_read' undeclared here (not in a function)
drivers/usb/musb/musb_core.c:228: error: 'musb_ulpi_write' undeclared here (not in a function)

Tweak the fallback stubs so that they do work as intended.

Signed-off-by: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
Signed-off-by: Ajay Kumar Gupta <ajay.gupta-l0cyMroinI0@public.gmane.org>
---
 drivers/usb/musb/musb_core.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 7cc8398..4f43db7 100644
--- a/drivers/usb/musb/musb_core.c
+++ b/drivers/usb/musb/musb_core.c
@@ -219,8 +219,8 @@ static int musb_ulpi_write(struct otg_transceiver *otg,
 	return 0;
 }
 #else
-#define musb_ulpi_read(a, b)		NULL
-#define musb_ulpi_write(a, b, c)	NULL
+#define musb_ulpi_read		NULL
+#define musb_ulpi_write		NULL
 #endif
 
 static struct otg_io_access_ops musb_ulpi_access = {
-- 
1.6.2.4

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2010-06-17 10:40 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-17 10:40 [patch-2.6.35-rc3+ 0/8] musb patches Ajay Kumar Gupta
2010-06-17 10:40 ` [PATCH 1/8] musb_core: make disconnect and suspend interrupts work again Ajay Kumar Gupta
     [not found]   ` <1276771242-5201-2-git-send-email-ajay.gupta-l0cyMroinI0@public.gmane.org>
2010-06-17 10:40     ` [PATCH 2/8] MUSB: make non-OMAP platforms build with CONFIG_PM=y Ajay Kumar Gupta
2010-06-17 10:40       ` [PATCH 3/8] musb: fix compilation warning in host only mode Ajay Kumar Gupta
     [not found]         ` <1276771242-5201-4-git-send-email-ajay.gupta-l0cyMroinI0@public.gmane.org>
2010-06-17 10:40           ` [PATCH 4/8] USB: musb: suppress warning about unused flags Ajay Kumar Gupta
     [not found]             ` <1276771242-5201-5-git-send-email-ajay.gupta-l0cyMroinI0@public.gmane.org>
2010-06-17 10:40               ` Ajay Kumar Gupta [this message]
2010-06-17 10:40                 ` [PATCH 6/8] usb: musb: Enable the maximum supported burst mode for DMA Ajay Kumar Gupta
     [not found]                   ` <1276771242-5201-7-git-send-email-ajay.gupta-l0cyMroinI0@public.gmane.org>
2010-06-17 10:40                     ` [PATCH 7/8] musb: Kill board specific pinmux from driver file Ajay Kumar Gupta
2010-06-17 10:40                       ` [PATCH 8/8] usb: musb: Fix suspend interrupt issue in device mode Ajay Kumar Gupta
     [not found]                         ` <1276771242-5201-9-git-send-email-ajay.gupta-l0cyMroinI0@public.gmane.org>
2010-06-17 10:40                           ` Ajay Kumar Gupta
2010-06-17 11:27                           ` Sergei Shtylyov
     [not found]                             ` <4C1A0687.4080002-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2010-06-17 12:15                               ` Maulik
2010-06-17 13:33                                 ` Sergei Shtylyov
     [not found]                                 ` <006501cb0e16$c08bae00$808918ac-wD+IZp/g4/2mHdYHvhjUOg@public.gmane.org>
2010-06-17 14:18                                   ` Greg KH
2010-06-18  5:21                         ` David Brownell
     [not found]                       ` <1276771242-5201-8-git-send-email-ajay.gupta-l0cyMroinI0@public.gmane.org>
2010-06-24  6:11                         ` [PATCH 7/8] musb: Kill board specific pinmux from driver file Felipe Balbi
2010-06-24  6:16                           ` Gadiyar, Anand
2010-06-24  6:11                     ` [PATCH 6/8] usb: musb: Enable the maximum supported burst mode for DMA Felipe Balbi
2010-06-24  6:10                 ` [PATCH 5/8] usb: musb: fix Blackfin ulpi stubs Felipe Balbi
2010-06-24  6:08             ` [PATCH 4/8] USB: musb: suppress warning about unused flags Felipe Balbi
     [not found]               ` <20100624060857.GG8078-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2010-06-24  9:50                 ` Sergei Shtylyov
     [not found]                   ` <4C232A4C.6040102-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2010-06-28 14:24                     ` Felipe Balbi
2010-06-28 17:27                       ` Sergei Shtylyov
2010-06-17 11:18           ` [PATCH 3/8] musb: fix compilation warning in host only mode Sergei Shtylyov
2010-06-17 12:09             ` Gupta, Ajay Kumar
     [not found]               ` <19F8576C6E063C45BE387C64729E7394044E91B843-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2010-06-17 13:24                 ` Sergei Shtylyov
     [not found]                   ` <4C1A2220.7070502-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
2010-06-17 14:09                     ` Gupta, Ajay Kumar
2010-06-24  6:03           ` Felipe Balbi
2010-06-24 11:17             ` Gupta, Ajay Kumar
2010-06-24 13:10               ` Sergei Shtylyov
     [not found]                 ` <4C235929.9030605-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2010-06-24 14:36                   ` Gupta, Ajay Kumar
2010-07-06  9:12                 ` Felipe Balbi
2010-07-06  9:13               ` Felipe Balbi
2010-07-07 22:01                 ` Greg KH
2010-07-08  1:53                   ` Gupta, Ajay Kumar
     [not found]                     ` <19F8576C6E063C45BE387C64729E7394044EB95AE0-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2010-07-08  3:35                       ` Greg KH
2010-06-24  6:02       ` [PATCH 2/8] MUSB: make non-OMAP platforms build with CONFIG_PM=y Felipe Balbi
2010-06-24  6:01     ` [PATCH 1/8] musb_core: make disconnect and suspend interrupts work again Felipe Balbi
     [not found]       ` <20100624060151.GD8078-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2010-06-24 17:01         ` Greg KH
     [not found] ` <1276771242-5201-1-git-send-email-ajay.gupta-l0cyMroinI0@public.gmane.org>
2010-06-17 14:17   ` [patch-2.6.35-rc3+ 0/8] musb patches Greg KH
2010-06-17 14:26     ` Gupta, Ajay Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1276771242-5201-6-git-send-email-ajay.gupta@ti.com \
    --to=ajay.gupta-l0cymroini0@public.gmane.org \
    --cc=felipe.balbi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org \
    --cc=gregkh-l3A5Bk7waGM@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).