From: Charulatha V <charu@ti.com>
To: linux-omap@vger.kernel.org
Cc: khilman@deeprootsystems.com, paul@pwsan.com, tony@atomide.com,
rnayak@ti.com, p-basak2@ti.com, b-cousson@ti.com,
Charulatha V <charu@ti.com>
Subject: [PATCH:v4 00/13] OMAP: GPIO: Implement GPIO in HWMOD way
Date: Tue, 22 Jun 2010 20:31:43 +0530 [thread overview]
Message-ID: <1277218916-15213-1-git-send-email-charu@ti.com> (raw)
This patch series makes OMAP2PLUS specific GPIO implemented in HWMOD
FW way. This is done by implementing GPIO module in platform device model.
This patch series is generated on "origin/pm-wip/hwmods-omap4".
This patch series is tested on OMAP4430 SDP board and OMAP3430 SDP board.
It would be of great help if someone could test the same on OMAP1
and OMAP2 boards.
This patch series is created on top of the following patch:
OMAP3: HWMOD: Fix compilation error due to sr hwmod usage
Author: Charulatha V <charu@ti.com> Date:Tue Jun 22 11:29:33 2010 +0530
The list of following TODO's need to addressed soon and sent
as another series on top of this patch series
TODO:
1. Cleanup the GPIO driver. Use function pointers and register
offest pointers instead of using hardcoded values
2. Remove all cpu_is_ checks and OMAP specific macros from
omap gpio driver
3. Remove usage of gpio_bank array so that only
instance specific information is used in driver code
4. Modify save/restore context, gpio_prepare_for_idle,
gpio_resume_after_idle functions as instance
specific function and not for all instances in a single call
5. Rename method/ avoid it's usage
Version History:
---------------
Comments Fixed in v4:
- Remove gpio_bank_count from dev_attr field and derive it from
hwmod class iteration count
- Add TODOs for future omap gpio code cleanup related activity
- Rename gpio's platform_data 'method' to 'bank_type'
- Rename gpio's platform_data 'gpio_bank_bits' to 'gpio_bank_width'
- Add 'rev' field to gpio class in hwmod datbase and get 'bank_type'
based on 'rev' field
- Filename removed from file description when a new file is created
v3 series:
Some important links to patch v3 series and comments:
https://patchwork.kernel.org/patch/106228/
https://patchwork.kernel.org/patch/106224/
https://patchwork.kernel.org/patch/106227/
https://patchwork.kernel.org/patch/106235/
Comments Fixed in v3:
- .module_offs populated in hwmod structures
- If not defined CONFIG_PM_RUNTIME is not handled in GPIO driver
- No changes to mach-omap2/clockxxxx-data.c to handle clocks by dev ptr
as it is taken care using clock get by name in hwmod & omap_device layer
- Using "ick" instead of "arm_gpio_ck" for OMAP15xx clock
- SoC base addresses moved to plat-omap/omapXXXX.h that should be
used only by the omap_hwmod_xxxx_data.c file
- OMAP2/3 hwmod structures naming convention changed as it is
followed in OMAP4
- omap24xx_gpio_init() uses cpu_is_omap24xx() instead of separate
checks for 2420 & 2430 in OMAP2 specific init call (mach-omap layer)
- Reason for using postcore_initcall is added to patch description for
the patch "OMAP: GPIO: Introduce support for OMAP2PLUS chip GPIO init"
- Comments added for usage of dbck_flag and other elements
in dev_attr structure
- Uses dev_dbg() and dev_err() instead of pr_dbg() and pr_err()
- Corrects the gpio clock details in OMAP4 hwmod database
v2 series:
Some important links to patch v2 series and comments:
http://www.mail-archive.com/linux-omap@vger.kernel.org/msg30262.html
http://www.mail-archive.com/linux-omap@vger.kernel.org/msg28787.html
http://www.mail-archive.com/linux-omap@vger.kernel.org/msg30263.html
http://www.mail-archive.com/linux-omap@vger.kernel.org/msg30295.html
http://www.mail-archive.com/linux-omap@vger.kernel.org/msg30259.html
http://www.mail-archive.com/linux-omap@vger.kernel.org/msg28933.html
Comments Fixed in V2:
- GPIO dev attr was added for SoC specific chip info (eg., gpio bank count)
- Removed omap_gpio_init() usage from board files
- platform_get_resource() used instead of pdata->base for
OMAP2+ base addresses
- postcore_initcall used for gpio init instead of making
GPIO as an early platform device. SoC specific gpio_init
needs to be done before machine_init functions access gpio
APIs. Hence making SoC specific gpio_init as postcore_initcall.
- getting gpio dbck is moved to omap_set_gpio_debounce()
instead of doing it in probe
v1 series:
Some important links to patch v1 series and comments:
http://www.mail-archive.com/linux-omap@vger.kernel.org/msg26934.html
http://www.mail-archive.com/linux-omap@vger.kernel.org/msg27860.html
http://www.mail-archive.com/linux-omap@vger.kernel.org/msg28183.html
Highlights in v1:
- Introduces SoC specific functions at mach-omap layer
- Implements GPIO as a platform device
- Make gpio an early device and make it implemented in
HWMOD FW adapted way for OMAP2PLUS
Charulatha V (13):
OMAP: GPIO: Modify init() in preparation for platform device
implementation
OMAP: GPIO: Populate GPIO base address in omapxxxx.h
OMAP: GPIO: Include platform_data structure for GPIO
OMAP: GPIO: Introduce support for OMAP15xx chip GPIO init
OMAP: GPIO: Introduce support for OMAP16xx chip GPIO init
OMAP: GPIO: Introduce support for OMAP7xx chip GPIO init
OMAP: GPIO: add GPIO hwmods structures for OMAP3
OMAP: GPIO: add GPIO hwmods structures for OMAP242X
OMAP: GPIO: add GPIO hwmods structures for OMAP243X
OMAP: GPIO: Add gpio dev_attr and correct clks in OMAP4 hwmod struct
OMAP: GPIO: Introduce support for OMAP2PLUS chip GPIO init
OMAP: GPIO: Implement GPIO as a platform device
OMAP: GPIO: Remove omap_gpio_init()
arch/arm/mach-omap1/Makefile | 6 +
arch/arm/mach-omap1/board-ams-delta.c | 1 -
arch/arm/mach-omap1/board-fsample.c | 1 -
arch/arm/mach-omap1/board-h2.c | 1 -
arch/arm/mach-omap1/board-h3.c | 1 -
arch/arm/mach-omap1/board-htcherald.c | 1 -
arch/arm/mach-omap1/board-innovator.c | 1 -
arch/arm/mach-omap1/board-nokia770.c | 1 -
arch/arm/mach-omap1/board-osk.c | 1 -
arch/arm/mach-omap1/board-palmte.c | 1 -
arch/arm/mach-omap1/board-palmz71.c | 1 -
arch/arm/mach-omap1/board-perseus2.c | 1 -
arch/arm/mach-omap1/board-sx1.c | 1 -
arch/arm/mach-omap1/board-voiceblue.c | 1 -
arch/arm/mach-omap1/clock_data.c | 4 +-
arch/arm/mach-omap1/gpio15xx.c | 105 +++++
arch/arm/mach-omap1/gpio16xx.c | 212 ++++++++++
arch/arm/mach-omap1/gpio7xx.c | 278 +++++++++++++
arch/arm/mach-omap2/Makefile | 2 +-
arch/arm/mach-omap2/board-2430sdp.c | 1 -
arch/arm/mach-omap2/board-3430sdp.c | 1 -
arch/arm/mach-omap2/board-3630sdp.c | 1 -
arch/arm/mach-omap2/board-4430sdp.c | 1 -
arch/arm/mach-omap2/board-am3517evm.c | 1 -
arch/arm/mach-omap2/board-apollon.c | 1 -
arch/arm/mach-omap2/board-cm-t35.c | 1 -
arch/arm/mach-omap2/board-devkit8000.c | 1 -
arch/arm/mach-omap2/board-h4.c | 1 -
arch/arm/mach-omap2/board-igep0020.c | 1 -
arch/arm/mach-omap2/board-ldp.c | 1 -
arch/arm/mach-omap2/board-n8x0.c | 1 -
arch/arm/mach-omap2/board-omap3beagle.c | 1 -
arch/arm/mach-omap2/board-omap3evm.c | 1 -
arch/arm/mach-omap2/board-omap3pandora.c | 1 -
arch/arm/mach-omap2/board-omap3stalker.c | 1 -
arch/arm/mach-omap2/board-omap3touchbook.c | 1 -
arch/arm/mach-omap2/board-overo.c | 1 -
arch/arm/mach-omap2/board-rx51.c | 1 -
arch/arm/mach-omap2/board-zoom2.c | 1 -
arch/arm/mach-omap2/board-zoom3.c | 1 -
arch/arm/mach-omap2/gpio.c | 86 ++++
arch/arm/mach-omap2/omap_hwmod_2420_data.c | 228 ++++++++++
arch/arm/mach-omap2/omap_hwmod_2430_data.c | 279 +++++++++++++
arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 366 ++++++++++++++++
arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 31 +-
arch/arm/plat-omap/gpio.c | 619 +++++++++-------------------
arch/arm/plat-omap/include/plat/gpio.h | 24 +-
arch/arm/plat-omap/include/plat/omap24xx.h | 12 +
arch/arm/plat-omap/include/plat/omap34xx.h | 8 +
arch/arm/plat-omap/include/plat/omap44xx.h | 8 +
50 files changed, 1837 insertions(+), 465 deletions(-)
create mode 100644 arch/arm/mach-omap1/gpio15xx.c
create mode 100644 arch/arm/mach-omap1/gpio16xx.c
create mode 100644 arch/arm/mach-omap1/gpio7xx.c
create mode 100644 arch/arm/mach-omap2/gpio.c
next reply other threads:[~2010-06-22 15:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-22 15:01 Charulatha V [this message]
2010-06-22 15:01 ` [PATCH:v4 01/13] OMAP: GPIO: Modify init() in preparation for platform device implementation Charulatha V
2010-06-22 15:01 ` [PATCH:v4 02/13] OMAP: GPIO: Populate GPIO base address in omapxxxx.h Charulatha V
2010-06-22 15:01 ` [PATCH:v4 03/13] OMAP: GPIO: Include platform_data structure for GPIO Charulatha V
2010-06-22 15:01 ` [PATCH:v4 04/13] OMAP: GPIO: Introduce support for OMAP15xx chip GPIO init Charulatha V
2010-06-22 15:01 ` [PATCH:v4 05/13] OMAP: GPIO: Introduce support for OMAP16xx " Charulatha V
2010-06-22 15:01 ` [PATCH:v4 06/13] OMAP: GPIO: Introduce support for OMAP7xx " Charulatha V
2010-06-22 15:01 ` [PATCH:v4 07/13] OMAP: GPIO: add GPIO hwmods structures for OMAP3 Charulatha V
2010-06-22 15:01 ` [PATCH:v4 08/13] OMAP: GPIO: add GPIO hwmods structures for OMAP242X Charulatha V
2010-06-22 15:01 ` [PATCH:v4 09/13] OMAP: GPIO: add GPIO hwmods structures for OMAP243X Charulatha V
2010-06-22 15:01 ` [PATCH:v4 10/13] OMAP: GPIO: Add gpio dev_attr and correct clks in OMAP4 hwmod struct Charulatha V
2010-06-22 15:01 ` [PATCH:v4 11/13] OMAP: GPIO: Introduce support for OMAP2PLUS chip GPIO init Charulatha V
2010-06-22 15:01 ` [PATCH:v4 12/13] OMAP: GPIO: Implement GPIO as a platform device Charulatha V
2010-06-22 15:01 ` [PATCH:v4 13/13] OMAP: GPIO: Remove omap_gpio_init() Charulatha V
2010-06-25 23:36 ` [PATCH:v4 12/13] OMAP: GPIO: Implement GPIO as a platform device Kevin Hilman
2010-06-24 7:03 ` [PATCH:v4 03/13] OMAP: GPIO: Include platform_data structure for GPIO DebBarma, Tarun Kanti
2010-07-06 13:17 ` [PATCH:v4 00/13] OMAP: GPIO: Implement GPIO in HWMOD way Tony Lindgren
2010-07-27 11:47 ` Cousson, Benoit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277218916-15213-1-git-send-email-charu@ti.com \
--to=charu@ti.com \
--cc=b-cousson@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=p-basak2@ti.com \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).