From: Nishanth Menon <nm@ti.com>
To: linux-omap <linux-omap@vger.kernel.org>
Cc: Nishanth Menon <nm@ti.com>,
Kevin Hilman <khilman@deeprootsystems.com>,
Thara Gopinath <thara@ti.com>
Subject: [PM-SR] [PATCH 2/4] omap3: sr: sr_exit should be static
Date: Thu, 24 Jun 2010 16:29:24 -0500 [thread overview]
Message-ID: <1277414966-31806-3-git-send-email-nm@ti.com> (raw)
In-Reply-To: <1277414966-31806-2-git-send-email-nm@ti.com>
sr_exit has no business being a public function.
fixes sparse:
arch/arm/mach-omap2/smartreflex.c:959:13: warning: symbol 'sr_exit' was not declared. Should it be static?
Cc: Kevin Hilman <khilman@deeprootsystems.com>
Cc: Thara Gopinath <thara@ti.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
---
arch/arm/mach-omap2/smartreflex.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c
index 57fc9b2..786e896 100644
--- a/arch/arm/mach-omap2/smartreflex.c
+++ b/arch/arm/mach-omap2/smartreflex.c
@@ -956,7 +956,7 @@ static int __init sr_init(void)
return 0;
}
-void __exit sr_exit(void)
+static void __exit sr_exit(void)
{
platform_driver_unregister(&smartreflex_driver);
}
--
1.6.3.3
next prev parent reply other threads:[~2010-06-24 21:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-24 21:29 [PM-SR][PATCH 0/4] Janitor series: kill sparse warnings Nishanth Menon
2010-06-24 21:29 ` [PM-SR] [PATCH 1/4] omap: sr: export sr_dbg_dir Nishanth Menon
2010-06-24 21:29 ` Nishanth Menon [this message]
2010-06-24 21:29 ` [PM-SR][PATCH 3/4] omap3: voltage: make required variables static Nishanth Menon
2010-06-24 21:29 ` [PM-SR][PATCH 4/4] omap3: voltage: expose omap_change_voltscale_method Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277414966-31806-3-git-send-email-nm@ti.com \
--to=nm@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=thara@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).