From: Kevin Hilman <khilman@deeprootsystems.com>
To: linux-omap@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/3] OMAP: bus-level PM: enable use of runtime PM API for suspend/resume
Date: Thu, 24 Jun 2010 16:43:10 -0700 [thread overview]
Message-ID: <1277422991-25350-3-git-send-email-khilman@deeprootsystems.com> (raw)
In-Reply-To: <1277422991-25350-1-git-send-email-khilman@deeprootsystems.com>
Hook into the platform bus methods for suspend and resume and use the
runtime PM API to allow the OMAP runtime PM core (based on
omap_device) to automatically idle and enable the device on suspend
and resume.
This allows device drivers to get rid of direct management of their
clocks in their suspend/resume paths, and let omap_device do it for
them .
We currently use the _noirq (late suspend, early resume) versions of
the suspend/resume methods to ensure that the device is not disabled
too early for any drivers also using the _noirq methods.
NOTE: only works for devices with omap_hwmod support.
Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
---
arch/arm/mach-omap2/pm_bus.c | 48 ++++++++++++++++++++++++++++++++++++++++++
1 files changed, 48 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/pm_bus.c b/arch/arm/mach-omap2/pm_bus.c
index 9719a9f..5e453dc 100644
--- a/arch/arm/mach-omap2/pm_bus.c
+++ b/arch/arm/mach-omap2/pm_bus.c
@@ -68,3 +68,51 @@ int platform_pm_runtime_idle(struct device *dev)
};
#endif /* CONFIG_PM_RUNTIME */
+#ifdef CONFIG_SUSPEND
+int platform_pm_suspend_noirq(struct device *dev)
+{
+ struct device_driver *drv = dev->driver;
+ int ret = 0;
+
+ if (!drv)
+ return 0;
+
+ if (drv->pm) {
+ if (drv->pm->suspend_noirq)
+ ret = drv->pm->suspend_noirq(dev);
+ }
+
+ /*
+ * The DPM core has done a 'get' to prevent runtime PM
+ * transitions during system PM. This put is to balance
+ * out that get so that this device can now be runtime
+ * suspended.
+ */
+ pm_runtime_put_sync(dev);
+
+ return ret;
+}
+
+int platform_pm_resume_noirq(struct device *dev)
+{
+ struct device_driver *drv = dev->driver;
+ int ret = 0;
+
+ /*
+ * This 'get' is to balance the 'put' in the above suspend_noirq
+ * method so that the runtime PM usage counting is in the same
+ * state it was when suspend was called.
+ */
+ pm_runtime_get_sync(dev);
+
+ if (!drv)
+ return 0;
+
+ if (drv->pm) {
+ if (drv->pm->resume_noirq)
+ ret = drv->pm->resume_noirq(dev);
+ }
+
+ return ret;
+}
+#endif /* CONFIG_SUSPEND */
--
1.7.0.2
next prev parent reply other threads:[~2010-06-24 23:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-24 23:43 [PATCH v2 0/3] OMAP: add runtime PM support at bus-level Kevin Hilman
2010-06-24 23:43 ` [PATCH v2 1/3] OMAP: PM: initial runtime PM core support Kevin Hilman
2010-06-25 15:26 ` Grant Likely
2010-06-25 18:04 ` Kevin Hilman
2010-06-25 20:08 ` Grant Likely
2010-06-25 21:58 ` Kevin Hilman
2010-06-25 22:30 ` Grant Likely
2010-06-25 22:46 ` Kevin Hilman
2010-06-25 23:04 ` Grant Likely
2010-06-28 21:49 ` Kevin Hilman
2010-06-28 22:14 ` Grant Likely
2010-06-28 23:27 ` Kevin Hilman
2010-06-28 23:47 ` Grant Likely
2010-06-25 20:06 ` Russell King - ARM Linux
2010-06-25 20:13 ` Grant Likely
2010-06-25 20:20 ` Russell King - ARM Linux
2010-06-25 23:46 ` Nicolas Pitre
2010-06-26 10:51 ` Uwe Kleine-König
2010-06-26 11:07 ` Russell King - ARM Linux
2010-08-04 22:55 ` Grant Likely
2010-06-24 23:43 ` Kevin Hilman [this message]
2010-06-24 23:43 ` [PATCH v2 3/3] OMAP1: PM: add simple runtime PM layer to manage clocks Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277422991-25350-3-git-send-email-khilman@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).