From: Afzal Mohammed <lazfamam@gmail.com>
To: tomi.valkeinen@nokia.com
Cc: ville.syrjala@nokia.com, tj@kernel.org, lazfamam@gmail.com,
linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] OMAP:DSS2:OMAPFB: Fix probe error path
Date: Wed, 30 Jun 2010 19:45:27 +0530 [thread overview]
Message-ID: <1277907327-3443-1-git-send-email-lazfamam@gmail.com> (raw)
If enabling fb0 fails in omapfb_create_framebuffers(), remove
sysfs file before returning to probe. This is required to complete
the cleanup in the above mentioned error case.
Signed-off-by: Afzal Mohammed <lazfamam@gmail.com>
---
drivers/video/omap2/omapfb/omapfb-main.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/video/omap2/omapfb/omapfb-main.c b/drivers/video/omap2/omapfb/omapfb-main.c
index 4b4506d..2319b81 100644
--- a/drivers/video/omap2/omapfb/omapfb-main.c
+++ b/drivers/video/omap2/omapfb/omapfb-main.c
@@ -1945,6 +1945,7 @@ static int omapfb_create_framebuffers(struct omapfb2_device *fbdev)
r = omapfb_overlay_enable(ovl, 1);
if (r) {
+ omapfb_remove_sysfs(fbdev);
dev_err(fbdev->dev,
"failed to enable overlay\n");
return r;
--
1.7.0.4
next reply other threads:[~2010-06-30 14:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-30 14:15 Afzal Mohammed [this message]
2010-07-01 9:54 ` [PATCH] OMAP:DSS2:OMAPFB: Fix probe error path Tomi Valkeinen
-- strict thread matches above, loose matches on Subject: below --
2010-07-01 13:40 Afzal Mohammed
2010-07-01 13:40 ` Afzal Mohammed
2010-07-01 14:57 ` Tomi Valkeinen
2010-07-05 6:38 Afzal Mohammed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277907327-3443-1-git-send-email-lazfamam@gmail.com \
--to=lazfamam@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tj@kernel.org \
--cc=tomi.valkeinen@nokia.com \
--cc=ville.syrjala@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).