From: Thara Gopinath <thara@ti.com>
To: linux-omap@vger.kernel.org
Cc: khilman@deeprootsystems.com, paul@pwsan.com, b-cousson@ti.com,
vishwanath.bs@ti.com, sawant@ti.com, p-basak2@ti.com,
Thara Gopinath <thara@ti.com>
Subject: [RFC 5/7] OMAP: Introduce set_rate and get_rate API in omap device layer
Date: Fri, 2 Jul 2010 15:48:27 +0530 [thread overview]
Message-ID: <1278065909-32148-6-git-send-email-thara@ti.com> (raw)
In-Reply-To: <1278065909-32148-5-git-send-email-thara@ti.com>
This patch adds omap_device_set_rate and omap_device_get_rate
API's which can be used to generic device rate scaling.
Signed-off-by: Thara Gopinath <thara@ti.com>
---
arch/arm/plat-omap/include/plat/omap_device.h | 2 +
arch/arm/plat-omap/omap_device.c | 87 +++++++++++++++++++++++++
2 files changed, 89 insertions(+), 0 deletions(-)
diff --git a/arch/arm/plat-omap/include/plat/omap_device.h b/arch/arm/plat-omap/include/plat/omap_device.h
index 3694b62..e0d06bb 100644
--- a/arch/arm/plat-omap/include/plat/omap_device.h
+++ b/arch/arm/plat-omap/include/plat/omap_device.h
@@ -114,6 +114,8 @@ int omap_device_enable_hwmods(struct omap_device *od);
int omap_device_disable_clocks(struct omap_device *od);
int omap_device_enable_clocks(struct omap_device *od);
+int omap_device_set_rate(struct device *dev, unsigned long rate);
+unsigned long omap_device_get_rate(struct device *dev);
/*
* Entries should be kept in latency order ascending
diff --git a/arch/arm/plat-omap/omap_device.c b/arch/arm/plat-omap/omap_device.c
index 6614cba..900bb5d 100644
--- a/arch/arm/plat-omap/omap_device.c
+++ b/arch/arm/plat-omap/omap_device.c
@@ -85,6 +85,8 @@
#include <plat/omap_device.h>
#include <plat/omap_hwmod.h>
+#include <plat/opp.h>
+#include <plat/voltage.h>
/* These parameters are passed to _omap_device_{de,}activate() */
#define USE_WAKEUP_LAT 0
@@ -734,3 +736,88 @@ int omap_device_enable_clocks(struct omap_device *od)
/* XXX pass along return value here? */
return 0;
}
+
+/**
+ * omap_device_set_rate - Set a new rate at which the device is to operate
+ * @dev : the device pointer
+ * @rate : the rnew rate for the device.
+ *
+ * This API gets the device opp table associated with this device and
+ * tries putting the device to the requested rate and the voltage domain
+ * associated with the device to the voltage corresponding to the
+ * requested rate. Since multiple devices can be assocciated with a
+ * voltage domain this API finds out the possible voltage the
+ * voltage domain can enter and then decides on the final device
+ * rate. Return 0 on success else the error value
+ */
+int omap_device_set_rate(struct device *dev, unsigned long rate)
+{
+ struct device_opp *dev_opp;
+ struct omap_opp *opp;
+ unsigned long volt, freq;
+ int ret;
+
+ dev_opp = opp_find_dev_opp(dev);
+ if (IS_ERR(dev_opp)) {
+ dev_warn(dev, "%s: Unable to find device opp table\n",
+ __func__);
+ return -ENODEV;
+ }
+
+ /* Get the possible rate from the opp layer */
+ freq = rate;
+ opp = opp_find_freq_ceil(dev, &freq);
+ if (IS_ERR(opp)) {
+ dev_err(dev, "%s: Unable to find OPP for freq%ld\n",
+ __func__, rate);
+ return -ENODEV;
+ }
+ if (unlikely(freq != rate))
+ dev_warn(dev, "%s: Available freq %ld != dpll freq %ld.\n",
+ __func__, freq, rate);
+
+ /* Get the voltage corresponding to the requested frequency */
+ volt = opp_get_voltage(opp);
+
+ /*
+ * Call into the voltage layer to get the final voltage possible
+ * for the voltage domain associated with the device.
+ */
+
+ ret = omap_volt_get_final(dev_opp->volt_domain, dev, &volt);
+ if (ret) {
+ dev_err(dev, "%s: Unable to get the final volt for scaling\n",
+ __func__);
+ return ret;
+ }
+
+ /* Do the actual scaling */
+ return omap_voltage_scale(dev_opp->volt_domain, volt);
+}
+
+/**
+ * omap_device_get_rate - Gets the current operating rate of the device
+ * @dev - the device pointer
+ *
+ * This API returns the current operating rate of the device on success.
+ * Else returns the error value.
+ */
+unsigned long omap_device_get_rate(struct device *dev)
+{
+ struct device_opp *dev_opp;
+
+ dev_opp = opp_find_dev_opp(dev);
+
+ if (IS_ERR(dev_opp)) {
+ dev_warn(dev, "%s: Unable to find device opp table\n",
+ __func__);
+ return -ENODEV;
+ }
+
+ if (!dev_opp->get_rate) {
+ dev_warn(dev, "%s: No get_rate API\n", __func__);
+ return -EINVAL;
+ }
+
+ return dev_opp->get_rate(dev);
+}
--
1.7.0.rc1.33.g07cf0f
next prev parent reply other threads:[~2010-07-02 10:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-02 10:18 [RFC 0/7] OMAP: Basic DVFS framework Thara Gopinath
2010-07-02 10:18 ` [RFC 1/7] OMAP: Introduce a user list for each voltage domain instance in the voltage driver Thara Gopinath
2010-07-02 10:18 ` [RFC 2/7] OMAP: Introduce API in the OPP layer to find the opp entry corresponding to a voltage Thara Gopinath
2010-07-02 10:18 ` [RFC 3/7] OMAP: Introduce voltage domain pointer and device specific set rate and get rate in device opp structures Thara Gopinath
2010-07-02 10:18 ` [RFC 4/7] OMAP: Voltage layer changes to support DVFS Thara Gopinath
2010-07-02 10:18 ` Thara Gopinath [this message]
2010-07-02 10:18 ` [RFC 6/7] OMAP3: Update OMAP3 opp tables to contain the voltage domain and device set rate get rate info Thara Gopinath
2010-07-02 10:18 ` [RFC 7/7] OMAP3: Update cpufreq driver to use the new set_rate API Thara Gopinath
2010-07-08 3:10 ` Pandita, Vikram
2010-07-08 3:11 ` Gopinath, Thara
2010-07-02 11:52 ` [RFC 5/7] OMAP: Introduce set_rate and get_rate API in omap device layer Sripathy, Vishwanath
2010-07-12 14:48 ` [RFC 3/7] OMAP: Introduce voltage domain pointer and device specific set rate and get rate in device opp structures Thomas Petazzoni
2010-07-12 16:01 ` Paul Walmsley
2010-08-02 12:10 ` Cousson, Benoit
2010-08-04 4:01 ` Gopinath, Thara
2010-08-04 0:32 ` Kevin Hilman
2010-08-04 4:02 ` Gopinath, Thara
2010-08-04 21:06 ` Kevin Hilman
2010-08-05 5:48 ` Gopinath, Thara
2010-07-02 11:44 ` [RFC 1/7] OMAP: Introduce a user list for each voltage domain instance in the voltage driver Sripathy, Vishwanath
2010-08-03 23:49 ` [RFC 0/7] OMAP: Basic DVFS framework Kevin Hilman
2010-08-04 3:54 ` Gopinath, Thara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278065909-32148-6-git-send-email-thara@ti.com \
--to=thara@ti.com \
--cc=b-cousson@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=p-basak2@ti.com \
--cc=paul@pwsan.com \
--cc=sawant@ti.com \
--cc=vishwanath.bs@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).