From mboxrd@z Thu Jan 1 00:00:00 1970 From: Artem Bityutskiy Subject: RE: [PATCH 2/2] omap3: sr: improve errors handling Date: Fri, 09 Jul 2010 19:02:46 +0300 Message-ID: <1278691366.9953.149.camel@localhost> References: <1278681612-10521-1-git-send-email-dedekind1@gmail.com> <1278681612-10521-2-git-send-email-dedekind1@gmail.com> <5A47E75E594F054BAF48C5E4FC4B92AB032391F34E@dbde02.ent.ti.com> <1278690245.9953.142.camel@localhost> <4C374585.7030104@ti.com> <1278690635.9953.148.camel@localhost> <7A436F7769CA33409C6B44B358BFFF0C0133957982@dlee02.ent.ti.com> Reply-To: dedekind1@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from smtp.nokia.com ([192.100.105.134]:40803 "EHLO mgw-mx09.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757397Ab0GIQHL (ORCPT ); Fri, 9 Jul 2010 12:07:11 -0400 In-Reply-To: <7A436F7769CA33409C6B44B358BFFF0C0133957982@dlee02.ent.ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Menon, Nishanth" Cc: "Gopinath, Thara" , "linux-omap@vger.kernel.org" , Kevin Hilman , Peter p2 De Schrijver On Fri, 2010-07-09 at 11:00 -0500, Menon, Nishanth wrote: > > -----Original Message----- > > From: Artem Bityutskiy [mailto:dedekind1@gmail.com] > > Sent: Friday, July 09, 2010 10:51 AM > >=20 > > On Fri, 2010-07-09 at 10:51 -0500, Nishanth Menon wrote: > > > > So the logic is: > > > > > > > > 1. The subject line is a short description which gives the idea= what > > the > > > > commit is about. So, my subject line says: > > > > 1.1. It is about omap3 (which is true) > > > > 1.2. It is about sr (which is true) > > > I think Thara's contention is that this is omap_device related- y= eah SR > > > is one of the users of omap_device, but there are much more folks= using > > > omap_device in l-o today. > >=20 > > I see. I'll try to come up with a better prefix, but if you suggest= me a > > good subject line, I'll be grateful :-) >=20 > Subject: omap: device: improve errors handling >=20 > Do not forget to check the 'platform_device_add_data()' error code > in 'omap_device_build_ss()'. >=20 > How does that sound? Good, thank you! I'll re-send the patch tomorrow unless you change the subject yourself :-) --=20 Best Regards, Artem Bityutskiy (=D0=90=D1=80=D1=82=D1=91=D0=BC =D0=91=D0=B8=D1=82=D1=8E= =D1=86=D0=BA=D0=B8=D0=B9) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html